StaffController::update() - Code Metrics - Inspection of "Update master" - idevelopment/timecontrol - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#107)

by Glenn

created 2016-05-01 23:39 UTC

StaffController::update() A

↳ Parent: StaffController

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	22
rs	9.2
cc	2
eloc	15
nc	2
nop	1

<?php

namespace app\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\User;
use App\Countries;
use App\Departments;
use App\Teams;
use App\Role;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Input;
use Illuminate\Support\Facades\Mail;
use Illuminate\Support\Facades\Redirect;
use Intervention\Image\Facades\Image;
use App\Permission;
use Bouncer;
use App\Http\Controllers\Controller;

class StaffController extends Controller
{
    /**
     * StaffController constructor.
     */ 
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    /**
     * Display all users.
     *
     * @return mixed
     */
    public function index()
    {
        $data['users'] = User::orderBy('fname', 'asc')->paginate(10);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return view('staff/users', $data);
    }

    /**
     * Show the form for creating a new employee.
     *
     * @return mixed
     */
    public function create()
    {
        $data['countries'] = Countries::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return view('staff/create_user', $data);
    }

    /**
     * Store a newly created employee in storage.
     *
     * @param Requests\StaffValidator|Request $request
     *
     * @return mixed
     */
    public function store(Requests\StaffValidator $request)
    {
        $user = new User();
        $user->fname = $request->get('fname');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->name = $request->get('name');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->address = $request->get('address');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->postal_code = $request->get('postal_code');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->city = $request->get('city');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->email = $request->get('email');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->password = bcrypt($request->get('password'));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $user->save();

        $mailbox = env('MAIL_USERNAME');
        $mail_password = $request->get('password');
        session()->flash('message', 'New employee has been added to the application');

        $injectionData = ['user' => $user, 'password' => $mail_password];

        Mail::send('emails.new_user', $injectionData, function ($m) use ($user, $mailbox) {
            $m->from($mailbox);
            $m->to($user->email)->subject('Your user credentials!');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        });

        return redirect('staff');
    }

    /**
     * Update a user.
     *
     * @param Int,    $id

     * @param Request $request
     *
     * @return mixed
     */
    public function updateUser($id, Request $request)
    {
        $user = User::find($id);
        $user->fname = $request->get('fname');
        $user->name = $request->get('name');
        $user->address = $request->get('address');
        $user->postal_code = $request->get('postal_code');
        $user->city = $request->get('city');
        $user->email = $request->get('email');
        $user->assignRole($request->get('user_type'));
        $user->update();

        $user = User::find($id);
        Bouncer::assign($request->get('user_typ'))->to($user);

        session()->flash('message', 'User details have been updated');

        return \Redirect::back();
    }

    /**
     * @return mixed
     */
    public function policies()
    {
        $data['roles'] = Role::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return view('staff/roles', $data);
    }

    /**
     * @return mixed
     */
    public function addpolicies()
    {
        $data['permissions'] = Permission::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return view('staff/create_role', $data);
    }

    /**
     * @param Request $request
     *
     * @return string
     */
    public function addRole(Request $request)
    {
        $role = Role::create(['name' => $request->get('role_name')]);
        foreach ($request->get('permissions') as $permission) {
            $role->givePermissionTo($permission);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        if ($assign_role) {

            session()->flash('message', 'New user role has been created');

            return redirect('staff/policies');
        } else {
            return 'Mislukt';
        }
    }

    /**
     * @param $id
     *
     * @return mixed
     */
    public function editpolicies($id)

    {
        $data['permissions'] = Permission::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return view('staff/edit_role', $data);
    }

    /**
     * Remove the user role.
     *
     * @param int, $id

     *
     * @return redirect
     */
    public function destroyRole($id)
    {
        $role = Role::find($id);
        $role->delete();
        session()->flash('message', 'User role has been removed from the database');

        return redirect('staff/policies');
    }

    /**
     * Show all permission.
     */
    public function permissions()
    {
        $data['permissions'] = Permission::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return view('staff/permissions', $data);
    }

    /**
     * Show the form to create a new permission.
     */
    public function createPermission()
    {
        return view('staff/create_permission');
    }

    /**
     * Show the form to edit a permission.
     */
    public function EditPermission(Request $request, $id)

    {
        $data['permission'] = Permission::find($id);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return view('staff/edit_permission', $data);
    }

    /**
     * Save the new permission.
     *
     * @param Request $request
     *
     * @return redirect
     */
    public function savePermission(Request $request)
    {
        Permission::create(['name' => $request->get('permission_name')]);
        session()->flash('message', 'The new permission has been added to the database');

        return redirect('staff/permissions');
    }

    public function destroyPermission($id)
    {
        $permission = Permission::find($id);
        $permission->delete();

        session()->flash('message', 'Permission has been removed from the database');

        return redirect('staff/permissions');
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param $id
     *
     * @return
     */
    public function edit($id)
    {
        $data['user']  = User::findOrFail($id);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $data['departments'] = Departments::all();
        $data['teams'] = Teams::all();
        $data['countries'] = Countries::all();
        $data['roles'] = Role::all();

        return view('staff/edit_user', $data);
    }

    /**
     * @return mixed
     */
    public function profile()
    {
        $data['countries'] = Countries::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return view('staff/profile', $data);
    }

    /**
     * change a password.
     */
    public function chPass()
    {
    }

    /**
     * Update the specified resource in storage.
     *
     * @param Requests\accountManagementValidator|Request $request
     * @return \Illuminate\Http\Response
     */
    public function update(Requests\accountManagementValidator $request)
    {
        $user = User::findOrFail(auth()->user()->id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $user->fname = $request->get('email');
        $user->name = $request->get('name');
        $user->email = $request->get('email');
        $user->address = $request->get('address');
        $user->email = $request->get('email');

        if (Input::file()) {
            $image = Input::file('avatar');
            $filename = time().'.'.$image->getClientOriginalExtension();
            $path = public_path('profilepics/'.$filename);

            Image::make($image->getRealPath())->resize(200, 200)->save($path);
            $user->image = $filename;
        }

        $user->save();

        return redirect()->back();
    }

    /**
     * Remove the specified employee from the database.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        if (!Auth::user()->is('Administrator')) {
            return Redirect::back();
        }

        User::Destroy($id);
        session()->flash('message', 'User has been removed from the database');

        return redirect('staff');
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			namespace app\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use App\Http\Requests;
7			use App\User;
8			use App\Countries;
9			use App\Departments;
10			use App\Teams;
11			use App\Role;
12			use Illuminate\Support\Facades\Auth;
13			use Illuminate\Support\Facades\Input;
14			use Illuminate\Support\Facades\Mail;
15			use Illuminate\Support\Facades\Redirect;
16			use Intervention\Image\Facades\Image;
17			use App\Permission;
18			use Bouncer;
19			use App\Http\Controllers\Controller;
20
21			class StaffController extends Controller
22			{
23			/**
24			* StaffController constructor.
25			*/
26			public function __construct()
27			{
28			$this->middleware('auth');
29			$this->middleware('lang');
30			}
31
32			/**
33			* Display all users.
34			*
35			* @return mixed
36			*/
37			public function index()
38			{
39			$data['users'] = User::orderBy('fname', 'asc')->paginate(10);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-03-25 20:05 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...

idevelopment / timecontrol

Pull Request — master (#107)

StaffController::update() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like