TeamsController::index() - Code Metrics - idevelopment/timecontrol - Measure and Improve Code Quality continuously with Scrutinizer

TeamsController::index() A
last analyzed 2016-03-07 21:24 UTC

↳ Parent: TeamsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	5
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\User;
use App\Teams;

class TeamsController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }
    /**
     * Display all teams.
     */
    public function index()
    {
        $teams = Teams::all();
        return view('teams/list', ['teams' => $teams]);
    }

    /**
     * Show the form for creating a new team.
     */
    public function create()
    {
        $users = User::all();
        return view('teams/create', ['users' => $users]);
    }

    /**
     * Store a newly created team in database.
     */

    public function store(Request $request)
    {
        $team = new Teams;
        $team->name = $request->team_name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $team->name = $request->team_description;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $team->save();
    }

    /**
     * Display details from the specified team.
     */

    public function show($id)

    {
        return view('teams/show');
    }

    /**
     * Show the form for editing the specified resource.
     */
    public function edit($id)

    {
        //
    }

    /**
     * Update the specified team in the database.
     */
    public function update(Request $request, $id)

    {
        //
    }

    /**
     * Remove the specified team from the database.
     */
    public function destroy($id)

    {
        //
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use App\Http\Requests;
7			use App\User;
8			use App\Teams;
9
10			class TeamsController extends Controller
11			{
12			public function __construct()
13			{
14			$this->middleware('auth');
15			}
16			/**
17			* Display all teams.
18			*/
19			public function index()
20			{
21			$teams = Teams::all();
22			return view('teams/list', ['teams' => $teams]);
23			}
24
25			/**
26			* Show the form for creating a new team.
27			*/
28			public function create()
29			{
30			$users = User::all();
31			return view('teams/create', ['users' => $users]);
32			}
33
34			/**
35			* Store a newly created team in database.
36			*/
37
38			public function store(Request $request)
39			{
40			$team = new Teams;
41			$team->name = $request->team_name;
			1 ignored issue – show Documentation introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Teams>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The property `team_name` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
42			$team->name = $request->team_description;
			1 ignored issue – show Documentation introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Teams>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The property `team_description` does not seem to exist in `Illuminate\Http\Request`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
43			$team->save();
44			}
45
46			/**
47			* Display details from the specified team.
48			*/
49
50			public function show($id)
			0 ignored issues – show Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
51			{
52			return view('teams/show');
53			}
54
55			/**
56			* Show the form for editing the specified resource.
57			*/
58			public function edit($id)
			0 ignored issues – show Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
59			{
60			//
61			}
62
63			/**
64			* Update the specified team in the database.
65			*/
66			public function update(Request $request, $id)
			0 ignored issues – show Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
67			{
68			//
69			}
70
71			/**
72			* Remove the specified team from the database.
73			*/
74			public function destroy($id)
			0 ignored issues – show Unused Code introduced 2016-03-03 00:42 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
75			{
76			//
77			}
78			}
79

idevelopment / timecontrol

TeamsController::index() A last analyzed 2016-03-07 21:24 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TeamsController::index() A
last analyzed 2016-03-07 21:24 UTC