StaffController - Code Metrics - Inspection of "Working PR" - idevelopment/RingMe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by Tim

created 2016-05-17 20:09 UTC

StaffController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	22.86 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	7
Bugs	3	Features	3

Metric	Value
wmc	6
c	7
b	3
f	3
lcom	0
cbo	3
dl	16
loc	70
rs	10

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	5	1
A	setAvailable()	8	8	1
A	setUnavailable()	8	8	1
A	profile()	0	4	1
A	destroy()	0	11	1

How to fix Duplicated Code

<?php

namespace App\Http\Controllers;

use App\User;
use Illuminate\Http\Request;

use App\Http\Requests;
use Bouncer;

class StaffController extends Controller
{

    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    /**
     * Display all the staff.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
	{
		$data['users'] = User::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    	return view('users/index', $data);
    }

    /**
     * Set the user available.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function setAvailable()

    {
        $user = User::find(auth()->user()->id);

        Bouncer::retract('unavailable')->from($user);
        Bouncer::assign('available')->to($user);

        return redirect()->back(302);
    }

    /**
     * Set the user unavailable.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function setUnavailable()

    {
        $user = User::find(auth()->user()->id);

        Bouncer::retract('available')->from($user);
        Bouncer::assign('unavailable')->to($user);

        return redirect()->back(302);
    }

    /**
     * Display the profile.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function profile()
    {
    	return view('users/profile');
    }

    public function destroy($id)
    {
        $user = User::find($id);

        // Destroy the user.
        $user->roles()->sync([]);
        User::destroy($id);
        session()->flash('message', 'User deleted');

        return redirect()->to('/staff');
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\User;
6		use Illuminate\Http\Request;
7
8		use App\Http\Requests;
9		use Bouncer;
10
11		class StaffController extends Controller
12		{
13
14		public function __construct()
15		{
16		$this->middleware('auth');
17		$this->middleware('lang');
18		}
19
20		/**
21		* Display all the staff.
22		*
23		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
24		*/
25		public function index()
26		{
27		$data['users'] = User::all();
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-16 08:13 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
28		return view('users/index', $data);
29		}
30
31		/**
32		* Set the user available.
33		*
34		* @return \Illuminate\Http\RedirectResponse
35		*/
36	View Code Duplication	public function setAvailable()
		0 ignored issues – show Duplication introduced 2016-05-17 09:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$user = User::find(auth()->user()->id);
		0 ignored issues – show Bug introduced 2016-05-17 09:29 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
39		Bouncer::retract('unavailable')->from($user);
40		Bouncer::assign('available')->to($user);
41
42		return redirect()->back(302);
43		}
44
45		/**
46		* Set the user unavailable.
47		*
48		* @return \Illuminate\Http\RedirectResponse
49		*/
50	View Code Duplication	public function setUnavailable()
		0 ignored issues – show Duplication introduced 2016-05-17 09:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		$user = User::find(auth()->user()->id);
		0 ignored issues – show Bug introduced 2016-05-17 09:29 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
53		Bouncer::retract('available')->from($user);
54		Bouncer::assign('unavailable')->to($user);
55
56		return redirect()->back(302);
57		}
58
59		/**
60		* Display the profile.
61		*
62		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
63		*/
64		public function profile()
65		{
66		return view('users/profile');
67		}
68
69		public function destroy($id)
70		{
71		$user = User::find($id);
72
73		// Destroy the user.
74		$user->roles()->sync([]);
75		User::destroy($id);
76		session()->flash('message', 'User deleted');
77
78		return redirect()->to('/staff');
79		}
80		}
81

idevelopment / RingMe

Pull Request — master (#37)

StaffController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like