WelcomeController - Code Metrics - Inspection of "New release" - idevelopment/RingMe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#91)

by Glenn

created 2016-09-25 07:24 UTC

WelcomeController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	18.92 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	5
dl	7
loc	37
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	6	1
A	signup()	7	7	1

How to fix Duplicated Code

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;

use App\Departments;
use App\Segments;
use App\User;
use App\ProductsCategories;

class WelcomeController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('lang');
    }

    /**
     * Show the application dashboard.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data["department"] = Departments::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $data["agents"] = User::all();
        return view('welcome', $data);
    }

    /**
     * Show the customer registration form.
     *
     * @return \Illuminate\Http\Response
     */
    public function signup()

    {
      $data["segments"] = Segments::all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
      $data['category'] = ProductsCategories::with('products')->paginate(10)->sortBy("name")->all();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

      return view('auth.register', $data);
    }


}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use Illuminate\Http\Request;
6		use App\Http\Requests;
7
8		use App\Departments;
9		use App\Segments;
10		use App\User;
11		use App\ProductsCategories;
12
13		class WelcomeController extends Controller
14		{
15		/**
16		* Create a new controller instance.
17		*/
18		public function __construct()
19		{
20		$this->middleware('lang');
21		}
22
23		/**
24		* Show the application dashboard.
25		*
26		* @return \Illuminate\Http\Response
27		*/
28		public function index()
29		{
30		$data["department"] = Departments::all();
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-09 03:59 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
31		$data["agents"] = User::all();
32		return view('welcome', $data);
33		}
34
35		/**
36		* Show the customer registration form.
37		*
38		* @return \Illuminate\Http\Response
39		*/
40	View Code Duplication	public function signup()
		0 ignored issues – show Duplication introduced 2016-09-23 06:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$data["segments"] = Segments::all();
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-09-23 06:01 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
43		$data['category'] = ProductsCategories::with('products')->paginate(10)->sortBy("name")->all();
		0 ignored issues – show Bug introduced 2016-09-23 06:01 UTC by Report Bug Copy Issue Report The method `paginate` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44
45		return view('auth.register', $data);
46		}
47
48
49		}
50

idevelopment / RingMe

Pull Request — master (#91)

WelcomeController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like