App\Http\Controllers\CallbackController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	5
Bugs	0	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	5	1
A	create()	0	4	1
A	store()	0	4	1
A	edit()	0	4	1
A	destroy()	0	4	1

<?php

namespace App\Http\Controllers;

use App\Callback;
use Illuminate\Http\Request;

use App\Http\Requests;

/**
 * Class CallbackController
 * @package App\Http\Controllers
 */
class CallbackController extends Controller
{
    /**
     * Display all the callbacks.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
    {
        $data['query'] = Callback::all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

    	return view('callbacks/list', $data);
    }


    /**
     * Create a new callback.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create()
    {
        return view('callbacks.create');
    }

    /**
     * Store a callback request.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store()
    {
        return redirect()->back(302);
    }

    /**
     * Show update form for a callback.
     * 
     * @param  int $id the callback id in the database.
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
    	return view('callbacks/details');
    }

    /**
     * Destroy a callback out off the system.
     *
     * @param  int $id The callback id in the database.
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy($id)

The parameter $id is not used and could be removed.

    {
        return redirect()->back(302);
    }

}