App\Http\Controllers\StaffController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	128
Duplicated Lines	12.5 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	9
Bugs	3	Features	3

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	create()	0	4	1
A	store()	0	4	1
A	update()	0	4	1
A	edit()	0	5	1
A	index()	0	5	1
A	setAvailable()	8	8	1
A	setUnavailable()	8	8	1
A	profile()	0	4	1
A	destroy()	0	10	1

<?php

namespace App\Http\Controllers;

use App\User;
use Illuminate\Http\Request;

use App\Http\Requests;
use Bouncer;

/**
 * Class StaffController
 * @package App\Http\Controllers
 */
class StaffController extends Controller
{

    /**
     * StaffController constructor.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    /**
     * Create new staff member.
     *
     * @TODO   Build up the view
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create()
    {
        return view('staff.create');
    }

    /**
     * Store the new member in the database
     *
     * @TODO:  Needs phpunit test.
     * @TODO:  Build up the controller logic.
     * @TODO:  Build up the request validator.
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store()
    {
        return redirect()->back(302);
    }

    /**
     * Update the staff member.
     *
     * @TODO:  Needs phpunit test
     * @TODO:  Build up the controller.
     * @TODO:  BUild up the request validator.
     * @param  int $id The staff member id in the database.
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update($id)

The parameter $id is not used and could be removed.

    {
        return redirect()->back(302);
    }

    /**
     * Edit view for a staff member.
     *
     * @TODO   Build up the view.
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit($id)
    {
        $data['query'] = User::find($id);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        return view('staff.edit', $data);
    }

    /**
     * Display all the staff.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
	{
		$data['users'] = User::paginate(15);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

    	return view('users/index', $data);
    }

    /**
     * Set the user available.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function setAvailable()

This method seems to be duplicated in your project.

    {
        $user = User::find(auth()->user()->id);

The method user() does not seem to exist on object<Illuminate\Contracts\Auth\Factory>.

        Bouncer::retract('unavailable')->from($user);
        Bouncer::assign('available')->to($user);

        return redirect()->back(302);
    }

    /**
     * Set the user unavailable.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function setUnavailable()

This method seems to be duplicated in your project.

    {
        $user = User::find(auth()->user()->id);

The method user() does not seem to exist on object<Illuminate\Contracts\Auth\Factory>.

        Bouncer::retract('available')->from($user);
        Bouncer::assign('unavailable')->to($user);

        return redirect()->back(302);
    }

    /**
     * Display the profile.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function profile()
    {
    	return view('users/profile');
    }

    /**
     * Destroy or multiple staff members.
     *
     * @param  int $id THe id off the staff member in the database.
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy($id)
    {
        $user = User::find($id);
        $user->roles()->sync([]);

        User::destroy($id);
        session()->flash('message', 'User deleted');

        return redirect()->to('/staff');
    }
}