ProductsController - Code Metrics - Inspection of "New release" - idevelopment/RingMe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#91)

by Glenn

created 2016-09-19 23:08 UTC

ProductsController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
lcom	0
cbo	4
dl	0
loc	51
rs	10

4 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	index()	7	1
A	categories()	5	1
A	store()	16	1

<?php

namespace App\Http\Controllers;

use App\Products;
use App\ProductsCategories;
use Illuminate\Http\Request;

use App\Http\Requests;

class ProductsController extends Controller
{
    /**
     * ProductsController constructor.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    public function index()
    {
        $data['products'] = Products::with('category')->paginate(15);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $data['category'] = ProductsCategories::paginate(15)->sortBy("name");

        return view('products.index', $data);
    }

    public function categories()
    {
        $data['category'] = ProductsCategories::paginate(15)->sortBy("name");
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return view('products.categories', $data);
    }

    /**
     * [METHOD]: Add a new product in the database.
     *
     * @url:platform  POST: /products/save
     * @see:phpunit   TODO: write phpunit test in a later version.
     *
     * @param Requests\ProductValidator $input
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Requests\ProductValidator $input)
    {
        $this->validate($input, [
          'name' => 'required',
          'category' => 'required',
         ]);

        $product       = new Products();
        $product->name = $input->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $product->category()->associate($input->category);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $product->save();

        session()->flash('message', trans('products.flashInsert'));
        return redirect()->back();
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Products;
6			use App\ProductsCategories;
7			use Illuminate\Http\Request;
8
9			use App\Http\Requests;
10
11			class ProductsController extends Controller
12			{
13			/**
14			* ProductsController constructor.
15			*/
16			public function __construct()
17			{
18			$this->middleware('auth');
19			$this->middleware('lang');
20			}
21
22			public function index()
23			{
24			$data['products'] = Products::with('category')->paginate(15);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-09-19 03:41 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history... Bug introduced 2016-09-19 05:04 UTC by Report Bug Copy Issue Report The method `paginate` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
25			$data['category'] = ProductsCategories::paginate(15)->sortBy("name");
26
27			return view('products.index', $data);
28			}
29
30			public function categories()
31			{
32			$data['category'] = ProductsCategories::paginate(15)->sortBy("name");
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-09-19 23:11 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
33			return view('products.categories', $data);
34			}
35
36			/**
37			* [METHOD]: Add a new product in the database.
38			*
39			* @url:platform POST: /products/save
40			* @see:phpunit TODO: write phpunit test in a later version.
41			*
42			* @param Requests\ProductValidator $input
43			* @return \Illuminate\Http\RedirectResponse
44			*/
45			public function store(Requests\ProductValidator $input)
46			{
47			$this->validate($input, [
48			'name' => 'required',
49			'category' => 'required',
50			]);
51
52			$product = new Products();
53			$product->name = $input->name;
			0 ignored issues – show Documentation introduced 2016-09-19 03:41 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Products>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-09-19 03:41 UTC by Report Bug Copy Issue Report The property `name` does not seem to exist in `App\Http\Requests\ProductValidator`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
54
55			$product->category()->associate($input->category);
			0 ignored issues – show Documentation introduced 2016-09-19 03:41 UTC by Report Bug Copy Issue Report The property `category` does not exist on `object<App\Http\Requests\ProductValidator>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56			$product->save();
57
58			session()->flash('message', trans('products.flashInsert'));
59			return redirect()->back();
60			}
61			}
62

idevelopment / RingMe

Pull Request — master (#91)

ProductsController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like