App\Http\Controllers\ProductsController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	99
Duplicated Lines	7.07 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	categories()	0	5	1
A	edit_categories()	0	5	1
A	remove_category()	0	8	1
A	store()	0	16	1
A	saveCat()	0	13	1
A	remove()	0	8	1
A	index()	7	7	1

<?php

namespace App\Http\Controllers;

use App\Products;
use App\ProductsCategories;
use Illuminate\Http\Request;

use App\Http\Requests;

class ProductsController extends Controller
{
    /**
     * ProductsController constructor.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('lang');
    }

    public function index()

This method seems to be duplicated in your project.

    {
        $data['products'] = Products::with('category')->paginate(10);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

The method paginate does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        $data['category'] = ProductsCategories::with('products')->paginate(10)->sortBy("name")->all();

        return view('products.index', $data);
    }

    public function categories()
    {
        $data['category'] = ProductsCategories::with('products')->paginate(10)->sortBy("name")->all();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

The method paginate does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        return view('products.categories', $data);
    }

    public function edit_categories($id)
    {
      $data['category'] = ProductsCategories::find($id);

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

      return view('products.edit_category', $data);
    }

    public function remove_category($id)
    {
      $category = ProductsCategories::find($id);
      $category->delete();

      session()->flash('message', trans('products.removed_category'));
      return redirect()->back();
    }


    /**
     * [METHOD]: Add a new product in the database.
     *
     * @url:platform  POST: /products/save
     * @see:phpunit   TODO: write phpunit test in a later version.
     *
     * @param Requests\ProductValidator $input
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Requests\ProductValidator $input)
    {
        $this->validate($input, [
          'name' => 'required',
          'category' => 'required',
         ]);

        $product       = new Products();
        $product->name = $input->name;

The property name does not exist on object<App\Products>. Since you implemented __set, maybe consider adding a @property annotation.

The property name does not seem to exist in App\Http\Requests\ProductValidator.

        $product->category()->associate($input->category);

The property category does not exist on object<App\Http\Requests\ProductValidator>. Since you implemented __get, maybe consider adding a @property annotation.

        $product->save();

        session()->flash('message', trans('products.saved'));
        return redirect()->back();
    }

    /**
     * [METHOD]: Add a new product category in the database.
     *
     * @url:platform  POST: /products/categories/save
     *
     * @param Requests\ProductValidator $input
     * @return \Illuminate\Http\RedirectResponse
     */
    public function saveCat(Request $input)
    {
      $this->validate($input, [
        'name' => 'required|unique:products_categories'
       ]);

        $category       = new ProductsCategories();
        $category->name = $input->name;

The property name does not exist on object<App\ProductsCategories>. Since you implemented __set, maybe consider adding a @property annotation.

        $category->save();

        session()->flash('message', trans('products.category_saved'));
        return redirect()->back();
    }


    public function remove($id)
    {
      $product = Products::find($id);
      $product->delete();

      session()->flash('message', trans('products.removed'));
      return redirect()->back();
    }
}