icy2003\php\ihelpers\Tree::expand()

Complexity

Conditions	5
Paths	7

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function expand($array, $rootId = '0', $idName = 'id', $pidName = 'pid')
    {
        $array = Arrays::indexBy($array, $idName);
        $array2 = Arrays::indexBy($array, $pidName, true);
        $pidArray = [$rootId];
        $return = [];
        while (true) {
            $temp = [];
            foreach ($pidArray as $pid) {
                $rows = I::get($array2, $pid, []);
                if (empty($rows)) {
                    continue;
                }
                $return = Arrays::merge($return, $rows);
                $temp = Arrays::merge($temp, Arrays::column($rows, $idName));

It seems like $rows can also be of type string; however, parameter $array of icy2003\php\ihelpers\Arrays::column() does only seem to accept array, maybe add an additional type check?

            }
            if (empty($temp)) {
                break;
            }
            $pidArray = $temp;
        }
        return $return;
    }