icy2003\php\ihelpers\Color::__construct()

Complexity

Conditions	12
Paths	12

Size

Total Lines	29
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	12

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function __construct($color, $type = self::TYPE_AUTO)
    {
        if (self::TYPE_AUTO === $type) {
            if (is_array($color)) {
                $this->_color = $color;
                if (3 === count($color)) {
                    $this->_type = self::TYPE_RGB;
                } elseif (4 === count($color)) {
                    $this->_type = self::TYPE_CMYK;
                }
            } else {
                // 接收十六进制（如：0xFF0000和'FF0000'）和颜色名字
                $hex = I::get(static::$_names, $color, $color);
                if ($hex > 0xFFFFFF || $hex < 0 || hexdec($hex) === 0 && $hex !== '000000' && $hex !== '#000000') {

It seems like $hex can also be of type false; however, parameter $hex_string of hexdec() does only seem to accept string, maybe add an additional type check?

                    throw new Exception('错误的颜色值：' . $color);
                }
                // 如果是字符形式的十六进制数，则先转成十进制再作后续运算
                if (is_string($hex)) {
                    $hex = hexdec($hex);
                }
                $this->_type = self::TYPE_HEX;
                $this->_color = $hex;
            }
            if ('unknow' === $this->_type) {
                throw new Exception('错误的颜色类型');
            }
        } else {
            $this->_color = $color;
            $this->_type = $type;
        }