Meteorology::fetchWeather() - Code Metrics - Inspection of "~" - icy2003/php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — dev (222007)

by t

created 2020-01-06 17:35 UTC

Meteorology::fetchWeather() A

↳ Parent: Meteorology

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	13
nc	1
nop	1
dl	0
loc	16
rs	9.8333
c	1
b	0
f	0

<?php

namespace icy2003\php\iapis;

use icy2003\php\iapis\Api;
use icy2003\php\ihelpers\Arrays;
use icy2003\php\ihelpers\Http;
use icy2003\php\ihelpers\Json;

/**
 * 气象（meteorology）接口
 * @link https://blog.csdn.net/weixin_34410662/article/details/93535017
 */
class Meteorology extends Api
{
    /**
     * 获取省份代码
     *
     * @return void
     */
    public function fetchProvinces()
    {
        $this->fetchCitys();
        $this->_toArrayCall = function ($array) {
            return Arrays::columns($array, ['code', 'name']);
        };
    }

    /**
     * 获取城市列表
     *
     * @param string|null $provinceCode 省份代码
     *
     * @return void
     */
    public function fetchCitys($provinceCode = null)
    {
        $res = Http::get('http://www.nmc.cn/f/rest/province/' . $provinceCode);
        $this->_result = Json::decode($res);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->_toArrayCall = function ($array) {
            return Arrays::columns($array, ['code', 'city', 'province']);
        };
    }

    /**
     * 获取天气状况
     * - publish_time：更新时间（2020-01-01 19:35）
     * - airpressure：气压（hPa）
     * - feelst：体感温度（℃）
     * - humidity：相对湿度（%）
     * - icomfort：舒适度
     *      - 温暖，较舒适：1
     *      - 舒适，最可接受：0
     *      - 凉爽，较舒适：-1
     *      - 凉，不舒适：-2
     *      - 冷，很不舒适：-3
     *      - 很冷，极不适应：-4
     * - info：天气（如：晴）
     * - rain：降水（mm）
     * - temperature：气温（℃）
     * - direct：风向（东南风）
     * - power：风强（微风、1 级……）
     *
     * @param string $cityId 城市 ID
     *
     * @return void
     */
    public function fetchWeather($cityId)
    {
        $res = Http::get('http://www.nmc.cn/f/rest/real/' . $cityId);
        $this->_result = Json::decode($res);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->_toArrayCall = function ($array) {
            return Arrays::columns($array, [
                'publish_time',
                'airpressure' => 'weather.airpressure',
                'feelst' => 'weather.feelst',
                'humidity' => 'weather.humidity',
                'info' => 'weather.info',
                'rain'=>'weather.rain',
                'temperature' => 'weather.temperature',
                'direct' => 'wind.direct',
                'power' => 'wind.power',
            ], 1);
        };
    }

    /**
     * 空气质量
     * - forecasttime：发布时间（2020-01-01 19:00）
     * - aq：空气质量
     *      - 优：1
     *      - 良：2
     *      - 轻度污染：3
     *      - 中度污染：4
     * - text：空气质量文本
     *
     * @param string $cityId 城市 ID
     *
     * @return void
     */
    public function fetchAirQuality($cityId)
    {
        $res = Http::get('http://www.nmc.cn/f/rest/aqi/' . $cityId);
        $this->_result = Json::decode($res);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->_toArrayCall = function ($array) {
            return Arrays::columns($array, [
                'forecasttime',
                'aq',
                'text'
            ], 1);
        };
    }

    /**
     * 今天 24 小时实况
     *  - time：时间（2020-01-01 20:00）
     *  - humidity：相对湿度（%）
     *  - pressure：气压（hPa）
     *  - rain：降水（mm）
     *  - temperature：温度（℃）
     *  - windDirection：风向（？）
     *  - windSpeed：风速（？）
     *
     * @param string $cityId 城市 ID
     *
     * @return void
     */
    public function fetchToday($cityId){
        $res = Http::get('http://www.nmc.cn/f/rest/passed/' . $cityId);
        $this->_result = Json::decode($res);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->_toArrayCall = function ($array) {
            return Arrays::columns($array, [
                'time',
                'humidity',
                'pressure',
                'rain'=>'rain1h',
                'temperature',
                'windDirection',
                'windSpeed'
            ], 2);
        };
    }
}


1			<?php
2
3			namespace icy2003\php\iapis;
4
5			use icy2003\php\iapis\Api;
6			use icy2003\php\ihelpers\Arrays;
7			use icy2003\php\ihelpers\Http;
8			use icy2003\php\ihelpers\Json;
9
10			/**
11			* 气象（meteorology）接口
12			* @link https://blog.csdn.net/weixin_34410662/article/details/93535017
13			*/
14			class Meteorology extends Api
15			{
16			/**
17			* 获取省份代码
18			*
19			* @return void
20			*/
21			public function fetchProvinces()
22			{
23			$this->fetchCitys();
24			$this->_toArrayCall = function ($array) {
25			return Arrays::columns($array, ['code', 'name']);
26			};
27			}
28
29			/**
30			* 获取城市列表
31			*
32			* @param string\|null $provinceCode 省份代码
33			*
34			* @return void
35			*/
36			public function fetchCitys($provinceCode = null)
37			{
38			$res = Http::get('http://www.nmc.cn/f/rest/province/' . $provinceCode);
39			$this->_result = Json::decode($res);
			0 ignored issues – show Documentation Bug introduced 2020-01-06 17:41 UTC by Report Bug Copy Issue Report It seems like `icy2003\php\ihelpers\Json::decode($res)` can also be of type `false`. However, the property `$_result` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
40			$this->_toArrayCall = function ($array) {
41			return Arrays::columns($array, ['code', 'city', 'province']);
42			};
43			}
44
45			/**
46			* 获取天气状况
47			* - publish_time：更新时间（2020-01-01 19:35）
48			* - airpressure：气压（hPa）
49			* - feelst：体感温度（℃）
50			* - humidity：相对湿度（%）
51			* - icomfort：舒适度
52			* - 温暖，较舒适：1
53			* - 舒适，最可接受：0
54			* - 凉爽，较舒适：-1
55			* - 凉，不舒适：-2
56			* - 冷，很不舒适：-3
57			* - 很冷，极不适应：-4
58			* - info：天气（如：晴）
59			* - rain：降水（mm）
60			* - temperature：气温（℃）
61			* - direct：风向（东南风）
62			* - power：风强（微风、1 级……）
63			*
64			* @param string $cityId 城市 ID
65			*
66			* @return void
67			*/
68			public function fetchWeather($cityId)
69			{
70			$res = Http::get('http://www.nmc.cn/f/rest/real/' . $cityId);
71			$this->_result = Json::decode($res);
			0 ignored issues – show Documentation Bug introduced 2020-01-06 17:41 UTC by Report Bug Copy Issue Report It seems like `icy2003\php\ihelpers\Json::decode($res)` can also be of type `false`. However, the property `$_result` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
72			$this->_toArrayCall = function ($array) {
73			return Arrays::columns($array, [
74			'publish_time',
75			'airpressure' => 'weather.airpressure',
76			'feelst' => 'weather.feelst',
77			'humidity' => 'weather.humidity',
78			'info' => 'weather.info',
79			'rain'=>'weather.rain',
80			'temperature' => 'weather.temperature',
81			'direct' => 'wind.direct',
82			'power' => 'wind.power',
83			], 1);
84			};
85			}
86
87			/**
88			* 空气质量
89			* - forecasttime：发布时间（2020-01-01 19:00）
90			* - aq：空气质量
91			* - 优：1
92			* - 良：2
93			* - 轻度污染：3
94			* - 中度污染：4
95			* - text：空气质量文本
96			*
97			* @param string $cityId 城市 ID
98			*
99			* @return void
100			*/
101			public function fetchAirQuality($cityId)
102			{
103			$res = Http::get('http://www.nmc.cn/f/rest/aqi/' . $cityId);
104			$this->_result = Json::decode($res);
			0 ignored issues – show Documentation Bug introduced 2020-01-06 17:41 UTC by Report Bug Copy Issue Report It seems like `icy2003\php\ihelpers\Json::decode($res)` can also be of type `false`. However, the property `$_result` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
105			$this->_toArrayCall = function ($array) {
106			return Arrays::columns($array, [
107			'forecasttime',
108			'aq',
109			'text'
110			], 1);
111			};
112			}
113
114			/**
115			* 今天 24 小时实况
116			* - time：时间（2020-01-01 20:00）
117			* - humidity：相对湿度（%）
118			* - pressure：气压（hPa）
119			* - rain：降水（mm）
120			* - temperature：温度（℃）
121			* - windDirection：风向（？）
122			* - windSpeed：风速（？）
123			*
124			* @param string $cityId 城市 ID
125			*
126			* @return void
127			*/
128			public function fetchToday($cityId){
129			$res = Http::get('http://www.nmc.cn/f/rest/passed/' . $cityId);
130			$this->_result = Json::decode($res);
			0 ignored issues – show Documentation Bug introduced 2020-01-06 17:41 UTC by Report Bug Copy Issue Report It seems like `icy2003\php\ihelpers\Json::decode($res)` can also be of type `false`. However, the property `$_result` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
131			$this->_toArrayCall = function ($array) {
132			return Arrays::columns($array, [
133			'time',
134			'humidity',
135			'pressure',
136			'rain'=>'rain1h',
137			'temperature',
138			'windDirection',
139			'windSpeed'
140			], 2);
141			};
142			}
143			}
144

icy2003 / php

GitHub Access Token became invalid

Branch — dev (222007)

Meteorology::fetchWeather() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like