Issues in NativeReadStream.php (master) - Issues in master - icewind1991/SMB - Measure and Improve Code Quality continuously with Scrutinizer

Issues (45)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Native/NativeReadStream.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Copyright (c) 2014 Robin Appelman <[email protected]>
 * This file is licensed under the Licensed under the MIT license:
 * http://opensource.org/licenses/MIT
 */

namespace Icewind\SMB\Native;

use Icewind\SMB\StringBuffer;

/**
 * Stream optimized for read only usage
 */
class NativeReadStream extends NativeStream {
	const CHUNK_SIZE = 1048576; // 1MB chunks

	/** @var StringBuffer */
	private $readBuffer;

	public function __construct() {
		$this->readBuffer = new StringBuffer();
	}

	/** @var int */
	private $pos = 0;

	public function stream_open($path, $mode, $options, &$opened_path) {
		return parent::stream_open($path, $mode, $options, $opened_path);
	}

	/**
	 * Wrap a stream from libsmbclient-php into a regular php stream
	 *
	 * @param NativeState $state
	 * @param resource $smbStream
	 * @param string $mode
	 * @param string $url
	 * @return resource
	 */
	public static function wrap(NativeState $state, $smbStream, string $mode, string $url) {
		return parent::wrapClass($state, $smbStream, $mode, $url, NativeReadStream::class);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
	}

	public function stream_read($count) {
		// php reads 8192 bytes at once
		// however due to network latency etc, it's faster to read in larger chunks
		// and buffer the result
		if (!parent::stream_eof() && $this->readBuffer->remaining() < $count) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
			$chunk = parent::stream_read(self::CHUNK_SIZE);
			if ($chunk === false) {
				return false;
			}
			$this->readBuffer->push($chunk);
		}

		$result = $this->readBuffer->read($count);

		$read = strlen($result);
		$this->pos += $read;

		return $result;
	}

	public function stream_seek($offset, $whence = SEEK_SET) {

		$result = parent::stream_seek($offset, $whence);
		if ($result) {
			$this->readBuffer->clear();
			$pos = parent::stream_tell();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
			if ($pos === false) {
				return false;
			}
			$this->pos = $pos;
		}
		return $result;
	}

	public function stream_eof() {
		return $this->readBuffer->remaining() <= 0 && parent::stream_eof();
	}

	public function stream_tell() {
		return $this->pos;
	}

	public function stream_write($data) {
		return false;
	}

	public function stream_truncate($size) {
		return false;
	}
}


1			<?php
2			/**
3			* Copyright (c) 2014 Robin Appelman <[email protected]>
4			* This file is licensed under the Licensed under the MIT license:
5			* http://opensource.org/licenses/MIT
6			*/
7
8			namespace Icewind\SMB\Native;
9
10			use Icewind\SMB\StringBuffer;
11
12			/**
13			* Stream optimized for read only usage
14			*/
15			class NativeReadStream extends NativeStream {
16			const CHUNK_SIZE = 1048576; // 1MB chunks
17
18			/** @var StringBuffer */
19			private $readBuffer;
20
21			public function __construct() {
22			$this->readBuffer = new StringBuffer();
23			}
24	40
25	40		/** @var int */
26			private $pos = 0;
27	40
28			public function stream_open($path, $mode, $options, &$opened_path) {
29			return parent::stream_open($path, $mode, $options, $opened_path);
30			}
31
32			/**
33			* Wrap a stream from libsmbclient-php into a regular php stream
34			*
35			* @param NativeState $state
36			* @param resource $smbStream
37			* @param string $mode
38			* @param string $url
39	40		* @return resource
40	40		*/
41	40		public static function wrap(NativeState $state, $smbStream, string $mode, string $url) {
42			return parent::wrapClass($state, $smbStream, $mode, $url, NativeReadStream::class);
			0 ignored issues – show Comprehensibility Bug introduced 2021-03-10 14:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`wrapClass()` instead of `wrap()`). Are you sure this is correct? If so, you might want to change this to `$this->wrapClass()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
43	40		}
44	40
45	40		public function stream_read($count) {
46			// php reads 8192 bytes at once
47			// however due to network latency etc, it's faster to read in larger chunks
48	40		// and buffer the result
49	40		if (!parent::stream_eof() && $this->readBuffer->remaining() < $count) {
			0 ignored issues – show Comprehensibility Bug introduced 2017-08-16 14:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`stream_eof()` instead of `stream_read()`). Are you sure this is correct? If so, you might want to change this to `$this->stream_eof()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
50	40		$chunk = parent::stream_read(self::CHUNK_SIZE);
51			if ($chunk === false) {
52			return false;
53	38		}
54			$this->readBuffer->push($chunk);
55			}
56
57	38		$result = $this->readBuffer->read($count);
58	38
59	38		$read = strlen($result);
60	38		$this->pos += $read;
61	38
62	38		return $result;
63	38		}
64
65		View Code Duplication	public function stream_seek($offset, $whence = SEEK_SET) {
			0 ignored issues – show Duplication introduced 2021-03-09 19:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66	38		$result = parent::stream_seek($offset, $whence);
67	38		if ($result) {
68			$this->readBuffer->clear();
69	38		$pos = parent::stream_tell();
			0 ignored issues – show Comprehensibility Bug introduced 2017-08-16 14:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`stream_tell()` instead of `stream_seek()`). Are you sure this is correct? If so, you might want to change this to `$this->stream_tell()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
70	38		if ($pos === false) {
71			return false;
72	38		}
73			$this->pos = $pos;
74			}
75	2		return $result;
76	2		}
77	2
78	2		public function stream_eof() {
79	2		return $this->readBuffer->remaining() <= 0 && parent::stream_eof();
80	2		}
81
82	2		public function stream_tell() {
83			return $this->pos;
84			}
85	38
86	38		public function stream_write($data) {
87			return false;
88			}
89	2
90	2		public function stream_truncate($size) {
91			return false;
92			}
93			}
94

icewind1991 / SMB

Issues (45)

Security Analysis no request data

src/Native/NativeReadStream.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like