NativeServer::listShares() - Code Metrics - Inspection of "use dir instead of allinfo where possible" - icewind1991/SMB - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable2 ( 10fadc...4d0e89 )

by Robin

created 2019-02-06 16:00 UTC

NativeServer::listShares() A

↳ Parent: NativeServer

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	11
cp	0
rs	9.8666
c	0
b	0
f	0
cc	3
nc	3
nop	0
crap	12

<?php
/**
 * Copyright (c) 2014 Robin Appelman <[email protected]>
 * This file is licensed under the Licensed under the MIT license:
 * http://opensource.org/licenses/MIT
 */

namespace Icewind\SMB;

class NativeServer extends Server {
	/**
	 * @var \Icewind\SMB\NativeState
	 */
	protected $state;

	/**
	 * @param string $host
	 * @param string $user
	 * @param string $password
	 */
	public function __construct($host, $user, $password) {
		parent::__construct($host, $user, $password);
		$this->state = new NativeState();
	}

	protected function connect() {
		$this->state->init($this->getWorkgroup(), $this->getUser(), $this->getPassword());
	}

	/**
	 * @return \Icewind\SMB\IShare[]
	 * @throws \Icewind\SMB\Exception\AuthenticationException
	 * @throws \Icewind\SMB\Exception\InvalidHostException
	 */
	public function listShares() {
		$this->connect();
		$shares = array();
		$dh = $this->state->opendir('smb://' . $this->getHost());
		while ($share = $this->state->readdir($dh)) {
			if ($share['type'] === 'file share') {
				$shares[] = $this->getShare($share['name']);
			}
		}
		$this->state->closedir($dh);
		return $shares;
	}

	/**
	 * @param string $name
	 * @return \Icewind\SMB\IShare
	 */
	public function getShare($name) {
		return new NativeShare($this, $name);
	}
}


1			<?php
2			/**
3			* Copyright (c) 2014 Robin Appelman <[email protected]>
4			* This file is licensed under the Licensed under the MIT license:
5			* http://opensource.org/licenses/MIT
6			*/
7
8			namespace Icewind\SMB;
9
10			class NativeServer extends Server {
11			/**
12			* @var \Icewind\SMB\NativeState
13			*/
14			protected $state;
15
16			/**
17			* @param string $host
18			* @param string $user
19			* @param string $password
20			*/
21			public function __construct($host, $user, $password) {
22			parent::__construct($host, $user, $password);
23			$this->state = new NativeState();
24			}
25
26			protected function connect() {
27			$this->state->init($this->getWorkgroup(), $this->getUser(), $this->getPassword());
28			}
29
30			/**
31			* @return \Icewind\SMB\IShare[]
32			* @throws \Icewind\SMB\Exception\AuthenticationException
33			* @throws \Icewind\SMB\Exception\InvalidHostException
34			*/
35			public function listShares() {
36			$this->connect();
37			$shares = array();
38			$dh = $this->state->opendir('smb://' . $this->getHost());
39			while ($share = $this->state->readdir($dh)) {
40			if ($share['type'] === 'file share') {
41			$shares[] = $this->getShare($share['name']);
42			}
43			}
44			$this->state->closedir($dh);
45			return $shares;
46			}
47
48			/**
49			* @param string $name
50			* @return \Icewind\SMB\IShare
51			*/
52			public function getShare($name) {
53			return new NativeShare($this, $name);
54			}
55			}
56

icewind1991 / SMB

Push — stable2 ( 10fadc...4d0e89 )

NativeServer::listShares() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like