EloquentSetting::setSetting() - Code Metrics - Inspection of "fix bug" - ibrandcc/setting - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3f3d5c...32d12e )

unknown

created 2018-10-15 12:02 UTC

EloquentSetting::setSetting() A

↳ Parent: EloquentSetting

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.128

Importance

Changes

Metric	Value
cc	4
nc	4
nop	1
dl	0
loc	18
ccs	8
cts	10
cp	0.8
crap	4.128
rs	9.6666
c	0
b	0
f	0

<?php

/*
 * This file is part of ibrand/setting.
 *
 * (c) iBrand <https://www.ibrand.cc>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace iBrand\Component\Setting\Repositories;

use iBrand\Component\Setting\Models\SystemSetting;

/**
 * Class EloquentSetting
 * @package iBrand\Component\Setting\Repositories
 */
class EloquentSetting implements SettingInterface
{
    /**
     * @var SystemSetting
     */
    private $model;

    /**
     * EloquentSetting constructor.
     * @param SystemSetting $model
     */
    public function __construct(SystemSetting $model)
    {
        $this->model = $model;
    }

    /**
     * @param array $settings
     * @return bool
     */
    public function setSetting(array $settings)
    {
        if (count($settings)<=0) {
            return false;
        }

        foreach ($settings as $key => $val) {
            $var = $this->model->where('key', $key)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($var) {
                $var->value = $val;
                $var->save();
            } else {
                $var = $this->model->create(['key' => $key, 'value' => $val]);

            }
        }

        return $var;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * @param $key
     * @param null $input
     * @return bool|mixed|string
     */
    public function getSetting($key,$input=null)
    {
        $value = $this->model->where('key', $key)->get(['value'])->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        if (!is_null($value)) {
            return $value->value;
        }

        if(!is_null($input)){

            return $input;
        }

        return '';
    }

    /**
     * @return array
     */
    public function allToArray()
    {
        $collection = $this->model->all();
        $keyed = $collection->mapWithKeys(function ($item) {
            return [$item->key => $item->value];
        });

        return $keyed->toArray();
    }
}


1		<?php
2
3		/*
4		* This file is part of ibrand/setting.
5		*
6		* (c) iBrand <https://www.ibrand.cc>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace iBrand\Component\Setting\Repositories;
13
14		use iBrand\Component\Setting\Models\SystemSetting;
15
16		/**
17		* Class EloquentSetting
18		* @package iBrand\Component\Setting\Repositories
19		*/
20		class EloquentSetting implements SettingInterface
21		{
22		/**
23		* @var SystemSetting
24		*/
25		private $model;
26
27		/**
28		* EloquentSetting constructor.
29		* @param SystemSetting $model
30		*/
31	6	public function __construct(SystemSetting $model)
32		{
33	6	$this->model = $model;
34	6	}
35
36		/**
37		* @param array $settings
38		* @return bool
39		*/
40	5	public function setSetting(array $settings)
41		{
42	5	if (count($settings)<=0) {
43	1	return false;
44		}
45
46	5	foreach ($settings as $key => $val) {
47	5	$var = $this->model->where('key', $key)->first();
		0 ignored issues – show Documentation Bug introduced 2018-01-29 10:20 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<iBrand\Component\...g\Models\SystemSetting>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
48	5	if ($var) {
49		$var->value = $val;
50		$var->save();
51		} else {
52	5	$var = $this->model->create(['key' => $key, 'value' => $val]);
		0 ignored issues – show Bug introduced 2018-01-29 10:20 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `iBrand\Component\Setting\Models\SystemSetting`. Did you maybe mean `created()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
53		}
54		}
55
56	5	return $var;
		0 ignored issues – show Bug introduced 2018-01-29 10:20 UTC by Report Bug Copy Issue Report The variable `$var` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
57		}
58
59		/**
60		* @param $key
61		* @param null $input
62		* @return bool\|mixed\|string
63		*/
64	1	public function getSetting($key,$input=null)
65		{
66	1	$value = $this->model->where('key', $key)->get(['value'])->first();
		0 ignored issues – show Documentation Bug introduced 2018-01-29 10:20 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<iBrand\Component\...g\Models\SystemSetting>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
67
68	1	if (!is_null($value)) {
69	1	return $value->value;
70		}
71
72	1	if(!is_null($input)){
73
74	1	return $input;
75		}
76
77	1	return '';
78		}
79
80		/**
81		* @return array
82		*/
83	2	public function allToArray()
84		{
85	2	$collection = $this->model->all();
86	2	$keyed = $collection->mapWithKeys(function ($item) {
87	2	return [$item->key => $item->value];
88	2	});
89
90	2	return $keyed->toArray();
91		}
92		}
93

ibrandcc / setting

Push — master ( 3f3d5c...32d12e )

EloquentSetting::setSetting() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like