iBrand\Component\Discount\Actions\OrderFixedDiscountAction

Complexity

Total Complexity

6

Size/Duplication

Total Lines	77
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

95.65%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	execute()	19	19	3
A	calculateAdjustmentAmount()	4	4	1
A	calculate()	12	12	1

<?php

/*
 * This file is part of ibrand/discount.
 *
 * (c) iBrand <https://www.ibrand.cc>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace iBrand\Component\Discount\Actions;

use iBrand\Component\Discount\Contracts\DiscountActionContract;
use iBrand\Component\Discount\Contracts\DiscountContract;
use iBrand\Component\Discount\Contracts\DiscountSubjectContract;
use iBrand\Component\Discount\Distributors\PercentageIntegerDistributor;
use Illuminate\Support\Collection;

/**
 * Class OrderFixedDiscountAction.
 */
class OrderFixedDiscountAction extends DiscountAction implements DiscountActionContract

This class seems to be duplicated in your project.

{
    const TYPE = 'order_fixed_discount';

    /**
     * @var IntegerDistributor
     */
    private $distributor;

    /**
     * OrderFixedDiscountAction constructor.
     *
     * @param IntegerDistributor $distributor
     */
    public function __construct(PercentageIntegerDistributor $distributor)
    {
        $this->distributor = $distributor;

It seems like $distributor of type object<iBrand\Component\Discount\Distributors\PercentageIntegerDistributor> is incompatible with the declared type object<iBrand\Component\Discount\Actions\IntegerDistributor> of property $distributor.

    }

    /**
     * @param DiscountSubjectContract $subject
     * @param array                   $configuration
     * @param DiscountContract        $discount
     *
     * @return mixed|void
     */
    public function execute(DiscountSubjectContract $subject, array $configuration, DiscountContract $discount)
    {
        $discountAmount = $this->calculateAdjustmentAmount($subject->getCurrentTotal(), $configuration['amount']);

        if (0 === $discountAmount) {
            return;
        }

        $adjustment = $this->createAdjustment($discount, $discountAmount);
        $subject->addAdjustment($adjustment);

        $splitDiscountAmount = $this->distributor->distribute($subject->getItems()->pluck('total')->toArray(), $discountAmount);

        $i = 0;
        foreach ($subject->getItems() as $item) {
            $item->divide_order_discount += $splitDiscountAmount[$i++];
            $item->recalculateAdjustmentsTotal();
        }
    }

    /**
     * @param $discountSubjectTotal
     * @param $targetDiscountAmount
     *
     * @return float|int
     */
    private function calculateAdjustmentAmount($discountSubjectTotal, $targetDiscountAmount)
    {
        return -1 * min($discountSubjectTotal, $targetDiscountAmount);
    }

    /**
     * @param DiscountSubjectContract $subject
     * @param array                   $configuration
     * @param DiscountContract        $discount
     *
     * @return float|int|mixed
     */
    public function calculate(DiscountSubjectContract $subject, array $configuration, DiscountContract $discount)
    {
        $discount->adjustments = new Collection();

Accessing adjustments on the interface iBrand\Component\Discount\Contracts\DiscountContract suggest that you code against a concrete implementation. How about adding an instanceof check?

        $discountAmount = $this->calculateAdjustmentAmount($subject->getCurrentTotal(), $configuration['amount']);

        $discount->adjustments->push(['order_id' => $subject->id, 'amount' => $discountAmount]);

Accessing adjustments on the interface iBrand\Component\Discount\Contracts\DiscountContract suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing id on the interface iBrand\Component\Discount\Contracts\DiscountSubjectContract suggest that you code against a concrete implementation. How about adding an instanceof check?

        $discount->adjustmentTotal = $discountAmount;

Accessing adjustmentTotal on the interface iBrand\Component\Discount\Contracts\DiscountContract suggest that you code against a concrete implementation. How about adding an instanceof check?

        return $discountAmount;
    }
}