iBrand\Component\Discount\Actions\DiscountAction

Complexity

Total Complexity

2

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	createAdjustment()	0	8	2

<?php

/*
 * This file is part of ibrand/discount.
 *
 * (c) iBrand <https://www.ibrand.cc>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace iBrand\Component\Discount\Actions;

use iBrand\Component\Discount\Contracts\AdjustmentContract;
use iBrand\Component\Discount\Contracts\DiscountActionContract;
use iBrand\Component\Discount\Contracts\DiscountContract;

abstract class DiscountAction implements DiscountActionContract
{
    /**
     * @param DiscountContract $discount
     * @param $amount
     *
     * @return mixed
     */
    protected function createAdjustment(DiscountContract $discount, $amount)
    {
        $adjustment = app(AdjustmentContract::class);

        $originType = $discount->isCouponBased() ? 'coupon' : 'discount';

        return $adjustment->createNew(AdjustmentContract::ORDER_DISCOUNT_ADJUSTMENT, $discount->label, $amount, $discount->id, $originType);

Accessing label on the interface iBrand\Component\Discount\Contracts\DiscountContract suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing id on the interface iBrand\Component\Discount\Contracts\DiscountContract suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}