App\Http\Requests\Denomination\UpdateRequest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

94.44%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	updateImage()	0	21	4
A	rules()	0	10	1

<?php

namespace App\Http\Requests\Denomination;

use App\Enum\DenominationType;
use App\Models\Denomination;
use Illuminate\Support\Facades\Storage;
use Illuminate\Validation\Rule;

class UpdateRequest extends AbstractRequest
{
    /**
     * {@inheritDoc}
     */
    public function rules()
    {
        return [
            'name' => 'required|string|max:255',
            'value' => ['required', 'numeric', 'min:0', Rule::unique(Denomination::class)->ignoreModel($this->route('denomination'))],
            'type' => 'required|enum:' . DenominationType::class,
            'quantity_per_bundle' => 'required|numeric|min:0',
            'minimum_order_bundle' => 'required|numeric|min:0',
            'maximum_order_bundle' => 'required|numeric|gte:minimum_order_bundle',
            'image' => 'sometimes|nullable|image',
        ];
    }

    /**
     * Update the image file from the incoming request.
     *
     * @param  string  $key
     * @return string|null
     */
    public function updateImage(string $key = 'image'): ?string
    {
        if (!$this->hasFile($key)) {
            return null;
        }

        /** @var \App\Models\Denomination $model */
        $model = $this->route('denomination');

        if ($model->getRawOriginal('image') && $this->hasFile($key)) {
            Storage::delete(Denomination::IMAGE_PATH . '/' . $model->getRawOriginal('image'));

Are you sure $model->getRawOriginal('image') of type array|mixed can be used in concatenation?

        }

        $file = $this->file($key);

        $file->storeAs(
            Denomination::IMAGE_PATH,
            $filename = ($this->input('value') . '.' . $file->getClientOriginalExtension())
        );

        return $filename;
    }
}