OrderCreated::getTelegramMessage() - Code Metrics - Inspection of "+ Create event to notify admin when order was crea..." - ianriizky/bcadenpasar-chatbot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( d32912...6dcea6 )

by Septianata

created 2021-07-27 23:51 UTC

OrderCreated::getTelegramMessage() A

↳ Parent: OrderCreated

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
c	1
b	0
f	0
dl	0
loc	5
ccs	0
cts	4
cp	0
rs	10
cc	1
nc	1
nop	0
crap	2

<?php

namespace App\Events;

use App\Contracts\Event\CanSendTelegramNotification;
use App\Models\Contracts\HasTelegramChatId;
use App\Models\Order;
use App\Support\Events\HandleRecipient;
use Illuminate\Broadcasting\InteractsWithSockets;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Events\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;

class OrderCreated implements CanSendTelegramNotification, ShouldQueue
{
    use Dispatchable, InteractsWithSockets, SerializesModels, InteractsWithQueue,

        HandleRecipient;

    /**
     * The order instance data.
     *
     * @var \App\Models\Order
     */
    protected Order $order;

    /**
     * The recipient data that will receive the notification.
     *
     * @var \App\Models\Contracts\HasTelegramChatId
     */
    protected HasTelegramChatId $recipient;

    /**
     * Create a new event instance.
     *
     * @param  \App\Models\Order  $order
     * @param  \App\Models\Contracts\HasTelegramChatId|null  $recipient
     * @return void
     */
    public function __construct(Order $order, HasTelegramChatId $recipient = null)
    {
        $this->order = $order;
        $this->recipient = $this->findRecipientFromUser($recipient);
    }

    /**
     * Return telegram chat id value.
     *
     * @return string|array
     */
    public function getTelegramChatId()
    {
        return $this->recipient->getTelegramChatId();
    }

    /**
     * Return telegram chat message content.
     *
     * @return string
     */
    public function getTelegramMessage(): string
    {
        return view('notifications.order-created', [

            'order' => $this->order,
        ])->render();
    }
}


1			<?php
2
3			namespace App\Events;
4
5			use App\Contracts\Event\CanSendTelegramNotification;
6			use App\Models\Contracts\HasTelegramChatId;
7			use App\Models\Order;
8			use App\Support\Events\HandleRecipient;
9			use Illuminate\Broadcasting\InteractsWithSockets;
10			use Illuminate\Contracts\Queue\ShouldQueue;
11			use Illuminate\Foundation\Events\Dispatchable;
12			use Illuminate\Queue\InteractsWithQueue;
13			use Illuminate\Queue\SerializesModels;
14
15			class OrderCreated implements CanSendTelegramNotification, ShouldQueue
16			{
17			use Dispatchable, InteractsWithSockets, SerializesModels, InteractsWithQueue,
			0 ignored issues – show introduced 2021-07-27 23:56 UTC by Report Bug Copy Issue Report The trait `Illuminate\Queue\SerializesModels` requires some properties which are not provided by `App\Events\OrderCreated`: `$id`, `$relations`, `$class`, `$connection`, `$keyBy` Loading history...
18			HandleRecipient;
19
20			/**
21			* The order instance data.
22			*
23			* @var \App\Models\Order
24			*/
25			protected Order $order;
26
27			/**
28			* The recipient data that will receive the notification.
29			*
30			* @var \App\Models\Contracts\HasTelegramChatId
31			*/
32			protected HasTelegramChatId $recipient;
33
34			/**
35			* Create a new event instance.
36			*
37			* @param \App\Models\Order $order
38			* @param \App\Models\Contracts\HasTelegramChatId\|null $recipient
39			* @return void
40			*/
41			public function __construct(Order $order, HasTelegramChatId $recipient = null)
42			{
43			$this->order = $order;
44			$this->recipient = $this->findRecipientFromUser($recipient);
45			}
46
47			/**
48			* Return telegram chat id value.
49			*
50			* @return string\|array
51			*/
52			public function getTelegramChatId()
53			{
54			return $this->recipient->getTelegramChatId();
55			}
56
57			/**
58			* Return telegram chat message content.
59			*
60			* @return string
61			*/
62			public function getTelegramMessage(): string
63			{
64			return view('notifications.order-created', [
			0 ignored issues – show Bug Best Practice introduced 2021-07-27 23:56 UTC by Report Bug Copy Issue Report The expression `return view('notificatio...this->order))->render()` could return the type `array` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
65			'order' => $this->order,
66			])->render();
67			}
68			}
69

ianriizky / bcadenpasar-chatbot

Push — develop ( d32912...6dcea6 )

OrderCreated::getTelegramMessage() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like