App\Models\Concerns\Denomination\Attribute

Complexity

Total Complexity

22

Size/Duplication

Total Lines	148
Duplicated Lines	0 %

Test Coverage

Coverage

35%

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	getCanOrderCustomQuantityBadgeAttribute()	0	10	4
A	getRangeOrderBundleAttribute()	0	3	1
A	getMaximumOrderValueAttribute()	0	3	1
A	getMinimumOrderValueAttribute()	0	3	1
A	getTypeBadgeAttribute()	0	10	3
A	getValuePerBundleAttribute()	0	3	1
A	getImageAttribute()	0	7	2
A	getValueRupiahAttribute()	0	3	1
A	getIsVisibleBadgeAttribute()	0	10	4
A	getMaximumOrderQuantityAttribute()	0	7	2
A	getMinimumOrderQuantityAttribute()	0	7	2

<?php

namespace App\Models\Concerns\Denomination;

use Illuminate\Support\Facades\Storage;

/**
 * @property string $code
 * @property string $name
 * @property float $value
 * @property \App\Enum\DenominationType $type
 * @property int $quantity_per_bundle
 * @property int $minimum_order_bundle
 * @property int $maximum_order_bundle
 * @property int $minimum_order_quantity
 * @property int $maximum_order_quantity
 * @property bool $can_order_custom_quantity
 * @property bool $is_visible
 * @property string $image
 * @property-read array $range_order_bundle
 * @property-read float $value_per_bundle
 * @property-read float $minimum_order_value
 * @property-read float $maximum_order_value
 * @property-read string $value_rupiah
 * @property-read string $type_badge
 * @property-read string $can_order_custom_quantity_badge
 * @property-read string $is_visible_badge
 *
 * @see \App\Models\Denomination
 */
trait Attribute
{
    /**
     * Return "minimum_order_quantity" attribute value.
     *
     * @param  mixed  $value
     * @return int
     */
    public function getMinimumOrderQuantityAttribute($value): int
    {
        if ($this->can_order_custom_quantity) {
            return $this->castAttribute('minimum_order_quantity', $value);

It seems like castAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this->countMinimumOrderQuantityAttribute();

It seems like countMinimumOrderQuantityAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Return "maximum_order_quantity" attribute value.
     *
     * @param  mixed  $value
     * @return int
     */
    public function getMaximumOrderQuantityAttribute($value): int
    {
        if ($this->can_order_custom_quantity) {
            return $this->castAttribute('maximum_order_quantity', $value);
        }

        return $this->countMaximumOrderQuantityAttribute();

It seems like countMaximumOrderQuantityAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Return "image" attribute value.
     *
     * @param  mixed  $value
     * @return string
     */
    public function getImageAttribute($value): string
    {
        if (is_null($value)) {
            return asset('img/dummy.png');
        }

        return Storage::url(static::IMAGE_PATH . '/' . $value);

The constant App\Models\Concerns\Denomination\Attribute::IMAGE_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * Return "range_order_bundle" attribute value.
     *
     * @return array
     */
    public function getRangeOrderBundleAttribute(): array
    {
        return range($this->minimum_order_bundle, $this->maximum_order_bundle);
    }

    /**
     * Return "value_per_bundle" attribute value.
     *
     * @return float
     */
    public function getValuePerBundleAttribute(): float
    {
        return $this->value * $this->quantity_per_bundle;
    }

    /**
     * Return "minimum_order_value" attribute value.
     *
     * @return float
     */
    public function getMinimumOrderValueAttribute(): float
    {
        return $this->value_per_bundle * $this->minimum_order_bundle;
    }

    /**
     * Return "maximum_order_value" attribute value.
     *
     * @return float
     */
    public function getMaximumOrderValueAttribute(): float
    {
        return $this->value_per_bundle * $this->maximum_order_bundle;
    }

    /**
     * Return "value_rupiah" attribute value.
     *
     * @return string
     */
    public function getValueRupiahAttribute(): string
    {
        return format_rupiah($this->value);
    }

    /**
     * Return "type_badge" attribute value.
     *
     * @return string
     */
    public function getTypeBadgeAttribute(): string
    {
        return sprintf(<<<'html'
            <span class="badge badge-%s">
                <i class="fa fa-%s"></i> %s
            </span>
        html,
            $this->type->isCoin() ? 'danger' : 'success',

The method isCoin() does not exist on App\Enum\DenominationType. Since you implemented __call, consider adding a @method annotation.

            $this->type->isCoin() ? 'coins' : 'money-bill',
            $this->type->label
        );
    }

    /**
     * Return "can_order_custom_quantity_badge" attribute value.
     *
     * @return string
     */
    public function getCanOrderCustomQuantityBadgeAttribute(): string
    {
        return sprintf(<<<'html'
            <span class="badge badge-%s">
                <i class="fa fa-%s"></i> %s
            </span>
        html,
            $this->can_order_custom_quantity ? 'success' : 'danger',
            $this->can_order_custom_quantity ? 'check-circle' : 'times-circle',
            $this->can_order_custom_quantity ? trans('Yes') : trans('No')

It seems like $this->can_order_custom_quantity ? trans('Yes') : trans('No') can also be of type array and array; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

        );
    }

    /**
     * Return "is_visible_badge" attribute value.
     *
     * @return string
     */
    public function getIsVisibleBadgeAttribute(): string
    {
        return sprintf(<<<'html'
            <span class="badge badge-%s">
                <i class="fa fa-%s"></i> %s
            </span>
        html,
            $this->is_visible ? 'success' : 'danger',
            $this->is_visible ? 'check-circle' : 'times-circle',
            $this->is_visible ? trans('Yes') : trans('No')

It seems like $this->is_visible ? trans('Yes') : trans('No') can also be of type array and array; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

        );
    }
}