App\Http\Requests\Order\AbstractRequest::getItems()

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	AbstractRequest::getUser()	0	3	1

<?php

namespace App\Http\Requests\Order;

use App\Enum\OrderStatus as EnumOrderStatus;
use App\Infrastructure\Foundation\Http\FormRequest;
use App\Models\Branch;
use App\Models\Customer;
use App\Models\Order;
use App\Models\OrderStatus as ModelsOrderStatus;
use App\Models\User;
use Illuminate\Support\Facades\Auth;

abstract class AbstractRequest extends FormRequest
{
    /**
     * {@inheritDoc}
     */
    public static function getAttributes()
    {
        return [
            'customer_id' => trans('admin-lang.customer'),
            'user_id' => trans('admin-lang.user'),
            'branch_id' => trans('admin-lang.branch'),
            'code' => trans('Code'),
            'schedule_date' => trans('Schedule Date'),
            'order_status.status' => trans('Order Status'),
            'order_status.note' => trans('Note'),
        ];
    }

    /**
     * Return new order model instance based on the validated data from request.
     *
     * @return \App\Models\Order
     */
    public function getOrder(): Order
    {
        return Order::make($this->only('schedule_date'));

The expression return App\Models\Order::make($this->only('schedule_date')) could return the type Illuminate\Database\Eloquent\Model which includes types incompatible with the type-hinted return App\Models\Order. Consider adding an additional type-check to rule them out.

    }

    /**
     * Return new order status model instance based on the validated data from request.
     *
     * @return \App\Models\OrderStatus
     */
    public function getOrderStatus(): ModelsOrderStatus
    {
        return ModelsOrderStatus::make([

The expression return App\Models\OrderStatus::make(array('status' => data_get($this->validated(), 'order_status.status', App\Enum\OrderStatus::on_progress()), 'note' => data_get($this->validated(), 'order_status.note')))->setIssuerableRelationValue(Illuminate\Support\Facades\Auth::user()) could return the type Illuminate\Database\Eloquent\Builder which is incompatible with the type-hinted return App\Models\OrderStatus. Consider adding an additional type-check to rule them out.

            'status' => data_get($this->validated(), 'order_status.status', EnumOrderStatus::on_progress()),
            'note' => data_get($this->validated(), 'order_status.note'),
        ])->setIssuerableRelationValue(Auth::user());
    }

    /**
     * Return customer model based on the request.
     *
     * @param  string  $key
     * @return \App\Models\Customer
     */
    public function getCustomer(string $key = 'customer_id'): Customer
    {
        return Customer::find($this->input($key));
    }

    /**
     * Return user model based on the request.
     *
     * @param  string  $key
     * @return \App\Models\User|null
     */
    public function getUser(string $key = 'user_id'): ?User
    {
        return User::find($this->input($key));
    }

    /**
     * Return branch model based on the request.
     *
     * @param  string  $key
     * @return \App\Models\Branch|null
     */
    public function getBranch(string $key = 'branch_id'): ?Branch
    {
        return Branch::find($this->input($key));
    }
}