OrderStatusCreated::__construct() - Code Metrics - Inspection of "+ Composer update" - ianriizky/bcadenpasar-chatbot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 6dcea6...5ae9a6 )

by Septianata

created 2021-08-21 14:41 UTC

OrderStatusCreated::__construct() A

↳ Parent: OrderStatusCreated

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	0

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	0
c	1
b	0
f	0
dl	0
loc	2
ccs	0
cts	1
cp	0
rs	10
cc	1
nc	1
nop	1
crap	2

<?php

namespace App\Events;

use App\Contracts\Event\CanSendTelegramNotification;
use App\Models\Order;
use App\Models\User;
use Illuminate\Broadcasting\InteractsWithSockets;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Events\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;

class OrderStatusCreated implements CanSendTelegramNotification, ShouldQueue
{
    use Dispatchable, InteractsWithSockets, SerializesModels, InteractsWithQueue;


    /**
     * Create a new event instance.
     *
     * @param  \App\Models\Order  $order
     * @return void
     */
    public function __construct(protected Order $order)
    {
        //
    }

    /**
     * {@inheritDoc}
     */
    public function getTelegramChatId(): array
    {
        return User::getAdmin(['id', 'telegram_chat_id'])
            ->pluck('telegram_chat_id')
            ->push($this->order->customer->telegram_chat_id)
            ->toArray();
    }

    /**
     * {@inheritDoc}
     */
    public function getTelegramMessage(): string
    {
        return view('notifications.order-status-created', [

            'order' => $this->order,
        ])->render();
    }
}


1			<?php
2
3			namespace App\Events;
4
5			use App\Contracts\Event\CanSendTelegramNotification;
6			use App\Models\Order;
7			use App\Models\User;
8			use Illuminate\Broadcasting\InteractsWithSockets;
9			use Illuminate\Contracts\Queue\ShouldQueue;
10			use Illuminate\Foundation\Events\Dispatchable;
11			use Illuminate\Queue\InteractsWithQueue;
12			use Illuminate\Queue\SerializesModels;
13
14			class OrderStatusCreated implements CanSendTelegramNotification, ShouldQueue
15			{
16			use Dispatchable, InteractsWithSockets, SerializesModels, InteractsWithQueue;
			0 ignored issues – show introduced 2021-08-21 14:57 UTC by Report Bug Copy Issue Report The trait `Illuminate\Queue\SerializesModels` requires some properties which are not provided by `App\Events\OrderStatusCreated`: `$id`, `$relations`, `$class`, `$connection`, `$keyBy` Loading history...
17
18			/**
19			* Create a new event instance.
20			*
21			* @param \App\Models\Order $order
22			* @return void
23			*/
24			public function __construct(protected Order $order)
25			{
26			//
27			}
28
29			/**
30			* {@inheritDoc}
31			*/
32			public function getTelegramChatId(): array
33			{
34			return User::getAdmin(['id', 'telegram_chat_id'])
35			->pluck('telegram_chat_id')
36			->push($this->order->customer->telegram_chat_id)
37			->toArray();
38			}
39
40			/**
41			* {@inheritDoc}
42			*/
43			public function getTelegramMessage(): string
44			{
45			return view('notifications.order-status-created', [
			0 ignored issues – show Bug Best Practice introduced 2021-08-21 14:57 UTC by Report Bug Copy Issue Report The expression `return view('notificatio...this->order))->render()` could return the type `array` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
46			'order' => $this->order,
47			])->render();
48			}
49			}
50

ianriizky / bcadenpasar-chatbot

Push — develop ( 6dcea6...5ae9a6 )

OrderStatusCreated::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like