App\Models\Concerns\User\Relation

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Test Coverage

Coverage

55.56%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	branch()	0	3	1
A	setBranchRelationValue()	0	5	1
A	getBranchRelationValue()	0	3	1
A	getIssuersRelationValue()	0	3	1

<?php

namespace App\Models\Concerns\User;

use App\Models\Branch;
use App\Models\Support\Relation\MorphManyIssueCustomers;
use App\Models\Support\Relation\MorphManyIssueOrderStatus;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Spatie\Permission\Traits\HasRoles;

/**
 * @property-read \Illuminate\Database\Eloquent\Collection<\App\Models\Role> $roles
 * @property int $branch_id Foreign key of \App\Models\Branch.
 * @property-read \App\Models\Branch $branch
 *
 * @see \App\Models\User
 */
trait Relation
{
    use HasRoles,
        MorphManyIssueOrderStatus,
        MorphManyIssueCustomers;

    /**
     * Define an inverse one-to-one or many relationship with \App\Models\Branch.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function branch(): BelongsTo
    {
        return $this->belongsTo(Branch::class);

It seems like belongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Return \App\Models\Branch model relation value.
     *
     * @return \App\Models\Branch
     */
    public function getBranchRelationValue(): Branch
    {
        return $this->getRelationValue('branch');

It seems like getRelationValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Set \App\Models\Branch model relation value.
     *
     * @param  \App\Models\Branch  $branch
     * @return $this
     */
    public function setBranchRelationValue(Branch $branch)
    {
        $this->branch()->associate($branch);

        return $this;
    }

    /**
     * Return collection of \App\Models\Order model relation value.
     *
     * @return \Illuminate\Database\Eloquent\Collection<\App\Models\Contracts\Issuerable>
     */
    public function getIssuersRelationValue(): Collection
    {
        return $this->issuerOrderStatuses->merge($this->issuerCustomers);
    }
}