App\Models\Concerns\User\Attribute

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

57.14%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getRoleAttribute()	0	5	1
A	getIsActiveBadgeAttribute()	0	11	2
A	setPasswordAttribute()	0	5	1

<?php

namespace App\Models\Concerns\User;

use Illuminate\Support\Facades\Hash;

/**
 * @property string|null $telegram_chat_id
 * @property string $username
 * @property string $fullname
 * @property string $email
 * @property string $phone_country
 * @property \Propaganistas\LaravelPhone\PhoneNumber $phone
 * @property \Illuminate\Support\Carbon $email_verified_at
 * @property string $password
 * @property string $remember_token
 * @property boolean $is_active
 * @property string $is_active_badge
 * @property-read string $role
 *
 * @see \App\Models\User
 */
trait Attribute
{
    /**
     * Set "password" attribute value.
     *
     * @param  mixed  $value
     * @return void
     */
    public function setPasswordAttribute($value)
    {
        $this->attributes['password'] = Hash::make($value);

The property attributes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;

The expression return $this returns the type App\Models\Concerns\User\Attribute which is incompatible with the documented return type void.

    }

    /**
     * Return "is_active_badge" attribute value.
     *
     * @return string
     */
    public function getIsActiveBadgeAttribute(): string
    {
        if ($this->is_active) {
            return sprintf(<<<'html'
            <div class="badge badge-success">%s</div>
            html, trans('Active'));

It seems like trans('Active') can also be of type array and array; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

        }

        return sprintf(<<<'html'
        <div class="badge badge-danger">%s</div>
        html, trans('Not Active'));
    }

    /**
     * Return "role" attribute value.
     *
     * @return string
     */
    public function getRoleAttribute(): string
    {
        $this->load('roles:id,name');

It seems like load() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this->roles->first()->name;

The property roles does not exist on App\Models\Concerns\User\Attribute. Did you mean role?

    }
}