Consumer::connect() - Code Metrics - iPublikuj/websockets-zmq - Measure and Improve Code Quality continuously with Scrutinizer

Consumer::connect() A
last analyzed 2020-02-14 17:10 UTC

↳ Parent: Consumer

Complexity

Conditions	3
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	52
ccs	0
cts	29
cp	0
rs	9.0472
c	0
b	0
f	0
cc	3
nc	1
nop	2
crap	12

How to fix Long Method

<?php
/**
 * Consumer.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec http://www.ipublikuj.eu
 * @package        iPublikuj:WebSocketsZMQ!
 * @subpackage     Consumer
 * @since          1.0.0
 *
 * @date           28.02.17
 */

declare(strict_types = 1);

namespace IPub\WebSocketsZMQ\Consumer;

use Closure;
use ZMQ;
use ZMQSocketException;
use Throwable;

use Psr\Log;

use React;
use React\EventLoop;
use React\ZMQ as ReactZMQ;

use IPub;
use IPub\WebSocketsZMQ;

use IPub\WebSocketsWAMP\Application;
use IPub\WebSocketsWAMP\Entities;
use IPub\WebSocketsWAMP\PushMessages;
use IPub\WebSocketsWAMP\Serializers;

use IPub\WebSockets\Exceptions as WebSocketsExceptions;

/**
 * ZeroMQ consumer
 *
 * @package        iPublikuj:WebSocketsZMQ!
 * @subpackage     Consumer
 *
 * @author         Adam Kadlec <[email protected]>
 *
 * @method onSuccess(Consumer $consumer, $data = NULL)
 * @method onFail(Consumer $consumer, $data = NULL)
 */
final class Consumer extends PushMessages\Consumer
{
	/**
	 * @var Closure
	 */
	public $onSuccess = [];

	/**
	 * @var Closure
	 */
	public $onFail = [];

	/**
	 * @var WebSocketsZMQ\Configuration
	 */
	private $configuration;

	/**
	 * @var  Serializers\PushMessageSerializer
	 */
	private $serializer;

	/**
	 * @var ReactZMQ\SocketWrapper
	 */
	private $socket;

	/**
	 * @var  Log\LoggerInterface
	 */
	private $logger;

	/**
	 * @param WebSocketsZMQ\Configuration $configuration
	 * @param Serializers\PushMessageSerializer $serializer
	 * @param Log\LoggerInterface|NULL $logger
	 */
	public function __construct(

		WebSocketsZMQ\Configuration $configuration,
		Serializers\PushMessageSerializer $serializer,
		Log\LoggerInterface $logger = NULL
	) {
		parent::__construct('zmq');

		$this->configuration = $configuration;
		$this->serializer = $serializer;
		$this->logger = $logger === NULL ? new Log\NullLogger : $logger;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
	}

	/**
	 * {@inheritdoc}
	 *
	 * @throws ZMQSocketException
	 */
	public function connect(EventLoop\LoopInterface $loop, Application\IApplication $application)
	{
		$context = new ReactZMQ\Context($loop);

		$this->socket = $context->getSocket(ZMQ::SOCKET_PULL);

		$this->logger->info(sprintf(
			'ZMQ transport listening on %s:%s',
			$this->configuration->getHost(),
			$this->configuration->getPort()
		));

		$this->socket->bind($this->configuration->getProtocol() . '://' . $this->configuration->getHost() . ':' . $this->configuration->getPort());

		$this->socket->on('message', function ($data) use ($application) {
			try {
				/** @var Entities\PushMessages\IMessage $message */
				$message = $this->serializer->deserialize($data);

				$application->handlePush($message, $this->getName());


				$this->onSuccess($this, $data);

			} catch (WebSocketsExceptions\TerminateException $ex) {

				throw $ex;

			} catch (Throwable $ex) {
				$this->logger->error(
					'ZMQ socket failed to ack message', [
						'exception_message' => $ex->getMessage(),
						'file'              => $ex->getFile(),
						'line'              => $ex->getLine(),
						'message'           => $data,
					]
				);

				$this->onFail($this, $data);
			}
		});

		$this->socket->on('error', function (Throwable $ex) use ($application) {
			$this->logger->error(
				'ZMQ socket failed to receive message', [
					'exception_message' => $ex->getMessage(),
					'file'              => $ex->getFile(),
					'line'              => $ex->getLine(),
				]
			);

			$this->onFail($this);
		});
	}

	/**
	 * {@inheritdoc}
	 */
	public function close() : void
	{
		$this->socket ?: $this->socket->close();
	}
}


1			<?php
2			/**
3			* Consumer.php
4			*
5			* @copyright More in license.md
6			* @license http://www.ipublikuj.eu
7			* @author Adam Kadlec http://www.ipublikuj.eu
8			* @package iPublikuj:WebSocketsZMQ!
9			* @subpackage Consumer
10			* @since 1.0.0
11			*
12			* @date 28.02.17
13			*/
14
15			declare(strict_types = 1);
16
17			namespace IPub\WebSocketsZMQ\Consumer;
18
19			use Closure;
20			use ZMQ;
21			use ZMQSocketException;
22			use Throwable;
23
24			use Psr\Log;
25
26			use React;
27			use React\EventLoop;
28			use React\ZMQ as ReactZMQ;
29
30			use IPub;
31			use IPub\WebSocketsZMQ;
32
33			use IPub\WebSocketsWAMP\Application;
34			use IPub\WebSocketsWAMP\Entities;
35			use IPub\WebSocketsWAMP\PushMessages;
36			use IPub\WebSocketsWAMP\Serializers;
37
38			use IPub\WebSockets\Exceptions as WebSocketsExceptions;
39
40			/**
41			* ZeroMQ consumer
42			*
43			* @package iPublikuj:WebSocketsZMQ!
44			* @subpackage Consumer
45			*
46			* @author Adam Kadlec <[email protected]>
47			*
48	1		* @method onSuccess(Consumer $consumer, $data = NULL)
49			* @method onFail(Consumer $consumer, $data = NULL)
50			*/
51			final class Consumer extends PushMessages\Consumer
52			{
53			/**
54			* @var Closure
55			*/
56			public $onSuccess = [];
57
58			/**
59			* @var Closure
60			*/
61			public $onFail = [];
62
63			/**
64			* @var WebSocketsZMQ\Configuration
65			*/
66			private $configuration;
67
68			/**
69			* @var Serializers\PushMessageSerializer
70			*/
71			private $serializer;
72
73			/**
74			* @var ReactZMQ\SocketWrapper
75			*/
76			private $socket;
77
78			/**
79			* @var Log\LoggerInterface
80			*/
81			private $logger;
82
83			/**
84			* @param WebSocketsZMQ\Configuration $configuration
85			* @param Serializers\PushMessageSerializer $serializer
86			* @param Log\LoggerInterface\|NULL $logger
87			*/
88		View Code Duplication	public function __construct(
			0 ignored issues – show Duplication introduced 2018-06-28 10:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
89			WebSocketsZMQ\Configuration $configuration,
90	1		Serializers\PushMessageSerializer $serializer,
91			Log\LoggerInterface $logger = NULL
92	1		) {
93	1		parent::__construct('zmq');
94	1
95	1		$this->configuration = $configuration;
96			$this->serializer = $serializer;
97			$this->logger = $logger === NULL ? new Log\NullLogger : $logger;
			0 ignored issues – show Documentation Bug introduced 2017-03-06 22:51 UTC by Report Bug Copy Issue Report It seems like `$logger === NULL ? new \...\NullLogger() : $logger` can also be of type `object<Psr\Log\NullLogger>`. However, the property `$logger` is declared as type `object<Psr\Log\LoggerInterface>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
98			}
99
100			/**
101			* {@inheritdoc}
102			*
103			* @throws ZMQSocketException
104			*/
105			public function connect(EventLoop\LoopInterface $loop, Application\IApplication $application)
106			{
107			$context = new ReactZMQ\Context($loop);
108
109			$this->socket = $context->getSocket(ZMQ::SOCKET_PULL);
110
111			$this->logger->info(sprintf(
112			'ZMQ transport listening on %s:%s',
113			$this->configuration->getHost(),
114			$this->configuration->getPort()
115			));
116
117			$this->socket->bind($this->configuration->getProtocol() . '://' . $this->configuration->getHost() . ':' . $this->configuration->getPort());
118
119			$this->socket->on('message', function ($data) use ($application) {
120			try {
121			/** @var Entities\PushMessages\IMessage $message */
122			$message = $this->serializer->deserialize($data);
123
124			$application->handlePush($message, $this->getName());
			0 ignored issues – show Bug introduced 2017-03-06 22:51 UTC by Report Bug Copy Issue Report Consider using `$this->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
125
126			$this->onSuccess($this, $data);
127
128			} catch (WebSocketsExceptions\TerminateException $ex) {
			0 ignored issues – show Bug introduced 2019-11-15 22:17 UTC by Report Bug Copy Issue Report The class `IPub\WebSockets\Exceptions\TerminateException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
129			throw $ex;
130
131			} catch (Throwable $ex) {
132			$this->logger->error(
133			'ZMQ socket failed to ack message', [
134			'exception_message' => $ex->getMessage(),
135			'file' => $ex->getFile(),
136			'line' => $ex->getLine(),
137			'message' => $data,
138			]
139			);
140
141			$this->onFail($this, $data);
142			}
143			});
144
145			$this->socket->on('error', function (Throwable $ex) use ($application) {
146			$this->logger->error(
147			'ZMQ socket failed to receive message', [
148			'exception_message' => $ex->getMessage(),
149			'file' => $ex->getFile(),
150			'line' => $ex->getLine(),
151			]
152			);
153
154			$this->onFail($this);
155			});
156			}
157
158			/**
159			* {@inheritdoc}
160			*/
161	1		public function close() : void
162			{
163			$this->socket ?: $this->socket->close();
164			}
165			}
166

iPublikuj / websockets-zmq

Consumer::connect() A last analyzed 2020-02-14 17:10 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Consumer::connect() A
last analyzed 2020-02-14 17:10 UTC