IPub\WebSocketsZMQ\Pusher\Pusher

Complexity

Total Complexity

7

Size/Duplication

Total Lines	76
Duplicated Lines	14.47 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

23.81%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	2
A	close()	0	8	2
A	doPush()	0	21	3

<?php
/**
 * Pusher.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec http://www.ipublikuj.eu
 * @package        iPublikuj:WebSocketsZMQ!
 * @subpackage     Pusher
 * @since          1.0.0
 *
 * @date           01.03.17
 */

declare(strict_types = 1);

namespace IPub\WebSocketsZMQ\Pusher;

use ZMQ;
use ZMQContext;
use ZMQSocket;
use ZMQSocketException;
use RuntimeException;

use Psr\Log;

use IPub;
use IPub\WebSocketsZMQ;

use IPub\WebSockets\Router;

use IPub\WebSocketsWAMP\PushMessages;
use IPub\WebSocketsWAMP\Serializers;

/**
 * ZeroMQ message pusher
 *
 * @package        iPublikuj:WebSocketsZMQ!
 * @subpackage     Pushers
 *
 * @author         Adam Kadlec <adam.kadlec@ipublikuj.eu>
 */
final class Pusher extends PushMessages\Pusher
{
	/**
	 * @var WebSocketsZMQ\Configuration
	 */
	private $configuration;

	/**
	 * @var Log\LoggerInterface
	 */
	private $logger;

	/**
	 * @var ZMQSocket
	 */
	private $socket;

	/**
	 * @param WebSocketsZMQ\Configuration $configuration
	 * @param Router\LinkGenerator $linkGenerator
	 * @param Serializers\PushMessageSerializer $serializer
	 * @param Log\LoggerInterface|NULL $logger
	 */
	public function __construct(

This method seems to be duplicated in your project.

		WebSocketsZMQ\Configuration $configuration,
		Router\LinkGenerator $linkGenerator,
		Serializers\PushMessageSerializer $serializer,
		Log\LoggerInterface $logger = NULL
	) {
		parent::__construct('zmq', $serializer, $linkGenerator);

		$this->configuration = $configuration;
		$this->logger = $logger === NULL ? new Log\NullLogger : $logger;

It seems like $logger === NULL ? new \Psr\Log\NullLogger() : $logger can also be of type object<Psr\Log\NullLogger>. However, the property $logger is declared as type object<Psr\Log\LoggerInterface>. Maybe add an additional type check?

	}

	/**
	 * {@inheritdoc}
	 *
	 * @throws ZMQSocketException
	 */
	public function close() : void
	{
		if ($this->isConnected() === FALSE) {
			return;
		}

		$this->socket->disconnect($this->configuration->getHost() . ':' . $this->configuration->getPort());
	}

	/**
	 * {@inheritdoc}
	 *
	 * @throws ZMQSocketException
	 */
	protected function doPush(string $data, array $context = []) : void
	{
		if ($this->isConnected() === FALSE) {
			if (!extension_loaded('zmq')) {
				throw new RuntimeException(sprintf(
					'%s pusher require %s php extension',
					get_class($this),
					$this->getName()

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

				));
			}

			$context = new ZMQContext(1, $this->configuration->isPersistent());

			$this->socket = new ZMQSocket($context, ZMQ::SOCKET_PUSH);
			$this->socket->connect($this->configuration->getProtocol() . '://' . $this->configuration->getHost() . ':' . $this->configuration->getPort());

			$this->setConnected();
		}

		$this->socket->send($data);
	}
}