TPermission - Code Metrics - Inspection of "- Just testing" - iPublikuj/permissions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89d085...1932ea )

by Adam

created 2016-12-01 22:22 UTC

TPermission A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	1
dl	0
loc	56
ccs	13
cts	13
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	injectPermission()	0	7	1
B	checkRequirements()	0	26	3

<?php
/**
 * TPermission.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec http://www.ipublikuj.eu
 * @package        iPublikuj:Permissions!
 * @subpackage     common
 * @since          1.0.0
 *
 * @date           13.10.14
 */

namespace IPub\Permissions;

use Nette;
use Nette\Application;

use IPub;
use IPub\Permissions\Security;

/**
 * Helper trait
 *
 * @package        iPublikuj:Permissions!
 * @subpackage     common
 *
 * @author         Adam Kadlec <[email protected]>
 */
trait TPermission
{
	/**
	 * @var Configuration
	 */
	protected $permissionConfiguration;

	/**
	 * @var Access\ICheckRequirements
	 */
	protected $requirementsChecker;

	/**
	 * @param Access\ICheckRequirements $requirementsChecker
	 * @param Configuration $configuration
	 */
	public function injectPermission(
		Access\ICheckRequirements $requirementsChecker,
		Configuration $configuration
	) {
		$this->requirementsChecker = $requirementsChecker;
		$this->permissionConfiguration = $configuration;
	}

	/**
	 * @param $element
	 *
	 * @throws Application\ForbiddenRequestException
	 */
	public function checkRequirements($element)
	{
		$redirectUrl = $this->permissionConfiguration->getRedirectUrl([
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			'backlink' => $this->storeRequest(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
		]);

		try {
			parent::checkRequirements($element);

			if (!$this->requirementsChecker->isAllowed($element)) {
				throw new Application\ForbiddenRequestException;
			}

		} catch (Application\ForbiddenRequestException $ex) {
			/*

			if ($redirectUrl) {
				$this->getPresenter()->redirectUrl($redirectUrl);

			} else {
			*/
				throw $ex;
			/*
			}
			*/
		}
	}
}


1		<?php
2		/**
3		* TPermission.php
4		*
5		* @copyright More in license.md
6		* @license http://www.ipublikuj.eu
7		* @author Adam Kadlec http://www.ipublikuj.eu
8		* @package iPublikuj:Permissions!
9		* @subpackage common
10		* @since 1.0.0
11		*
12		* @date 13.10.14
13		*/
14
15		namespace IPub\Permissions;
16
17		use Nette;
18		use Nette\Application;
19
20		use IPub;
21		use IPub\Permissions\Security;
22
23		/**
24		* Helper trait
25		*
26		* @package iPublikuj:Permissions!
27		* @subpackage common
28		*
29		* @author Adam Kadlec <[email protected]>
30		*/
31	1	trait TPermission
32		{
33		/**
34		* @var Configuration
35		*/
36		protected $permissionConfiguration;
37
38		/**
39		* @var Access\ICheckRequirements
40		*/
41		protected $requirementsChecker;
42
43		/**
44		* @param Access\ICheckRequirements $requirementsChecker
45		* @param Configuration $configuration
46		*/
47		public function injectPermission(
48		Access\ICheckRequirements $requirementsChecker,
49		Configuration $configuration
50		) {
51	1	$this->requirementsChecker = $requirementsChecker;
52	1	$this->permissionConfiguration = $configuration;
53	1	}
54
55		/**
56		* @param $element
57		*
58		* @throws Application\ForbiddenRequestException
59		*/
60		public function checkRequirements($element)
61		{
62	1	$redirectUrl = $this->permissionConfiguration->getRedirectUrl([
		0 ignored issues – show Unused Code introduced 2016-12-01 22:24 UTC by Report Bug Copy Issue Report `$redirectUrl` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
63	1	'backlink' => $this->storeRequest(),
		0 ignored issues – show Bug introduced 2016-11-30 22:57 UTC by Report Bug Copy Issue Report It seems like `storeRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64		]);
65
66		try {
67	1	parent::checkRequirements($element);
68
69	1	if (!$this->requirementsChecker->isAllowed($element)) {
70	1	throw new Application\ForbiddenRequestException;
71		}
72
73	1	} catch (Application\ForbiddenRequestException $ex) {
74		/*
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-01 22:24 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
75		if ($redirectUrl) {
76		$this->getPresenter()->redirectUrl($redirectUrl);
77
78		} else {
79		*/
80	1	throw $ex;
81		/*
82		}
83		*/
84		}
85	1	}
86		}
87

iPublikuj / permissions

Push — master ( 89d085...1932ea )

TPermission A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like