DisableCommand::execute() - Code Metrics - Inspection of "- Fixed php version definition" - iPublikuj/packages - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 60e59a...334051 )

by Adam

created 2016-07-19 22:02 UTC

DisableCommand::execute() C

↳ Parent: DisableCommand

Complexity

Conditions	12
Paths	132

Size

Total Lines	53
Code Lines	29

Duplication

Lines	53
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	53
loc	53
rs	5.7718
cc	12
eloc	29
nc	132
nop	2

How to fix Long Method Complexity

<?php
/**
 * DisableCommand.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec http://www.ipublikuj.eu
 * @package        iPublikuj:Packages!
 * @subpackage     Commands
 * @since          2.0.0
 *
 * @date           19.07.16
 */

declare(strict_types = 1);

namespace IPub\Packages\Commands;

use Symfony\Component\Console\Input;
use Symfony\Component\Console\Output;

use IPub;
use IPub\Packages;
use IPub\Packages\DependencyResolver;
use IPub\Packages\Exceptions;

/**
 * Disable package command
 *
 * @package        iPublikuj:Packages!
 * @subpackage     Commands
 *
 * @author         Josef Kříž <[email protected]>
 * @author         Adam Kadlec <[email protected]>
 */
class DisableCommand extends Command

{
	/**
	 * @return void
	 */
	protected function configure()
	{
		$this
			->setName('ipub:packages:disable')
			->addArgument('package', Input\InputArgument::REQUIRED, 'Package name')
			->addOption('noconfirm', NULL, Input\InputOption::VALUE_NONE, 'do not ask for any confirmation')
			->setDescription('Disable package.');
	}

	/**
	 * @param Input\InputInterface $input
	 * @param Output\OutputInterface $output
	 *
	 * @return void
	 */
	protected function execute(Input\InputInterface $input, Output\OutputInterface $output)
	{
		// Register available
		foreach ($this->packageManager->registerAvailable() as $item) {
			foreach ($item as $name => $action) {

				$output->writeln(sprintf('<info>%s : %s</info>', $action, $name));
			}
		}

		$package = $this->repository->findPackage($input->getArgument('package'));

		try {
			$problem = $this->packageManager->testDisable($package);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		} catch (Exceptions\InvalidArgumentException $e) {
			$output->writeln(sprintf('<error>%s</error>', $e->getMessage()));

			return;
		}

		if (!$input->getOption('noconfirm') && count($problem->getSolutions()) > 0) {
			foreach ($problem->getSolutions() as $job) {
				$output->writeln(sprintf('<info>%s : %s</info>', $job->getAction(), $job->getPackage()->getName()));
			}

			$output->writeln(sprintf('<info>disabling : %s</info>', $package->getName()));

			$dialog = $this->getHelperSet()->get('dialog');
			if (!$dialog->askConfirmation($output, '<question>Continue with this actions? [y/N]</question> ', FALSE)) {
				return;
			}
		}

		try {
			foreach ($problem->getSolutions() as $job) {
				if ($job->getAction() === DependencyResolver\Job::ACTION_ENABLE) {
					$this->packageManager->disable($job->getPackage());
					$output->writeln(sprintf('Package \'%s\' has been enabled.', $job->getPackage()->getName()));

				} elseif ($job->getAction() === DependencyResolver\Job::ACTION_DISABLE) {
					$this->packageManager->enable($job->getPackage());
					$output->writeln(sprintf('Package \'%s\' has been disabled.', $job->getPackage()->getName()));

				}
			}

			$this->packageManager->disable($package);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			$output->writeln(sprintf('Package \'%s\' has been disabled.', $input->getArgument('package')));

		} catch (Exceptions\InvalidArgumentException $e) {
			$output->writeln(sprintf('<error>%s</error>', $e->getMessage()));
		}
	}
}


1		<?php
2		/**
3		* DisableCommand.php
4		*
5		* @copyright More in license.md
6		* @license http://www.ipublikuj.eu
7		* @author Adam Kadlec http://www.ipublikuj.eu
8		* @package iPublikuj:Packages!
9		* @subpackage Commands
10		* @since 2.0.0
11		*
12		* @date 19.07.16
13		*/
14
15		declare(strict_types = 1);
16
17		namespace IPub\Packages\Commands;
18
19		use Symfony\Component\Console\Input;
20		use Symfony\Component\Console\Output;
21
22		use IPub;
23		use IPub\Packages;
24		use IPub\Packages\DependencyResolver;
25		use IPub\Packages\Exceptions;
26
27		/**
28		* Disable package command
29		*
30		* @package iPublikuj:Packages!
31		* @subpackage Commands
32		*
33		* @author Josef Kříž <[email protected]>
34		* @author Adam Kadlec <[email protected]>
35		*/
36	View Code Duplication	class DisableCommand extends Command
		0 ignored issues – show Duplication introduced 2016-07-19 22:08 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		/**
39		* @return void
40		*/
41		protected function configure()
42		{
43		$this
44		->setName('ipub:packages:disable')
45		->addArgument('package', Input\InputArgument::REQUIRED, 'Package name')
46		->addOption('noconfirm', NULL, Input\InputOption::VALUE_NONE, 'do not ask for any confirmation')
47		->setDescription('Disable package.');
48		}
49
50		/**
51		* @param Input\InputInterface $input
52		* @param Output\OutputInterface $output
53		*
54		* @return void
55		*/
56		protected function execute(Input\InputInterface $input, Output\OutputInterface $output)
57		{
58		// Register available
59		foreach ($this->packageManager->registerAvailable() as $item) {
60		foreach ($item as $name => $action) {
		0 ignored issues – show Bug introduced 2016-07-19 22:08 UTC by Report Bug Copy Issue Report The expression `$item` of type `string` is not traversable. Loading history...
61		$output->writeln(sprintf('<info>%s : %s</info>', $action, $name));
62		}
63		}
64
65		$package = $this->repository->findPackage($input->getArgument('package'));
66
67		try {
68		$problem = $this->packageManager->testDisable($package);
		0 ignored issues – show Bug introduced 2016-07-19 22:08 UTC by Report Bug Copy Issue Report It seems like `$package` defined by `$this->repository->findP...getArgument('package'))` on line `65` can also be of type `boolean`; however, `IPub\Packages\IPackagesManager::testDisable()` does only seem to accept `object<IPub\Packages\Entities\IPackage>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
69
70		} catch (Exceptions\InvalidArgumentException $e) {
71		$output->writeln(sprintf('<error>%s</error>', $e->getMessage()));
72
73		return;
74		}
75
76		if (!$input->getOption('noconfirm') && count($problem->getSolutions()) > 0) {
77		foreach ($problem->getSolutions() as $job) {
78		$output->writeln(sprintf('<info>%s : %s</info>', $job->getAction(), $job->getPackage()->getName()));
79		}
80
81		$output->writeln(sprintf('<info>disabling : %s</info>', $package->getName()));
82
83		$dialog = $this->getHelperSet()->get('dialog');
84		if (!$dialog->askConfirmation($output, '<question>Continue with this actions? [y/N]</question> ', FALSE)) {
85		return;
86		}
87		}
88
89		try {
90		foreach ($problem->getSolutions() as $job) {
91		if ($job->getAction() === DependencyResolver\Job::ACTION_ENABLE) {
92		$this->packageManager->disable($job->getPackage());
93		$output->writeln(sprintf('Package \'%s\' has been enabled.', $job->getPackage()->getName()));
94
95		} elseif ($job->getAction() === DependencyResolver\Job::ACTION_DISABLE) {
96		$this->packageManager->enable($job->getPackage());
97		$output->writeln(sprintf('Package \'%s\' has been disabled.', $job->getPackage()->getName()));
98
99		}
100		}
101
102		$this->packageManager->disable($package);
		0 ignored issues – show Bug introduced 2016-07-19 22:08 UTC by Report Bug Copy Issue Report It seems like `$package` defined by `$this->repository->findP...getArgument('package'))` on line `65` can also be of type `boolean`; however, `IPub\Packages\IPackagesManager::disable()` does only seem to accept `object<IPub\Packages\Entities\IPackage>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
103		$output->writeln(sprintf('Package \'%s\' has been disabled.', $input->getArgument('package')));
104
105		} catch (Exceptions\InvalidArgumentException $e) {
106		$output->writeln(sprintf('<error>%s</error>', $e->getMessage()));
107		}
108		}
109		}
110

iPublikuj / packages

Push — master ( 60e59a...334051 )

DisableCommand::execute() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like