IPub\Packages\Commands\DisableCommand

Complexity

Total Complexity

13

Size/Duplication

Total Lines	74
Duplicated Lines	32.43 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

3.03%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	8	8	1
C	execute()	16	53	12

<?php
/**
 * DisableCommand.php
 *
 * @copyright      More in license.md
 * @license        https://www.ipublikuj.eu
 * @author         Adam Kadlec <adam.kadlec@ipublikuj.eu>
 * @package        iPublikuj:Packages!
 * @subpackage     Commands
 * @since          2.0.0
 *
 * @date           19.07.16
 */

declare(strict_types = 1);

namespace IPub\Packages\Commands;

use Symfony\Component\Console\Input;
use Symfony\Component\Console\Output;

use IPub\Packages\DependencyResolver;
use IPub\Packages\Exceptions;

/**
 * Disable package command
 *
 * @package        iPublikuj:Packages!
 * @subpackage     Commands
 *
 * @author         Josef Kříž <pepakriz@gmail.com>
 * @author         Adam Kadlec <adam.kadlec@ipublikuj.eu>
 */
class DisableCommand extends Command
{
	/**
	 * @return void
	 */
	protected function configure() : void

This method seems to be duplicated in your project.

	{
		$this
			->setName('ipub:packages:disable')
			->addArgument('package', Input\InputArgument::REQUIRED, 'Package name')
			->addOption('noconfirm', NULL, Input\InputOption::VALUE_NONE, 'do not ask for any confirmation')
			->setDescription('Disable package.');
	}

	/**
	 * @param Input\InputInterface $input
	 * @param Output\OutputInterface $output
	 *
	 * @return void
	 */
	protected function execute(Input\InputInterface $input, Output\OutputInterface $output) : void
	{
		// Register available
		foreach ($this->packageManager->registerAvailable() as $item) {

This code seems to be duplicated across your project.

			foreach ($item as $name => $action) {
				$output->writeln(sprintf('<info>%s : %s</info>', $action, $name));
			}
		}

		$package = $this->repository->findPackage($input->getArgument('package'));

		try {
			$problem = $this->packageManager->testDisable($package);

It seems like $package defined by $this->repository->findPackage($input->getArgument('package')) on line 63 can also be of type boolean; however, IPub\Packages\IPackagesManager::testDisable() does only seem to accept object<IPub\Packages\Entities\IPackage>, maybe add an additional type check?

		} catch (Exceptions\InvalidArgumentException $e) {
			$output->writeln(sprintf('<error>%s</error>', $e->getMessage()));

			return;
		}

		if (!$input->getOption('noconfirm') && count($problem->getSolutions()) > 0) {
			foreach ($problem->getSolutions() as $job) {
				$output->writeln(sprintf('<info>%s : %s</info>', $job->getAction(), $job->getPackage()->getName()));
			}

			$output->writeln(sprintf('<info>disabling : %s</info>', $package->getName()));

			$dialog = $this->getHelperSet()->get('dialog');
			if (!$dialog->askConfirmation($output, '<question>Continue with this actions? [y/N]</question> ', FALSE)) {
				return;
			}
		}

		try {
			foreach ($problem->getSolutions() as $job) {

This code seems to be duplicated across your project.

				if ($job->getAction() === DependencyResolver\Job::ACTION_ENABLE) {
					$this->packageManager->disable($job->getPackage());
					$output->writeln(sprintf('Package \'%s\' has been enabled.', $job->getPackage()->getName()));

				} elseif ($job->getAction() === DependencyResolver\Job::ACTION_DISABLE) {
					$this->packageManager->enable($job->getPackage());
					$output->writeln(sprintf('Package \'%s\' has been disabled.', $job->getPackage()->getName()));

				}
			}

			$this->packageManager->disable($package);

It seems like $package defined by $this->repository->findPackage($input->getArgument('package')) on line 63 can also be of type boolean; however, IPub\Packages\IPackagesManager::disable() does only seem to accept object<IPub\Packages\Entities\IPackage>, maybe add an additional type check?

			$output->writeln(sprintf('Package \'%s\' has been disabled.', $input->getArgument('package')));

		} catch (Exceptions\InvalidArgumentException $e) {
			$output->writeln(sprintf('<error>%s</error>', $e->getMessage()));
		}
	}
}