ClientCommand::execute() - Code Metrics - iPublikuj/mqtt-client - Measure and Improve Code Quality continuously with Scrutinizer

ClientCommand::execute() A
last analyzed 2020-05-11 18:19 UTC

↳ Parent: ClientCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	0
cts	12
cp	0
rs	9.504
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php
/**
 * ClientCommand.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec http://www.ipublikuj.eu
 * @package        iPublikuj:MQTTClient!
 * @subpackage     Commands
 * @since          1.0.0
 *
 * @date           12.03.17
 */

declare(strict_types = 1);

namespace IPub\MQTTClient\Commands;

use Symfony\Component\Console;
use Symfony\Component\Console\Input;
use Symfony\Component\Console\Style;
use Symfony\Component\Console\Output;

use Psr\Log;

use BinSoul\Net\Mqtt;

use IPub\MQTTClient\Client;
use IPub\MQTTClient\Exceptions;
use IPub\MQTTClient\Logger;

/**
 * MQTT client command
 *
 * @package        iPublikuj:MQTTClient!
 * @subpackage     Commands
 *
 * @author         Adam Kadlec <[email protected]>
 */
class ClientCommand extends Console\Command\Command
{
	/**
	 * @var Client\IClient
	 */
	private $client;

	/**
	 * @var Log\LoggerInterface|Log\NullLogger|NULL
	 */
	private $logger;

	/**
	 * @var bool
	 */
	private $isRunning = FALSE;

	/**
	 * @param Client\IClient $client
	 * @param Log\LoggerInterface|NULL $logger
	 * @param string|NULL $name
	 */
	public function __construct(
		Client\IClient $client,
		Log\LoggerInterface $logger = NULL,
		string $name = NULL
	) {
		parent::__construct($name);

		$this->client = $client;
		$this->logger = $logger === NULL ? new Log\NullLogger : $logger;
	}

	/**
	 * @param Log\LoggerInterface $logger
	 *
	 * @return void
	 *
	 * @throws Exceptions\InvalidStateException
	 */
	public function setLogger(Log\LoggerInterface $logger) : void
	{
		if ($this->isRunning) {
			throw new Exceptions\InvalidStateException('Client is connected, logger could not be set.');
		}

		$this->logger = $logger;
	}

	/**
	 * @return void
	 */
	protected function configure()
	{
		$this
			->setName('ipub:mqttclient:start')
			->setDescription('Start MQTT client.');
	}

	/**
	 * {@inheritdoc}
	 */
	protected function execute(Input\InputInterface $input, Output\OutputInterface $output)
	{
		$io = new Style\SymfonyStyle($input, $output);

		$io->text([
			'',
			'+-------------+',
			'| MQTT client |',
			'+-------------+',
			'',
		]);

		if ($this->logger instanceof Logger\Console) {
			$this->logger->setFormatter(new Logger\Formatter\Symfony($io));
		}

		$this->client->onOpen[] = (function (Mqtt\Connection $connection, Client\Client $client) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			$this->logger->debug(sprintf('Connection to %s opened', $client->getUri()));
		});

		$this->client->connect();

		$this->isRunning = TRUE;

		$this->client->getLoop()->run();
	}
}


1		<?php
2		/**
3		* ClientCommand.php
4		*
5		* @copyright More in license.md
6		* @license http://www.ipublikuj.eu
7		* @author Adam Kadlec http://www.ipublikuj.eu
8		* @package iPublikuj:MQTTClient!
9		* @subpackage Commands
10		* @since 1.0.0
11		*
12		* @date 12.03.17
13		*/
14
15		declare(strict_types = 1);
16
17		namespace IPub\MQTTClient\Commands;
18
19		use Symfony\Component\Console;
20		use Symfony\Component\Console\Input;
21		use Symfony\Component\Console\Style;
22		use Symfony\Component\Console\Output;
23
24		use Psr\Log;
25
26		use BinSoul\Net\Mqtt;
27
28		use IPub\MQTTClient\Client;
29		use IPub\MQTTClient\Exceptions;
30		use IPub\MQTTClient\Logger;
31
32		/**
33		* MQTT client command
34		*
35		* @package iPublikuj:MQTTClient!
36		* @subpackage Commands
37		*
38		* @author Adam Kadlec <[email protected]>
39		*/
40	1	class ClientCommand extends Console\Command\Command
41		{
42		/**
43		* @var Client\IClient
44		*/
45		private $client;
46
47		/**
48		* @var Log\LoggerInterface\|Log\NullLogger\|NULL
49		*/
50		private $logger;
51
52		/**
53		* @var bool
54		*/
55		private $isRunning = FALSE;
56
57		/**
58		* @param Client\IClient $client
59		* @param Log\LoggerInterface\|NULL $logger
60		* @param string\|NULL $name
61		*/
62		public function __construct(
63		Client\IClient $client,
64		Log\LoggerInterface $logger = NULL,
65		string $name = NULL
66		) {
67		parent::__construct($name);
68
69		$this->client = $client;
70		$this->logger = $logger === NULL ? new Log\NullLogger : $logger;
71		}
72
73		/**
74		* @param Log\LoggerInterface $logger
75		*
76		* @return void
77		*
78		* @throws Exceptions\InvalidStateException
79		*/
80		public function setLogger(Log\LoggerInterface $logger) : void
81		{
82		if ($this->isRunning) {
83		throw new Exceptions\InvalidStateException('Client is connected, logger could not be set.');
84		}
85
86		$this->logger = $logger;
87		}
88
89		/**
90		* @return void
91		*/
92		protected function configure()
93		{
94		$this
95		->setName('ipub:mqttclient:start')
96		->setDescription('Start MQTT client.');
97		}
98
99		/**
100		* {@inheritdoc}
101		*/
102		protected function execute(Input\InputInterface $input, Output\OutputInterface $output)
103		{
104		$io = new Style\SymfonyStyle($input, $output);
105
106		$io->text([
107		'',
108		'+-------------+',
109		'\| MQTT client \|',
110		'+-------------+',
111		'',
112		]);
113
114		if ($this->logger instanceof Logger\Console) {
115		$this->logger->setFormatter(new Logger\Formatter\Symfony($io));
116		}
117
118		$this->client->onOpen[] = (function (Mqtt\Connection $connection, Client\Client $client) {
		0 ignored issues – show Bug introduced 2019-05-24 16:57 UTC by Report Bug Copy Issue Report Accessing `onOpen` on the interface `IPub\MQTTClient\Client\IClient` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
119		$this->logger->debug(sprintf('Connection to %s opened', $client->getUri()));
120		});
121
122		$this->client->connect();
123
124		$this->isRunning = TRUE;
125
126		$this->client->getLoop()->run();
127		}
128		}
129

iPublikuj / mqtt-client

ClientCommand::execute() A last analyzed 2020-05-11 18:19 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ClientCommand::execute() A
last analyzed 2020-05-11 18:19 UTC