CookieSettings::getExpiresTime() - Code Metrics - Inspection of "- Upgrading to nette 2.4" - iPublikuj/mobile-detect - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9edc41...f34eb1 )

by Adam

created 2018-01-14 13:48 UTC

CookieSettings::getExpiresTime() A

↳ Parent: CookieSettings

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	1
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php
/**
 * CookieSettings.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec http://www.ipublikuj.eu
 * @package        iPublikuj:MobileDetect!
 * @subpackage     Helpers
 * @since          1.0.0
 *
 * @date           23.04.14
 */

declare(strict_types = 1);

namespace IPub\MobileDetect\Helpers;

use Nette;

use IPub;
use IPub\MobileDetect\Exceptions;

/**
 * Cookies creator helper
 *
 * @package        iPublikuj:MobileDetect!
 * @subpackage     Helpers
 *
 * @author         Adam Kadlec <[email protected]>
 */
final class CookieSettings
{
	/**
	 * Implement nette smart magic
	 */
	use Nette\SmartObject;

	/**
	 * @var string
	 */
	private $name;

	/**
	 * @var string|NULL
	 */
	private $domain;

	/**
	 * @var string
	 */
	private $expire;

	/**
	 * @var string
	 */
	private $path;

	/**
	 * @var bool
	 */
	private $secure;

	/**
	 * @var bool
	 */
	private $httpOnly;

	/**
	 * @param string $name          The name of the cookie
	 * @param string $expireAfter   The time the cookie expires
	 * @param string $path          The path on the server in which the cookie will be available on
	 * @param string $domain        The domain that the cookie is available to
	 * @param bool $secure          Whether the cookie should only be transmitted over a secure HTTPS connection from the client
	 * @param bool $httpOnly        Whether the cookie will be made accessible only through the HTTP protocol
	 *
	 * @throws Exceptions\InvalidArgumentException
	 */
	public function __construct(string $name, string $domain = NULL, string $expireAfter = NULL, string $path = '/',  bool $secure = FALSE, bool $httpOnly = TRUE)
	{
		// from PHP source code
		if (preg_match("/[=,; \t\r\n\013\014]/", $name)) {
			throw new Exceptions\InvalidArgumentException(sprintf('The cookie name "%s" contains invalid characters.', $name));
		}

		if (empty($name)) {
			throw new Exceptions\InvalidArgumentException('The cookie name cannot be empty.');
		}

		$expire = new \DateTime;

		if ($expireAfter !== NULL) {
			$expire->modify($expireAfter);
		}

		$this->name = $name;
		$this->domain = $domain;
		$this->expire = (int) $expire->format('U');
$answer = 42;

$correct = false;

$correct = (bool) $answer;
		$this->path = empty($path) ? '/' : $path;
		$this->secure = $secure;
		$this->httpOnly = $httpOnly;
	}

	/**
	 * Gets the name of the cookie
	 *
	 * @return string
	 */
	public function getName() : string
	{
		return $this->name;
	}

	/**
	 * Gets the domain that the cookie is available to
	 *
	 * @return string|NULL
	 */
	public function getDomain()
	{
		return $this->domain;
	}

	/**
	 * Gets the time the cookie expires
	 *
	 * @return int
	 */
	public function getExpiresTime() : int
	{
		return $this->expire;
	}

	/**
	 * Gets the path on the server in which the cookie will be available on
	 *
	 * @return string
	 */
	public function getPath() : string
	{
		return $this->path;
	}

	/**
	 * Checks whether the cookie should only be transmitted over a secure HTTPS connection from the client
	 *
	 * @return bool
	 */
	public function isSecure() : bool
	{
		return $this->secure;
	}

	/**
	 * Checks whether the cookie will be made accessible only through the HTTP protocol
	 *
	 * @return bool
	 */
	public function isHttpOnly() : bool
	{
		return $this->httpOnly;
	}
}


1		<?php
2		/**
3		* CookieSettings.php
4		*
5		* @copyright More in license.md
6		* @license http://www.ipublikuj.eu
7		* @author Adam Kadlec http://www.ipublikuj.eu
8		* @package iPublikuj:MobileDetect!
9		* @subpackage Helpers
10		* @since 1.0.0
11		*
12		* @date 23.04.14
13		*/
14
15		declare(strict_types = 1);
16
17		namespace IPub\MobileDetect\Helpers;
18
19		use Nette;
20
21		use IPub;
22		use IPub\MobileDetect\Exceptions;
23
24		/**
25		* Cookies creator helper
26		*
27		* @package iPublikuj:MobileDetect!
28		* @subpackage Helpers
29		*
30		* @author Adam Kadlec <[email protected]>
31		*/
32	1	final class CookieSettings
33		{
34		/**
35		* Implement nette smart magic
36		*/
37	1	use Nette\SmartObject;
38
39		/**
40		* @var string
41		*/
42		private $name;
43
44		/**
45		* @var string\|NULL
46		*/
47		private $domain;
48
49		/**
50		* @var string
51		*/
52		private $expire;
53
54		/**
55		* @var string
56		*/
57		private $path;
58
59		/**
60		* @var bool
61		*/
62		private $secure;
63
64		/**
65		* @var bool
66		*/
67		private $httpOnly;
68
69		/**
70		* @param string $name The name of the cookie
71		* @param string $expireAfter The time the cookie expires
72		* @param string $path The path on the server in which the cookie will be available on
73		* @param string $domain The domain that the cookie is available to
74		* @param bool $secure Whether the cookie should only be transmitted over a secure HTTPS connection from the client
75		* @param bool $httpOnly Whether the cookie will be made accessible only through the HTTP protocol
76		*
77		* @throws Exceptions\InvalidArgumentException
78		*/
79		public function __construct(string $name, string $domain = NULL, string $expireAfter = NULL, string $path = '/', bool $secure = FALSE, bool $httpOnly = TRUE)
80		{
81		// from PHP source code
82	1	if (preg_match("/[=,; \t\r\n\013\014]/", $name)) {
83		throw new Exceptions\InvalidArgumentException(sprintf('The cookie name "%s" contains invalid characters.', $name));
84		}
85
86	1	if (empty($name)) {
87		throw new Exceptions\InvalidArgumentException('The cookie name cannot be empty.');
88		}
89
90	1	$expire = new \DateTime;
91
92	1	if ($expireAfter !== NULL) {
93	1	$expire->modify($expireAfter);
94		}
95
96	1	$this->name = $name;
97	1	$this->domain = $domain;
98	1	$this->expire = (int) $expire->format('U');
		0 ignored issues – show Documentation Bug introduced 2017-01-15 12:27 UTC by Report Bug Copy Issue Report The property `$expire` was declared of type `string`, but `(int) $expire->format('U')` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
99	1	$this->path = empty($path) ? '/' : $path;
100	1	$this->secure = $secure;
101	1	$this->httpOnly = $httpOnly;
102	1	}
103
104		/**
105		* Gets the name of the cookie
106		*
107		* @return string
108		*/
109		public function getName() : string
110		{
111	1	return $this->name;
112		}
113
114		/**
115		* Gets the domain that the cookie is available to
116		*
117		* @return string\|NULL
118		*/
119		public function getDomain()
120		{
121		return $this->domain;
122		}
123
124		/**
125		* Gets the time the cookie expires
126		*
127		* @return int
128		*/
129		public function getExpiresTime() : int
130		{
131		return $this->expire;
132		}
133
134		/**
135		* Gets the path on the server in which the cookie will be available on
136		*
137		* @return string
138		*/
139		public function getPath() : string
140		{
141		return $this->path;
142		}
143
144		/**
145		* Checks whether the cookie should only be transmitted over a secure HTTPS connection from the client
146		*
147		* @return bool
148		*/
149		public function isSecure() : bool
150		{
151		return $this->secure;
152		}
153
154		/**
155		* Checks whether the cookie will be made accessible only through the HTTP protocol
156		*
157		* @return bool
158		*/
159		public function isHttpOnly() : bool
160		{
161		return $this->httpOnly;
162		}
163		}
164

iPublikuj / mobile-detect

Push — master ( 9edc41...f34eb1 )

CookieSettings::getExpiresTime() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like