IPub\JsonAPIClient\Objects\TIdentifiable

Complexity

Total Complexity

10

Size/Duplication

Total Lines	62
Duplicated Lines	51.61 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getType()	14	14	4
A	hasType()	0	4	1
A	getId()	18	18	4
A	hasId()	0	4	1

<?php
/**
 * TIdentifiable.php
 *
 * @copyright      More in license.md
 * @license        https://www.ipublikuj.eu
 * @author         Adam Kadlec <adam.kadlec@ipublikuj.eu>
 * @package        iPublikuj:JsonAPIClient!
 * @subpackage     Objects
 * @since          1.0.0
 *
 * @date           05.05.18
 */

declare(strict_types = 1);

namespace IPub\JsonAPIClient\Objects;

use Neomerx\JsonApi\Contracts\Document\DocumentInterface;

use IPub\JsonAPIClient\Exceptions;

/**
 * Identifiable trait
 *
 * @package        iPublikuj:JsonAPIClient!
 * @subpackage     Objects
 *
 * @author         Adam Kadlec <adam.kadlec@ipublikuj.eu>
 */
trait TIdentifiable
{
	/**
	 * @return string
	 *
	 * @throws Exceptions\RuntimeException if the type member is not present, or is not a string, or is an empty string
	 */
	public function getType() : string

This method seems to be duplicated in your project.

	{
		if (!$this->has(DocumentInterface::KEYWORD_TYPE)) {

It seems like has() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			throw new Exceptions\RuntimeException('Type member not present.');
		}

		$type = $this->get(DocumentInterface::KEYWORD_TYPE);

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		if (!is_string($type) || empty($type)) {
			throw new Exceptions\RuntimeException('Type member is not a string, or is empty.');
		}

		return $type;
	}

	/**
	 * @return bool
	 */
	public function hasType() : bool
	{
		return $this->has(DocumentInterface::KEYWORD_TYPE);

It seems like has() must be provided by classes using this trait. How about adding it as abstract method to this trait?

	}

	/**
	 * @return string
	 *
	 * @throws Exceptions\RuntimeException if the id member is not present, or is not a string/int, or is an empty string
	 */
	public function getId() : string

This method seems to be duplicated in your project.

	{
		if (!$this->has(DocumentInterface::KEYWORD_ID)) {

It seems like has() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			throw new Exceptions\RuntimeException('Id member not present.');
		}

		$id = $this->get(DocumentInterface::KEYWORD_ID);

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		if (!is_string($id)) {
			throw new Exceptions\RuntimeException('Id member is not a string.');
		}

		if (empty($id)) {
			throw new Exceptions\RuntimeException('Id member is an empty string.');
		}

		return $id;
	}

	/**
	 * @return bool
	 */
	public function hasId() : bool
	{
		return $this->has(DocumentInterface::KEYWORD_ID);

It seems like has() must be provided by classes using this trait. How about adding it as abstract method to this trait?

	}
}