Passed
Pull Request — v3.0 (#166)
by Samir
12:13
created
web_interface/astpp/application/libraries/astpp/form.php 1 patch
Braces   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -21,8 +21,9 @@  discard block
 block discarded – undo
21 21
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
22 22
 ###############################################################################
23 23
 
24
-if ( ! defined('BASEPATH'))
24
+if ( ! defined('BASEPATH')) {
25 25
     exit('No direct script access allowed');
26
+}
26 27
 
27 28
 /**
28 29
  * Dynamically build forms for display
@@ -137,10 +138,11 @@  discard block
 block discarded – undo
137 138
             foreach ($form_fileds as $fieldkey => $fieldvalue) {
138 139
                 $form_contents .= '<li class="col-md-12">';
139 140
                 if ($fieldvalue[1] == 'HIDDEN') {
140
-                    if (isset($this->CI->input->post))
141
-                        $fieldvalue[2]['value'] = ( ! $this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
142
-                    else
143
-                        $fieldvalue[2]['value'] = ($values) ? (isset($values[$fieldvalue[2]['name']]) ? $values[$fieldvalue[2]['name']] : '') : (isset($fieldvalue[2]['value']) ? $fieldvalue[2]['value'] : '');
141
+                    if (isset($this->CI->input->post)) {
142
+                                            $fieldvalue[2]['value'] = ( ! $this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
143
+                    } else {
144
+                                            $fieldvalue[2]['value'] = ($values) ? (isset($values[$fieldvalue[2]['name']]) ? $values[$fieldvalue[2]['name']] : '') : (isset($fieldvalue[2]['value']) ? $fieldvalue[2]['value'] : '');
145
+                    }
144 146
                     $form_contents .= form_hidden($fieldvalue[2]['name'], $fieldvalue[2]['value']);
145 147
                 } else {
146 148
 		      $validation_arr = array();
@@ -148,8 +150,7 @@  discard block
 block discarded – undo
148 150
 		        if ( ! empty($fieldvalue[3])) {
149 151
 		          $validation_arr = explode("|", $fieldvalue[3]);
150 152
 		        }
151
-		      }
152
-		      elseif ($fieldvalue[2] == 'SELECT') {
153
+		      } elseif ($fieldvalue[2] == 'SELECT') {
153 154
 
154 155
 		        if (is_array($fieldvalue[4])) {
155 156
 		          $validation_arr = explode("|", $fieldvalue[4]['rules']);
@@ -199,16 +200,16 @@  discard block
 block discarded – undo
199 200
 								
200 201
 								if(isset($fieldvalue[1]['name'])){
201 202
 									$fieldvalue_pass=$fieldvalue[1]['name'];
202
-								}else{
203
+								} else{
203 204
 									$fieldvalue_pass=$fieldvalue[1];
204 205
 								}
205 206
 								
206 207
         				        $this->CI->form_validation->set_rules($fieldvalue_pass, $fieldvalue[0], $fieldvalue[4]['rules']);
207
-        				    }else{
208
+        				    } else{
208 209
 								
209 210
 								if(isset($fieldvalue[1]['name'])){
210 211
 									$fieldvalue_pass=$fieldvalue[1]['name'];
211
-								}else{
212
+								} else{
212 213
 									$fieldvalue_pass=$fieldvalue[1];
213 214
 								}
214 215
 								
@@ -245,10 +246,11 @@  discard block
 block discarded – undo
245 246
 					/* For multi select code */
246 247
 					$str = $fieldvalue[7] . "," . $fieldvalue[8];
247 248
 
248
-					if (isset($this->CI->input->post))
249
-						$fieldvalue['value'] = (!$this->CI->input->post($fieldvalue[1])) ? @$fieldvalue[1] : $this->CI->input->post($fieldvalue[1]);
250
-					else
251
-						$fieldvalue['value'] = ($values) ? @$values[$fieldvalue[1]] : @$fieldvalue[1];
249
+					if (isset($this->CI->input->post)) {
250
+											$fieldvalue['value'] = (!$this->CI->input->post($fieldvalue[1])) ? @$fieldvalue[1] : $this->CI->input->post($fieldvalue[1]);
251
+					} else {
252
+											$fieldvalue['value'] = ($values) ? @$values[$fieldvalue[1]] : @$fieldvalue[1];
253
+					}
252 254
 
253 255
 					$drp_array = call_user_func_array(array($this->CI->db_model, $fieldvalue[10]), array($str, $fieldvalue[9], $fieldvalue[11], $fieldvalue[12]));
254 256
 					if ($fieldset_key === 'System Configuration Information') {
@@ -265,9 +267,9 @@  discard block
 block discarded – undo
265 267
 				} else if ($fieldvalue[1] == 'INPUT') {
266 268
 
267 269
 
268
-					if (isset($this->CI->input->post))
269
-						$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? $fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
270
-					else{
270
+					if (isset($this->CI->input->post)) {
271
+											$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? $fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
272
+					} else{
271 273
 						$fieldvalue[2]['value'] = ($values) ? (isset($values[$fieldvalue[2]['name']]) ? $values[$fieldvalue[2]['name']] : ''):(isset($fieldvalue[2]['value']) ? $fieldvalue[2]['value'] :'');
272 274
 					}    
273 275
 					$form_contents.= form_input($fieldvalue[2], 'readonly');
@@ -283,11 +285,11 @@  discard block
 block discarded – undo
283 285
                  * Image upload from invoice configuration code.
284 286
                  */
285 287
 				else if ($fieldvalue[1] == 'IMAGE') {
286
-					if (isset($this->CI->input->post))
287
-						$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
288
-                       
289
-					else
290
-						$fieldvalue[2]['value'] = ($values) ? @$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
288
+					if (isset($this->CI->input->post)) {
289
+											$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
290
+					} else {
291
+											$fieldvalue[2]['value'] = ($values) ? @$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
292
+					}
291 293
 						$fieldvalue[2]['style'] = isset($fieldvalue[2]['style']) ? $fieldvalue[2]['style'] : "";
292 294
 					$form_contents.= form_image($fieldvalue[2], 'readonly',$fieldvalue[2]['style']);
293 295
 						 $form_contents.=@$fieldvalue[6];
@@ -295,13 +297,12 @@  discard block
 block discarded – undo
295 297
 					$form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.$fieldvalue[2]['name'].'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>';
296 298
 					$form_contents.= '<span class="popup_error error  no-padding" id="'.$fieldvalue[2]['name'].'_error">
297 299
                     </span></div>';
298
-				}
299
-				else if ($fieldvalue[1] == 'DEL_BUTTON') {
300
-					if (isset($this->CI->input->post))
301
-						$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
302
-                       
303
-					else
304
-						$fieldvalue[2]['value'] = ($values) ? @$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
300
+				} else if ($fieldvalue[1] == 'DEL_BUTTON') {
301
+					if (isset($this->CI->input->post)) {
302
+											$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
303
+					} else {
304
+											$fieldvalue[2]['value'] = ($values) ? @$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
305
+					}
305 306
 						$fieldvalue[2]['style'] = isset($fieldvalue[2]['style']) ? $fieldvalue[2]['style'] : "";
306 307
 					$form_contents.= form_img_delete($fieldvalue[2], 'readonly',$fieldvalue[2]['style']);
307 308
 						 $form_contents.=@$fieldvalue[6];
@@ -312,10 +313,11 @@  discard block
 block discarded – undo
312 313
 				}
313 314
 				/**********************************************************************************/
314 315
 				else if ($fieldvalue[1] == 'PASSWORD') {
315
-					if (isset($this->CI->input->post))
316
-						$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
317
-					else
318
-						$fieldvalue[2]['value'] = ($values) ?@$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
316
+					if (isset($this->CI->input->post)) {
317
+											$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
318
+					} else {
319
+											$fieldvalue[2]['value'] = ($values) ?@$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
320
+					}
319 321
 					$form_contents.= form_password($fieldvalue[2]);
320 322
 					$this->CI->form_validation->set_rules($fieldvalue[2]['name'], $fieldvalue[0], $fieldvalue[3]);
321 323
 					$form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.$fieldvalue[2]['name'].'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>';
@@ -324,12 +326,12 @@  discard block
 block discarded – undo
324 326
 				} else if ($fieldvalue[2] == 'CHECKBOX') {
325 327
 					$OptionArray = array();
326 328
 
327
-					if(isset($fieldvalue[7]) && $fieldvalue[7] != '')
328
-					$OptionArray = call_user_func_array(array($this->CI->common, $fieldvalue[7]), array($fieldvalue[6]));
329
+					if(isset($fieldvalue[7]) && $fieldvalue[7] != '') {
330
+										$OptionArray = call_user_func_array(array($this->CI->common, $fieldvalue[7]), array($fieldvalue[6]));
331
+					}
329 332
 					if (isset($this->CI->input->post)){
330 333
 						$fieldvalue[3]['value'] = (!$this->CI->input->post($fieldvalue[1])) ? @$fieldvalue[3]['value'] : $this->CI->input->post($fieldvalue[1]);
331
-					}    
332
-					else
334
+					} else
333 335
 					{
334 336
 						$fieldvalue[3]['value'] = ($values) ? (isset($values[$fieldvalue[1]]) && $values[$fieldvalue[1]] ? 1: 0) : @$fieldvalue[3]['value'];
335 337
 					}
@@ -341,18 +343,18 @@  discard block
 block discarded – undo
341 343
 					if(isset($fieldvalue[3]['table_name']) && $fieldvalue[3]['table_name'] != ""){
342 344
 							
343 345
 						 $form_contents.= form_checkbox($fieldvalue[1], $fieldvalue[3]['value'],$checked , $OptionArray);
344
-					}else{
346
+					} else{
345 347
 						 $form_contents.= form_checkbox($fieldvalue[1], $fieldvalue[3]['value'],$checked ,$OptionArray);
346 348
 					}
347 349
 				} else if ($fieldvalue[1] == 'TEXTAREA') {
348 350
 
349
-					if (isset($this->CI->input->post))
350
-						$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
351
-					else
352
-						$fieldvalue[2]['value'] = ($values) ? $values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
351
+					if (isset($this->CI->input->post)) {
352
+											$fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']);
353
+					} else {
354
+											$fieldvalue[2]['value'] = ($values) ? $values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value'];
355
+					}
353 356
 					$form_contents.= form_textarea($fieldvalue[2]);
354
-				}
355
-				else if ($fieldvalue[2] == 'RADIO') {
357
+				} else if ($fieldvalue[2] == 'RADIO') {
356 358
 
357 359
 					$form_contents.= form_radio($fieldvalue[1], $fieldvalue[3]['value'], $fieldvalue[3]['checked']);
358 360
 				}
@@ -582,8 +584,9 @@  discard block
 block discarded – undo
582 584
 		$json_data["json_paging"]['total'] = $config['total_rows'];
583 585
 		$perpage = $config['per_page'];
584 586
 		$start = ($page_no - 1) * $perpage;
585
-		if ($start < 0)
586
-			$start = 0;
587
+		if ($start < 0) {
588
+					$start = 0;
589
+		}
587 590
 		$json_data["paging"]['start'] = $start;
588 591
 		$json_data["paging"]['page_no'] = $perpage;
589 592
 		return $json_data;
@@ -612,7 +615,7 @@  discard block
 block discarded – undo
612 615
 						   if($field_arr[2]=="status"){
613 616
 							$row['id'] = $row_id;
614 617
 							$jsn_tmp[$field_key] = call_user_func_array(array($this->CI->common, $field_arr[5]), array($field_arr[3], $field_arr[4], $row));
615
-			   }else{
618
+			   } else{
616 619
 							$jsn_tmp[$field_key] = call_user_func_array(array($this->CI->common, $field_arr[5]), array($field_arr[3], $field_arr[4], $row[$field_arr[2]]));
617 620
 			   }
618 621
 
@@ -637,13 +640,13 @@  discard block
 block discarded – undo
637 640
 				$fieldstr = $this->CI->common->build_custome_edit_button($ActionArr[5]->EDIT,$row[$field_arr[2]],$row["id"]);
638 641
 				if($acctype != ''){
639 642
 					$jsn_tmp[$field_key] = $fieldstr."<br/>".$acctype;
640
-				}else{
643
+				} else{
641 644
 					$jsn_tmp[$field_key] = $fieldstr;
642 645
 				}
643 646
 			    
644 647
 
645 648
 /*********************************/
646
-			  }else {
649
+			  } else {
647 650
 							$jsn_tmp[$field_key] = $row[$field_arr[2]];
648 651
 				  }                  				
649 652
 			} else {
@@ -677,15 +680,13 @@  discard block
 block discarded – undo
677 680
 */			   
678 681
 							$jsn_tmp[$field_key] = $this->CI->common->get_action_buttons($field_arr[5], $row_id);
679 682
 							/****************************************************************************/
680
-						}
681
-						elseif($field_arr[0] == gettext("Profile Action"))
683
+						} elseif($field_arr[0] == gettext("Profile Action"))
682 684
 						{
683 685
 						   if(isset($field_arr[5]) && isset($field_arr[5]->START) && isset($field_arr[5]->STOP) && isset($field_arr[5]->RELOAD) && isset($field_arr[5]->RESCAN)){
684 686
 							}
685 687
 						   $jsn_tmp[$field_key] = $this->CI->common->get_action_buttons($field_arr[5], $row["id"]);
686 688
                         
687
-						}
688
-						else {
689
+						} else {
689 690
 							$className = (isset($field_arr['9']) && $field_arr['9'] != '')?$field_arr['9']:"chkRefNos";
690 691
 							$jsn_tmp[$field_key] = '<input type="checkbox" name="chkAll" id=' . $row['id'] . ' class="ace '.$className.'" onclick="clickchkbox(' . $row['id'] . ')" value=' . $row['id'] . '><lable class="lbl"></lable>';                        }
691 692
 					}
@@ -714,7 +715,7 @@  discard block
 block discarded – undo
714 715
 						 if($field_arr[2]=="status"){
715 716
 							$row['id'] = $row_id;
716 717
 							$jsn_tmp[$field_key] = call_user_func_array(array($this->CI->common, $field_arr[5]), array($field_arr[3], $field_arr[4], $row));
717
-						 }else{
718
+						 } else{
718 719
 							$jsn_tmp[$field_key] = call_user_func_array(array($this->CI->common, $field_arr[5]), array($field_arr[3], $field_arr[4], $row[$field_arr[2]]));
719 720
 						 }
720 721
 /**
@@ -732,14 +733,13 @@  discard block
 block discarded – undo
732 733
 				}
733 734
 				$jsn_tmp[$field_key] = $this->CI->common->build_custome_edit_button($ActionArr[5]->EDIT,$row[$field_arr[2]],$row["id"]);
734 735
 /*******************************/
735
-			}else {
736
+			} else {
736 737
 						$jsn_tmp[$field_key] = isset($row[$field_arr[2]]) ? $row[$field_arr[2]] : "";
737 738
 					}
738 739
 				} else {
739 740
 					if ($field_arr[0] == "Action") {
740 741
 						$jsn_tmp[$field_key] = $this->CI->common->get_action_buttons($field_arr[5], $row["id"]);
741
-					}
742
-			  else {
742
+					} else {
743 743
 							$jsn_tmp[$field_key] = '<input type="checkbox" name="chkAll" id=' . $row['id'] . ' class="ace chkRefNos" onclick="clickchkbox(' . $row['id'] . ')" value=' . $row['id'] . '><lable class="lbl"></lable>';
744 744
 						}
745 745
 				}
Please login to merge, or discard this patch.