Inspection of "Merge pull request #124 from iNextrix/ISSUE-7142" - iNextrix/ASTPP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — v3.0 (3d1631)

by Samir

created 2016-10-16 15:46 UTC

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -89,7 +89,7 @@  discard block
 block discarded – undo
 	 * Non-persistent database connection
 	 *
 	 * @access	private called by the base class
-	 * @return	resource
+	 * @return	PDO
 	 */
 	function db_connect()
 	{
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
 	 * Persistent database connection
 	 *
 	 * @access	private called by the base class
-	 * @return	resource
+	 * @return	PDO
 	 */
 	function db_pconnect()
 	{
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
 	 * Select the database
 	 *
 	 * @access	private called by the base class
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_select()
 	{
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
 	 * @access	public
 	 * @param	string
 	 * @param	string
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_set_charset($charset, $collation)
 	{
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string
-	 * @return	string
+	 * @return	integer
 	 */
 	function count_all($table = '')
 	{
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _field_data($table)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/pdo/pdo_forge.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@  discard block
 block discarded – undo
 	 * @param	mixed	primary key(s)
 	 * @param	mixed	key(s)
 	 * @param	boolean	should 'IF NOT EXISTS' be added to the SQL
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
 	{
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
 	 * @param	string	the default value
 	 * @param	boolean	should 'NOT NULL' be added
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	string
 	 */
 	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/pdo/pdo_result.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -127,7 +127,7 @@
 block discarded – undo
 	 * result set starts at zero
 	 *
 	 * @access	private
-	 * @return	array
+	 * @return	boolean
 	 */
 	function _data_seek($n = 0)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/postgre/postgre_driver.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -124,7 +124,7 @@  discard block
 block discarded – undo
 	 * Select the database
 	 *
 	 * @access	private called by the base class
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_select()
 	{
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
 	 * @access	public
 	 * @param	string
 	 * @param	string
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_set_charset($charset, $collation)
 	{
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string
-	 * @return	string
+	 * @return	integer
 	 */
 	function count_all($table = '')
 	{
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _field_data($table)
 	{
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
 	 * The error message number
 	 *
 	 * @access	private
-	 * @return	integer
+	 * @return	string
 	 */
 	function _error_number()
 	{
@@ -522,7 +522,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	type
-	 * @return	type
+	 * @return	string
 	 */
 	function _from_tables($tables)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/postgre/postgre_forge.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_database($name)
 	{
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _drop_database($name)
 	{
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
 	 * Drop Table
 	 *
 	 * @access    private
-	 * @return    bool
+	 * @return    string
 	 */
 	function _drop_table($table)
 	{
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
 	 * @param	string	the default value
 	 * @param	boolean	should 'NOT NULL' be added
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	string
 	 */
 	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/postgre/postgre_result.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -125,7 +125,7 @@
 block discarded – undo
 	 * result set starts at zero
 	 *
 	 * @access	private
-	 * @return	array
+	 * @return	boolean
 	 */
 	function _data_seek($n = 0)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/postgre/postgre_utility.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * List databases
 	 *
 	 * @access	private
-	 * @return	bool
+	 * @return	string
 	 */
 	function _list_databases()
 	{
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 */
 	function _optimize_table($table)
 	{
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 */
 	function _repair_table($table)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/sqlite/sqlite_driver.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -119,7 +119,7 @@  discard block
 block discarded – undo
 	 * Select the database
 	 *
 	 * @access	private called by the base class
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_select()
 	{
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
 	 * @access	public
 	 * @param	string
 	 * @param	string
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_set_charset($charset, $collation)
 	{
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string
-	 * @return	string
+	 * @return	integer
 	 */
 	function count_all($table = '')
 	{
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string	the table name
-	 * @return	string
+	 * @return	boolean
 	 */
 	function _list_columns($table = '')
 	{
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _field_data($table)
 	{
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	type
-	 * @return	type
+	 * @return	string
 	 */
 	function _from_tables($tables)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/sqlite/sqlite_forge.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -70,7 +70,7 @@  discard block
 block discarded – undo
 	 * @param	mixed	primary key(s)
 	 * @param	mixed	key(s)
 	 * @param	boolean	should 'IF NOT EXISTS' be added to the SQL
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
 	{
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
 	 * @param	string	the default value
 	 * @param	boolean	should 'NOT NULL' be added
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	false|string
 	 */
 	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
 	{

Please login to merge, or discard this patch.

		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73	* @param mixed primary key(s)
74	74	* @param mixed key(s)
75	75	* @param boolean should 'IF NOT EXISTS' be added to the SQL
76		- * @return bool
	76	+ * @return string
77	77	*/
78	78	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
79	79	{
		@@ -203,7 +203,7 @@ discard block
		block discarded – undo
203	203	* @param string the default value
204	204	* @param boolean should 'NOT NULL' be added
205	205	* @param string the field after which we should add the new field
206		- * @return object
	206	+ * @return string
207	207	*/
208	208	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
209	209	{

		@@ -127,7 +127,7 @@
		block discarded – undo
127	127	* result set starts at zero
128	128	*
129	129	* @access private
130		- * @return array
	130	+ * @return boolean
131	131	*/
132	132	function _data_seek($n = 0)
133	133	{

		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89	* Non-persistent database connection
90	90	*
91	91	* @access private called by the base class
92		- * @return resource
	92	+ * @return PDO
93	93	*/
94	94	function db_connect()
95	95	{
		@@ -104,7 +104,7 @@ discard block
		block discarded – undo
104	104	* Persistent database connection
105	105	*
106	106	* @access private called by the base class
107		- * @return resource
	107	+ * @return PDO
108	108	*/
109	109	function db_pconnect()
110	110	{
		@@ -140,7 +140,7 @@ discard block
		block discarded – undo
140	140	* Select the database
141	141	*
142	142	* @access private called by the base class
143		- * @return resource
	143	+ * @return boolean
144	144	*/
145	145	function db_select()
146	146	{
		@@ -156,7 +156,7 @@ discard block
		block discarded – undo
156	156	* @access public
157	157	* @param string
158	158	* @param string
159		- * @return resource
	159	+ * @return boolean
160	160	*/
161	161	function db_set_charset($charset, $collation)
162	162	{
		@@ -394,7 +394,7 @@ discard block
		block discarded – undo
394	394	*
395	395	* @access public
396	396	* @param string
397		- * @return string
	397	+ * @return integer
398	398	*/
399	399	function count_all($table = '')
400	400	{
		@@ -464,7 +464,7 @@ discard block
		block discarded – undo
464	464	*
465	465	* @access public
466	466	* @param string the table name
467		- * @return object
	467	+ * @return string
468	468	*/
469	469	function _field_data($table)
470	470	{

		@@ -124,7 +124,7 @@ discard block
		block discarded – undo
124	124	* Select the database
125	125	*
126	126	* @access private called by the base class
127		- * @return resource
	127	+ * @return boolean
128	128	*/
129	129	function db_select()
130	130	{
		@@ -140,7 +140,7 @@ discard block
		block discarded – undo
140	140	* @access public
141	141	* @param string
142	142	* @param string
143		- * @return resource
	143	+ * @return boolean
144	144	*/
145	145	function db_set_charset($charset, $collation)
146	146	{
		@@ -368,7 +368,7 @@ discard block
		block discarded – undo
368	368	*
369	369	* @access public
370	370	* @param string
371		- * @return string
	371	+ * @return integer
372	372	*/
373	373	function count_all($table = '')
374	374	{
		@@ -437,7 +437,7 @@ discard block
		block discarded – undo
437	437	*
438	438	* @access public
439	439	* @param string the table name
440		- * @return object
	440	+ * @return string
441	441	*/
442	442	function _field_data($table)
443	443	{
		@@ -463,7 +463,7 @@ discard block
		block discarded – undo
463	463	* The error message number
464	464	*
465	465	* @access private
466		- * @return integer
	466	+ * @return string
467	467	*/
468	468	function _error_number()
469	469	{
		@@ -522,7 +522,7 @@ discard block
		block discarded – undo
522	522	*
523	523	* @access public
524	524	* @param type
525		- * @return type
	525	+ * @return string
526	526	*/
527	527	function _from_tables($tables)
528	528	{

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	*
30	30	* @access private
31	31	* @param string the database name
32		- * @return bool
	32	+ * @return string
33	33	*/
34	34	function _create_database($name)
35	35	{
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	*
44	44	* @access private
45	45	* @param string the database name
46		- * @return bool
	46	+ * @return string
47	47	*/
48	48	function _drop_database($name)
49	49	{
		@@ -214,7 +214,7 @@ discard block
		block discarded – undo
214	214	* Drop Table
215	215	*
216	216	* @access private
217		- * @return bool
	217	+ * @return string
218	218	*/
219	219	function _drop_table($table)
220	220	{
		@@ -237,7 +237,7 @@ discard block
		block discarded – undo
237	237	* @param string the default value
238	238	* @param boolean should 'NOT NULL' be added
239	239	* @param string the field after which we should add the new field
240		- * @return object
	240	+ * @return string
241	241	*/
242	242	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
243	243	{

		@@ -125,7 +125,7 @@
		block discarded – undo
125	125	* result set starts at zero
126	126	*
127	127	* @access private
128		- * @return array
	128	+ * @return boolean
129	129	*/
130	130	function _data_seek($n = 0)
131	131	{

		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	* List databases
29	29	*
30	30	* @access private
31		- * @return bool
	31	+ * @return string
32	32	*/
33	33	function _list_databases()
34	34	{
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	*
45	45	* @access private
46	46	* @param string the table name
47		- * @return object
	47	+ * @return boolean
48	48	*/
49	49	function _optimize_table($table)
50	50	{
		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	*
61	61	* @access private
62	62	* @param string the table name
63		- * @return object
	63	+ * @return boolean
64	64	*/
65	65	function _repair_table($table)
66	66	{

		@@ -119,7 +119,7 @@ discard block
		block discarded – undo
119	119	* Select the database
120	120	*
121	121	* @access private called by the base class
122		- * @return resource
	122	+ * @return boolean
123	123	*/
124	124	function db_select()
125	125	{
		@@ -134,7 +134,7 @@ discard block
		block discarded – undo
134	134	* @access public
135	135	* @param string
136	136	* @param string
137		- * @return resource
	137	+ * @return boolean
138	138	*/
139	139	function db_set_charset($charset, $collation)
140	140	{
		@@ -337,7 +337,7 @@ discard block
		block discarded – undo
337	337	*
338	338	* @access public
339	339	* @param string
340		- * @return string
	340	+ * @return integer
341	341	*/
342	342	function count_all($table = '')
343	343	{
		@@ -389,7 +389,7 @@ discard block
		block discarded – undo
389	389	*
390	390	* @access public
391	391	* @param string the table name
392		- * @return string
	392	+ * @return boolean
393	393	*/
394	394	function _list_columns($table = '')
395	395	{
		@@ -406,7 +406,7 @@ discard block
		block discarded – undo
406	406	*
407	407	* @access public
408	408	* @param string the table name
409		- * @return object
	409	+ * @return string
410	410	*/
411	411	function _field_data($table)
412	412	{
		@@ -491,7 +491,7 @@ discard block
		block discarded – undo
491	491	*
492	492	* @access public
493	493	* @param type
494		- * @return type
	494	+ * @return string
495	495	*/
496	496	function _from_tables($tables)
497	497	{

		@@ -70,7 +70,7 @@ discard block
		block discarded – undo
70	70	* @param mixed primary key(s)
71	71	* @param mixed key(s)
72	72	* @param boolean should 'IF NOT EXISTS' be added to the SQL
73		- * @return bool
	73	+ * @return string
74	74	*/
75	75	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
76	76	{
		@@ -202,7 +202,7 @@ discard block
		block discarded – undo
202	202	* @param string the default value
203	203	* @param boolean should 'NOT NULL' be added
204	204	* @param string the field after which we should add the new field
205		- * @return object
	205	+ * @return false\|string
206	206	*/
207	207	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
208	208	{

iNextrix / ASTPP

Branch — v3.0 (3d1631)

Category

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch