Inspection of "Merge pull request #124 from iNextrix/ISSUE-7142" - iNextrix/ASTPP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — v3.0 (3d1631)

by Samir

created 2016-10-16 15:46 UTC

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_database($name)
 	{
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _drop_database($name)
 	{
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
 	 * @param	mixed	primary key(s)
 	 * @param	mixed	key(s)
 	 * @param	boolean	should 'IF NOT EXISTS' be added to the SQL
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
 	{
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
 	 * @param	string	the column name
 	 * @param	array	fields
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	string
 	 */
 	function _alter_table($alter_type, $table, $fields, $after_field = '')
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mysqli/mysqli_result.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -130,7 +130,7 @@
 block discarded – undo
 	 * result set starts at zero
 	 *
 	 * @access	private
-	 * @return	array
+	 * @return	boolean
 	 */
 	function _data_seek($n = 0)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mysqli/mysqli_utility.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * List databases
 	 *
 	 * @access	private
-	 * @return	bool
+	 * @return	string
 	 */
 	function _list_databases()
 	{
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _optimize_table($table)
 	{
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _repair_table($table)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/oci8/oci8_driver.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -116,7 +116,7 @@  discard block
 block discarded – undo
 	 * Select the database
 	 *
 	 * @access  private called by the base class
-	 * @return  resource
+	 * @return  boolean
 	 */
 	public function db_select()
 	{
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
 	 * @access	public
 	 * @param	string
 	 * @param	string
-	 * @return	resource
+	 * @return	boolean
 	 */
 	public function db_set_charset($charset, $collation)
 	{
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
 	 * getCursor.  Returns a cursor from the datbase
 	 *
 	 * @access  public
-	 * @return  cursor id
+	 * @return  resource id
 	 */
 	public function get_cursor()
 	{
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access  public
 	 * @param   string
-	 * @return  string
+	 * @return  integer
 	 */
 	public function count_all($table = '')
 	{
@@ -522,7 +522,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access  public
 	 * @param   string  the table name
-	 * @return  object
+	 * @return  string
 	 */
 	protected function _field_data($table)
 	{
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	protected
 	 * @param	type
-	 * @return	type
+	 * @return	string
 	 */
 	protected function _from_tables($tables)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/oci8/oci8_forge.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 	 * @param	mixed	primary key(s)
 	 * @param	mixed	key(s)
 	 * @param	boolean	should 'IF NOT EXISTS' be added to the SQL
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
 	{
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
 	 * @param	string	the default value
 	 * @param	boolean	should 'NOT NULL' be added
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	string
 	 */
 	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/oci8/oci8_result.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -205,7 +205,7 @@
 block discarded – undo
 	 * result set starts at zero
 	 *
 	 * @access	protected
-	 * @return	array
+	 * @return	boolean
 	 */
 	protected function _data_seek($n = 0)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/oci8/oci8_utility.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 */
 	function _optimize_table($table)
 	{
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 */
 	function _repair_table($table)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/odbc/odbc_driver.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -101,7 +101,7 @@  discard block
 block discarded – undo
 	 * Select the database
 	 *
 	 * @access	private called by the base class
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_select()
 	{
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 	 * @access	public
 	 * @param	string
 	 * @param	string
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_set_charset($charset, $collation)
 	{
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string
-	 * @return	string
+	 * @return	integer
 	 */
 	function count_all($table = '')
 	{
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _field_data($table)
 	{
@@ -418,7 +418,7 @@  discard block
 block discarded – undo
 	 * The error message number
 	 *
 	 * @access	private
-	 * @return	integer
+	 * @return	string
 	 */
 	function _error_number()
 	{
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	type
-	 * @return	type
+	 * @return	string
 	 */
 	function _from_tables($tables)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/odbc/odbc_forge.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@  discard block
 block discarded – undo
 	 * @param	mixed	primary key(s)
 	 * @param	mixed	key(s)
 	 * @param	boolean	should 'IF NOT EXISTS' be added to the SQL
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
 	{
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
 	 * @param	string	the default value
 	 * @param	boolean	should 'NOT NULL' be added
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	string
 	 */
 	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
 	{

Please login to merge, or discard this patch.

		@@ -116,7 +116,7 @@ discard block
		block discarded – undo
116	116	* Select the database
117	117	*
118	118	* @access private called by the base class
119		- * @return resource
	119	+ * @return boolean
120	120	*/
121	121	public function db_select()
122	122	{
		@@ -132,7 +132,7 @@ discard block
		block discarded – undo
132	132	* @access public
133	133	* @param string
134	134	* @param string
135		- * @return resource
	135	+ * @return boolean
136	136	*/
137	137	public function db_set_charset($charset, $collation)
138	138	{
		@@ -209,7 +209,7 @@ discard block
		block discarded – undo
209	209	* getCursor. Returns a cursor from the datbase
210	210	*
211	211	* @access public
212		- * @return cursor id
	212	+ * @return resource id
213	213	*/
214	214	public function get_cursor()
215	215	{
		@@ -453,7 +453,7 @@ discard block
		block discarded – undo
453	453	*
454	454	* @access public
455	455	* @param string
456		- * @return string
	456	+ * @return integer
457	457	*/
458	458	public function count_all($table = '')
459	459	{
		@@ -522,7 +522,7 @@ discard block
		block discarded – undo
522	522	*
523	523	* @access public
524	524	* @param string the table name
525		- * @return object
	525	+ * @return string
526	526	*/
527	527	protected function _field_data($table)
528	528	{
		@@ -611,7 +611,7 @@ discard block
		block discarded – undo
611	611	*
612	612	* @access protected
613	613	* @param type
614		- * @return type
	614	+ * @return string
615	615	*/
616	616	protected function _from_tables($tables)
617	617	{

		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101	* Select the database
102	102	*
103	103	* @access private called by the base class
104		- * @return resource
	104	+ * @return boolean
105	105	*/
106	106	function db_select()
107	107	{
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117	* @access public
118	118	* @param string
119	119	* @param string
120		- * @return resource
	120	+ * @return boolean
121	121	*/
122	122	function db_set_charset($charset, $collation)
123	123	{
		@@ -322,7 +322,7 @@ discard block
		block discarded – undo
322	322	*
323	323	* @access public
324	324	* @param string
325		- * @return string
	325	+ * @return integer
326	326	*/
327	327	function count_all($table = '')
328	328	{
		@@ -392,7 +392,7 @@ discard block
		block discarded – undo
392	392	*
393	393	* @access public
394	394	* @param string the table name
395		- * @return object
	395	+ * @return string
396	396	*/
397	397	function _field_data($table)
398	398	{
		@@ -418,7 +418,7 @@ discard block
		block discarded – undo
418	418	* The error message number
419	419	*
420	420	* @access private
421		- * @return integer
	421	+ * @return string
422	422	*/
423	423	function _error_number()
424	424	{
		@@ -477,7 +477,7 @@ discard block
		block discarded – undo
477	477	*
478	478	* @access public
479	479	* @param type
480		- * @return type
	480	+ * @return string
481	481	*/
482	482	function _from_tables($tables)
483	483	{

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	*
30	30	* @access private
31	31	* @param string the database name
32		- * @return bool
	32	+ * @return string
33	33	*/
34	34	function _create_database($name)
35	35	{
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	*
44	44	* @access private
45	45	* @param string the database name
46		- * @return bool
	46	+ * @return string
47	47	*/
48	48	function _drop_database($name)
49	49	{
		@@ -140,7 +140,7 @@ discard block
		block discarded – undo
140	140	* @param mixed primary key(s)
141	141	* @param mixed key(s)
142	142	* @param boolean should 'IF NOT EXISTS' be added to the SQL
143		- * @return bool
	143	+ * @return string
144	144	*/
145	145	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
146	146	{
		@@ -212,7 +212,7 @@ discard block
		block discarded – undo
212	212	* @param string the column name
213	213	* @param array fields
214	214	* @param string the field after which we should add the new field
215		- * @return object
	215	+ * @return string
216	216	*/
217	217	function _alter_table($alter_type, $table, $fields, $after_field = '')
218	218	{

		@@ -130,7 +130,7 @@
		block discarded – undo
130	130	* result set starts at zero
131	131	*
132	132	* @access private
133		- * @return array
	133	+ * @return boolean
134	134	*/
135	135	function _data_seek($n = 0)
136	136	{

		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	* List databases
29	29	*
30	30	* @access private
31		- * @return bool
	31	+ * @return string
32	32	*/
33	33	function _list_databases()
34	34	{
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	*
45	45	* @access private
46	46	* @param string the table name
47		- * @return object
	47	+ * @return string
48	48	*/
49	49	function _optimize_table($table)
50	50	{
		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	*
61	61	* @access private
62	62	* @param string the table name
63		- * @return object
	63	+ * @return string
64	64	*/
65	65	function _repair_table($table)
66	66	{

		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	* @param mixed primary key(s)
62	62	* @param mixed key(s)
63	63	* @param boolean should 'IF NOT EXISTS' be added to the SQL
64		- * @return bool
	64	+ * @return string
65	65	*/
66	66	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
67	67	{
		@@ -186,7 +186,7 @@ discard block
		block discarded – undo
186	186	* @param string the default value
187	187	* @param boolean should 'NOT NULL' be added
188	188	* @param string the field after which we should add the new field
189		- * @return object
	189	+ * @return string
190	190	*/
191	191	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
192	192	{

		@@ -205,7 +205,7 @@
		block discarded – undo
205	205	* result set starts at zero
206	206	*
207	207	* @access protected
208		- * @return array
	208	+ * @return boolean
209	209	*/
210	210	protected function _data_seek($n = 0)
211	211	{

		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73	* @param mixed primary key(s)
74	74	* @param mixed key(s)
75	75	* @param boolean should 'IF NOT EXISTS' be added to the SQL
76		- * @return bool
	76	+ * @return string
77	77	*/
78	78	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
79	79	{
		@@ -203,7 +203,7 @@ discard block
		block discarded – undo
203	203	* @param string the default value
204	204	* @param boolean should 'NOT NULL' be added
205	205	* @param string the field after which we should add the new field
206		- * @return object
	206	+ * @return string
207	207	*/
208	208	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
209	209	{

iNextrix / ASTPP

Branch — v3.0 (3d1631)

Category

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch