Inspection of "Merge pull request #124 from iNextrix/ISSUE-7142" - iNextrix/ASTPP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — v3.0 (3d1631)

by Samir

created 2016-10-16 15:46 UTC

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * List databases
 	 *
 	 * @access	private
-	 * @return	array
+	 * @return	string|false
 	 */
 	function _list_databases()
 	{
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 * @link 	http://www.cubrid.org/manual/840/en/Optimize%20Database
 	 */
 	function _optimize_table($table)
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 * @link 	http://www.cubrid.org/manual/840/en/Checking%20Database%20Consistency
 	 */
 	function _repair_table($table)

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mssql/mssql_driver.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -120,7 +120,7 @@  discard block
 block discarded – undo
 	 * @access	public
 	 * @param	string
 	 * @param	string
-	 * @return	resource
+	 * @return	boolean
 	 */
 	function db_set_charset($charset, $collation)
 	{
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
 	*
 	* @access private
 	* @param string $version
-	* @return int16 major version number
+	* @return string major version number
 	*/
 	function _parse_major_version($version)
 	{
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string
-	 * @return	string
+	 * @return	integer
 	 */
 	function count_all($table = '')
 	{
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _field_data($table)
 	{
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
 	 * The error message number
 	 *
 	 * @access	private
-	 * @return	integer
+	 * @return	string
 	 */
 	function _error_number()
 	{
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	type
-	 * @return	type
+	 * @return	string
 	 */
 	function _from_tables($tables)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mssql/mssql_forge.php 1 patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_database($name)
 	{
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _drop_database($name)
 	{
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 	 * Drop Table
 	 *
 	 * @access	private
-	 * @return	bool
+	 * @return	string
 	 */
 	function _drop_table($table)
 	{
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
 	 * @param	mixed	primary key(s)
 	 * @param	mixed	key(s)
 	 * @param	boolean	should 'IF NOT EXISTS' be added to the SQL
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
 	{
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
 	 * @param	string	the default value
 	 * @param	boolean	should 'NOT NULL' be added
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	string
 	 */
 	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mssql/mssql_result.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -125,7 +125,7 @@
 block discarded – undo
 	 * result set starts at zero
 	 *
 	 * @access	private
-	 * @return	array
+	 * @return	boolean
 	 */
 	function _data_seek($n = 0)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mssql/mssql_utility.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * List databases
 	 *
 	 * @access	private
-	 * @return	bool
+	 * @return	string
 	 */
 	function _list_databases()
 	{
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 */
 	function _optimize_table($table)
 	{
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	boolean
 	 */
 	function _repair_table($table)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mysql/mysql_driver.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -372,7 +372,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string
-	 * @return	string
+	 * @return	integer
 	 */
 	function count_all($table = '')
 	{
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _field_data($table)
 	{
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	public
 	 * @param	type
-	 * @return	type
+	 * @return	string
 	 */
 	function _from_tables($tables)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mysql/mysql_forge.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_database($name)
 	{
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the database name
-	 * @return	bool
+	 * @return	string
 	 */
 	function _drop_database($name)
 	{
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
 	 * @param	mixed	primary key(s)
 	 * @param	mixed	key(s)
 	 * @param	boolean	should 'IF NOT EXISTS' be added to the SQL
-	 * @return	bool
+	 * @return	string
 	 */
 	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
 	{
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
 	 * @param	string	the column name
 	 * @param	array	fields
 	 * @param	string	the field after which we should add the new field
-	 * @return	object
+	 * @return	string
 	 */
 	function _alter_table($alter_type, $table, $fields, $after_field = '')
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mysql/mysql_result.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -130,7 +130,7 @@
 block discarded – undo
 	 * result set starts at zero
 	 *
 	 * @access	private
-	 * @return	array
+	 * @return	boolean
 	 */
 	function _data_seek($n = 0)
 	{

Please login to merge, or discard this patch.

web_interface/astpp/system/database/drivers/mysql/mysql_utility.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * List databases
 	 *
 	 * @access	private
-	 * @return	bool
+	 * @return	string
 	 */
 	function _list_databases()
 	{
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _optimize_table($table)
 	{
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	string	the table name
-	 * @return	object
+	 * @return	string
 	 */
 	function _repair_table($table)
 	{
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
 	 *
 	 * @access	private
 	 * @param	array	Preferences
-	 * @return	mixed
+	 * @return	false|string
 	 */
 	function _backup($params = array())
 	{

Please login to merge, or discard this patch.

		@@ -120,7 +120,7 @@ discard block
		block discarded – undo
120	120	* @access public
121	121	* @param string
122	122	* @param string
123		- * @return resource
	123	+ * @return boolean
124	124	*/
125	125	function db_set_charset($charset, $collation)
126	126	{
		@@ -319,7 +319,7 @@ discard block
		block discarded – undo
319	319	*
320	320	* @access private
321	321	* @param string $version
322		- * @return int16 major version number
	322	+ * @return string major version number
323	323	*/
324	324	function _parse_major_version($version)
325	325	{
		@@ -350,7 +350,7 @@ discard block
		block discarded – undo
350	350	*
351	351	* @access public
352	352	* @param string
353		- * @return string
	353	+ * @return integer
354	354	*/
355	355	function count_all($table = '')
356	356	{
		@@ -421,7 +421,7 @@ discard block
		block discarded – undo
421	421	*
422	422	* @access public
423	423	* @param string the table name
424		- * @return object
	424	+ * @return string
425	425	*/
426	426	function _field_data($table)
427	427	{
		@@ -447,7 +447,7 @@ discard block
		block discarded – undo
447	447	* The error message number
448	448	*
449	449	* @access private
450		- * @return integer
	450	+ * @return string
451	451	*/
452	452	function _error_number()
453	453	{
		@@ -507,7 +507,7 @@ discard block
		block discarded – undo
507	507	*
508	508	* @access public
509	509	* @param type
510		- * @return type
	510	+ * @return string
511	511	*/
512	512	function _from_tables($tables)
513	513	{

		@@ -372,7 +372,7 @@ discard block
		block discarded – undo
372	372	*
373	373	* @access public
374	374	* @param string
375		- * @return string
	375	+ * @return integer
376	376	*/
377	377	function count_all($table = '')
378	378	{
		@@ -441,7 +441,7 @@ discard block
		block discarded – undo
441	441	*
442	442	* @access public
443	443	* @param string the table name
444		- * @return object
	444	+ * @return string
445	445	*/
446	446	function _field_data($table)
447	447	{
		@@ -526,7 +526,7 @@ discard block
		block discarded – undo
526	526	*
527	527	* @access public
528	528	* @param type
529		- * @return type
	529	+ * @return string
530	530	*/
531	531	function _from_tables($tables)
532	532	{

		@@ -130,7 +130,7 @@
		block discarded – undo
130	130	* result set starts at zero
131	131	*
132	132	* @access private
133		- * @return array
	133	+ * @return boolean
134	134	*/
135	135	function _data_seek($n = 0)
136	136	{

		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	* List databases
29	29	*
30	30	* @access private
31		- * @return array
	31	+ * @return string\|false
32	32	*/
33	33	function _list_databases()
34	34	{
		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	*
57	57	* @access private
58	58	* @param string the table name
59		- * @return object
	59	+ * @return boolean
60	60	* @link http://www.cubrid.org/manual/840/en/Optimize%20Database
61	61	*/
62	62	function _optimize_table($table)
		@@ -76,7 +76,7 @@ discard block
		block discarded – undo
76	76	*
77	77	* @access private
78	78	* @param string the table name
79		- * @return object
	79	+ * @return boolean
80	80	* @link http://www.cubrid.org/manual/840/en/Checking%20Database%20Consistency
81	81	*/
82	82	function _repair_table($table)

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	*
30	30	* @access private
31	31	* @param string the database name
32		- * @return bool
	32	+ * @return string
33	33	*/
34	34	function _create_database($name)
35	35	{
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	*
44	44	* @access private
45	45	* @param string the database name
46		- * @return bool
	46	+ * @return string
47	47	*/
48	48	function _drop_database($name)
49	49	{
		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	* Drop Table
57	57	*
58	58	* @access private
59		- * @return bool
	59	+ * @return string
60	60	*/
61	61	function _drop_table($table)
62	62	{
		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	* @param mixed primary key(s)
75	75	* @param mixed key(s)
76	76	* @param boolean should 'IF NOT EXISTS' be added to the SQL
77		- * @return bool
	77	+ * @return string
78	78	*/
79	79	function _create_table($table, $fields, $primary_keys, $keys, $if_not_exists)
80	80	{
		@@ -186,7 +186,7 @@ discard block
		block discarded – undo
186	186	* @param string the default value
187	187	* @param boolean should 'NOT NULL' be added
188	188	* @param string the field after which we should add the new field
189		- * @return object
	189	+ * @return string
190	190	*/
191	191	function _alter_table($alter_type, $table, $column_name, $column_definition = '', $default_value = '', $null = '', $after_field = '')
192	192	{

		@@ -125,7 +125,7 @@
		block discarded – undo
125	125	* result set starts at zero
126	126	*
127	127	* @access private
128		- * @return array
	128	+ * @return boolean
129	129	*/
130	130	function _data_seek($n = 0)
131	131	{

iNextrix / ASTPP

Branch — v3.0 (3d1631)

Category

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch