Inspection of "Merge pull request #290 from ketan-kothari/patch-1" - iNextrix/ASTPP - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — v3.5 (f0ef26)

by Samir

created 2017-12-26 10:30 UTC

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -25,19 +25,19 @@
 block discarded – undo
 	function __construct()
 	{
 	parent::__construct();
-	if(!defined( 'CRON' ) )  
+	if ( ! defined('CRON'))  
 	  exit();
 		$this->load->model("db_model");
 		$this->load->library("astpp/common");
 	}
-	function low_creditlimit(){
-		$where = array("posttoexternal"=>1,"deleted" => "0","status"=>"0");
+	function low_creditlimit() {
+		$where = array("posttoexternal"=>1, "deleted" => "0", "status"=>"0");
 		$query = $this->db_model->getSelect("*", "accounts", $where);
-		if($query->num_rows >0){
+		if ($query->num_rows > 0) {
 			$account_data = $query->result_array();
-			foreach($account_data as $data_key =>$account_value){
-				if(($account_value["balance"]) >= $account_value["credit_limit"]){
-				  $this->common->mail_to_users("email_low_balance",$account_value);   
+			foreach ($account_data as $data_key =>$account_value) {
+				if (($account_value["balance"]) >= $account_value["credit_limit"]) {
+				  $this->common->mail_to_users("email_low_balance", $account_value);   
 				}
 			}
 		}

Please login to merge, or discard this patch.

astpp/application/libraries/html2pdf/_tcpdf_5.0.002/qrcode.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -180,12 +180,12 @@  discard block
 block discarded – undo
 	/**
 	 * Matrix index to get width from $capacity array.
 	 */
-	define('QRCAP_WIDTH',    0);
+	define('QRCAP_WIDTH', 0);
 
 	/**
 	 * Matrix index to get number of words from $capacity array.
 	 */
-	define('QRCAP_WORDS',    1);
+	define('QRCAP_WORDS', 1);
 
 	/**
 	 * Matrix index to get remainder from $capacity array.
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
 	/**
 	 * Matrix index to get error correction level from $capacity array.
 	 */
-	define('QRCAP_EC',       3);
+	define('QRCAP_EC', 3);
 
 	// -----------------------------------------------------
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
 	/**
 	 * Number of header bits for structured mode
 	 */
-	define('STRUCTURE_HEADER_BITS',  20);
+	define('STRUCTURE_HEADER_BITS', 20);
 
 	/**
 	 * Max number of symbols for structured mode
@@ -218,12 +218,12 @@  discard block
 block discarded – undo
 	/**
 	 * Down point base value for case 1 mask pattern (concatenation of same color in a line or a column)
 	 */
-	define('N1',  3);
+	define('N1', 3);
 
 	/**
 	 * Down point base value for case 2 mask pattern (module block of same color)
 	 */
-	define('N2',  3);
+	define('N2', 3);
 
 	/**
 	 * Down point base value for case 3 mask pattern (1:1:3:1:1(dark:bright:dark:bright:dark)pattern in a line or a column)
@@ -260,18 +260,18 @@  discard block
 block discarded – undo
 
 // #*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#
 
-if (!class_exists('QRcode', false)) {
+if ( ! class_exists('QRcode', false)) {
 
 	// for compaibility with PHP4
-	if (!function_exists('str_split')) {
+	if ( ! function_exists('str_split')) {
     	/**
     	 * Convert a string to an array (needed for PHP4 compatibility)
     	 * @param string $string The input string.
     	 * @param int $split_length Maximum length of the chunk.
     	 * @return  string[] the optional split_length  parameter is specified, the returned array will be broken down into chunks with each being split_length  in length, otherwise each chunk will be one character in length. FALSE is returned if split_length is less than 1. If the split_length length exceeds the length of string , the entire string is returned as the first (and only) array element.
     	 */
-		function str_split($string, $split_length=1) {
-			if ((strlen($string) > $split_length) OR (!$split_length)) {
+		function str_split($string, $split_length = 1) {
+			if ((strlen($string) > $split_length) OR ( ! $split_length)) {
 				do {
 					$c = strlen($string);
 					$parts[] = substr($string, 0, $split_length);

Please login to merge, or discard this patch.

application/libraries/html2pdf/_tcpdf_5.0.002/fonts/utils/makefont.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -533,9 +533,9 @@
 block discarded – undo
  * @param string $file
  * @param string $s
  */
-function SaveToFile($file, $s, $mode='t') {
+function SaveToFile($file, $s, $mode = 't') {
 	$f = fopen($file, 'w'.$mode);
-	if(!$f) {
+	if ( ! $f) {
 		die('Can\'t write to file '.$file);
 	}
 	fwrite($f, $s, strlen($s));

Please login to merge, or discard this patch.

web_interface/astpp/application/libraries/html2pdf/_class/locale.class.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 	 */
 	static public function load($code)
 	{
-		if (self::$_directory===null) {
+		if (self::$_directory === null) {
 			self::$_directory = dirname(dirname(__FILE__)).'/locale/';
 		}
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 		$code = strtolower($code);
 
 		// must be [a-z-0-9]
-		if (!preg_match('/^([a-z0-9]+)$/isU', $code)) {
+		if ( ! preg_match('/^([a-z0-9]+)$/isU', $code)) {
 			throw new HTML2PDF_exception(0, 'invalid language code ['.self::$_code.']');
 		}
 
@@ -56,16 +56,16 @@  discard block
 block discarded – undo
 		$file = self::$_directory.self::$_code.'.csv';
 
 		// the file must exist
-		if (!is_file($file)) {
+		if ( ! is_file($file)) {
 			throw new HTML2PDF_exception(0, 'language code ['.self::$_code.'] unknown. You can create the translation file ['.$file.'] and send it to the webmaster of html2pdf in order to integrate it into a future release');
 		}
 
 		// load the file
 		self::$_list = array();
 		$handle = fopen($file, 'r');
-		while (!feof($handle)) {
+		while ( ! feof($handle)) {
 			$line = fgetcsv($handle);
-			if (count($line)!=2) continue;
+			if (count($line) != 2) continue;
 			self::$_list[trim($line[0])] = trim($line[1]);
 		}
 		fclose($handle);
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
 	 * @param  string $key
 	 * @return string
 	 */
-	static public function get($key, $default='######')
+	static public function get($key, $default = '######')
 	{
 		return (isset(self::$_list[$key]) ? self::$_list[$key] : $default);
 	}

Please login to merge, or discard this patch.

astpp/application/libraries/html2pdf/_class/exception.class.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@  discard block
 block discarded – undo
 	final public function __construct($err = 0, $other = null, $html = '')
 	{
 		// read the error
-		switch($err)
+		switch ($err)
 		{
 			case 1: // Unsupported tag
 				$msg = (HTML2PDF_locale::get('err01'));
@@ -89,19 +89,19 @@  discard block
 block discarded – undo
 
 		// create the HTML message
 		$this->_messageHtml = '<span style="color: #AA0000; font-weight: bold;">'.HTML2PDF_locale::get('txt01', 'error: ').$err.'</span><br>';
-		$this->_messageHtml.= HTML2PDF_locale::get('txt02', 'file:').' '.$this->file.'<br>';
-		$this->_messageHtml.= HTML2PDF_locale::get('txt03', 'line:').' '.$this->line.'<br>';
-		$this->_messageHtml.= '<br>';
-		$this->_messageHtml.= $msg;
+		$this->_messageHtml .= HTML2PDF_locale::get('txt02', 'file:').' '.$this->file.'<br>';
+		$this->_messageHtml .= HTML2PDF_locale::get('txt03', 'line:').' '.$this->line.'<br>';
+		$this->_messageHtml .= '<br>';
+		$this->_messageHtml .= $msg;
 
 		// create the text message
 		$msg = HTML2PDF_locale::get('txt01', 'error: ').$err.' : '.strip_tags($msg);
 
 		// add the optionnal html content
 		if ($html) {
-			$this->_messageHtml.= "<br><br>HTML : ...".trim(htmlentities($html)).'...';
+			$this->_messageHtml .= "<br><br>HTML : ...".trim(htmlentities($html)).'...';
 			$this->_html = $html;
-			$msg.= ' HTML : ...'.trim($html).'...';
+			$msg .= ' HTML : ...'.trim($html).'...';
 		}
 
 		// save the other informations

Please login to merge, or discard this patch.

web_interface/astpp/application/libraries/html2pdf/_class/tcpdfConfig.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -32,23 +32,23 @@  discard block
 block discarded – undo
 
 // If you define the constant K_TCPDF_EXTERNAL_CONFIG, the following settings will be ignored.
 
-if (!defined('K_TCPDF_EXTERNAL_CONFIG')) {
+if ( ! defined('K_TCPDF_EXTERNAL_CONFIG')) {
 
 	define('K_TCPDF_EXTERNAL_CONFIG', true);
 
 	// DOCUMENT_ROOT fix for IIS Webserver
-	if ((!isset($_SERVER['DOCUMENT_ROOT'])) OR (empty($_SERVER['DOCUMENT_ROOT']))) {
+	if (( ! isset($_SERVER['DOCUMENT_ROOT'])) OR (empty($_SERVER['DOCUMENT_ROOT']))) {
 		if (isset($_SERVER['SCRIPT_FILENAME'])) {
 			$_SERVER['DOCUMENT_ROOT'] = str_replace(
 				'\\',
 				'/',
-				substr($_SERVER['SCRIPT_FILENAME'], 0, 0-strlen($_SERVER['PHP_SELF']))
+				substr($_SERVER['SCRIPT_FILENAME'], 0, 0 - strlen($_SERVER['PHP_SELF']))
 			);
 		} elseif (isset($_SERVER['PATH_TRANSLATED'])) {
 			$_SERVER['DOCUMENT_ROOT'] = str_replace(
 				'\\',
 				'/',
-				substr(str_replace('\\\\', '\\', $_SERVER['PATH_TRANSLATED']), 0, 0-strlen($_SERVER['PHP_SELF']))
+				substr(str_replace('\\\\', '\\', $_SERVER['PATH_TRANSLATED']), 0, 0 - strlen($_SERVER['PHP_SELF']))
 			);
 		} else {
 			// define here your DOCUMENT_ROOT path if the previous fails
@@ -59,12 +59,12 @@  discard block
 block discarded – undo
 	// Automatic calculation for the following K_PATH_MAIN constant
 	$kPathMain = str_replace('\\', '/', dirname(__FILE__));
 	$kPathMain = dirname($kPathMain).'/'; // remove the current directory
-	$kPathMain.= '_tcpdf_'.HTML2PDF_USED_TCPDF_VERSION.'/';
+	$kPathMain .= '_tcpdf_'.HTML2PDF_USED_TCPDF_VERSION.'/';
 	define('K_PATH_MAIN', $kPathMain);
 
 	// Automatic calculation for the following K_PATH_URL constant
-	if (isset($_SERVER['HTTP_HOST']) AND (!empty($_SERVER['HTTP_HOST']))) {
-		if (isset($_SERVER['HTTPS']) AND (!empty($_SERVER['HTTPS'])) AND strtolower($_SERVER['HTTPS'])!='off') {
+	if (isset($_SERVER['HTTP_HOST']) AND ( ! empty($_SERVER['HTTP_HOST']))) {
+		if (isset($_SERVER['HTTPS']) AND ( ! empty($_SERVER['HTTPS'])) AND strtolower($_SERVER['HTTPS']) != 'off') {
 			$kPathUrl = 'https://';
 		} else {
 			$kPathUrl = 'http://';
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
 	/**
 	 * reduction factor for small font
 	 */
-	define('K_SMALL_RATIO', 2/3);
+	define('K_SMALL_RATIO', 2 / 3);
 
 	/**
 	 * set to true to enable the special procedure used to avoid the overlappind of symbols on Thai language

Please login to merge, or discard this patch.

astpp/application/libraries/html2pdf/_class/parsingCss.class.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -484,7 +484,7 @@  discard block
 block discarded – undo
     {
         // prepare
         $tagName = strtolower($tagName);
-        $id   = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id)   $id   = null;
+        $id   = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id)   $id = null;
         $name = isset($param['name']) ? strtolower(trim($param['name'])) : null; if ( ! $name) $name = null;
 
         // read the class attribute
@@ -554,7 +554,7 @@  discard block
 block discarded – undo
     {
         // prepare the informations
         $tagName = strtolower($tagName);
-        $id   = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id)   $id   = null;
+        $id   = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id)   $id = null;
         $name = isset($param['name']) ? strtolower(trim($param['name'])) : null; if ( ! $name) $name = null;
 
         // get the class names to use

Please login to merge, or discard this patch.

web_interface/astpp/application/helpers/email_csv_helper.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@  discard block
 block discarded – undo
 }
 
 function create_csv_string($data) {
-	if (!$fp = fopen('php://temp', 'w+')) {
+	if ( ! $fp = fopen('php://temp', 'w+')) {
 		return FALSE;
 	}
 	foreach ($data as $line) {
@@ -13,13 +13,13 @@  discard block
 block discarded – undo
 	return stream_get_contents($fp);
 }
 
-function send_csv_mail ($csvData, $body, $to, $subject,$file_name) {
+function send_csv_mail($csvData, $body, $to, $subject, $file_name) {
 	//print_r($csvData);
 	$where = array('group_title' =>'email');
 		$query = $this->CI->db_model->getSelect("*", "system", $where);
 		$query = $query->result_array();
-	foreach($query as $key=>$val){
-		$from=$val['value'];
+	foreach ($query as $key=>$val) {
+		$from = $val['value'];
 	}
 	$multipartSep = '-----'.md5(time()).'-----';
 	$headers = array(

Please login to merge, or discard this patch.

astpp/application/modules/summary/views/view_resellersummary_report.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -38,18 +38,18 @@  discard block
 block discarded – undo
                                 <legend><b>Search</b></legend>
                                 <div class="col-md-4 no-padding">
                                     <label class="search_label col-md-12 no-padding">From Date</label>
-                                    <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][0]) ? $session_info['callstart'][0] : date("Y-m-d") . " 00:00:00"; ?>" id="reseller_from_date" size="20" class="col-md-5 form-control text field "  />
+                                    <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][0]) ? $session_info['callstart'][0] : date("Y-m-d")." 00:00:00"; ?>" id="reseller_from_date" size="20" class="col-md-5 form-control text field "  />
                                 </div>
                                 <div class="col-md-4 no-padding">
                                     <label class="search_label col-md-12 no-padding">To Date</label>
-                                    <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][1]) ? $session_info['callstart'][1] : date("Y-m-d") . " 23:59:59"; ?>" id="reseller_to_date" size="20" class="col-md-5 form-control text field "  />
+                                    <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][1]) ? $session_info['callstart'][1] : date("Y-m-d")." 23:59:59"; ?>" id="reseller_to_date" size="20" class="col-md-5 form-control text field "  />
                                 </div>
                                 <div class="col-md-4 no-padding">
                                     <label class="search_label col-md-12 no-padding">Account</label>
 
                                     <select name="accountid" class='col-md-5 form-control selectpicker' data-live-search='true'>
                                         <option value=''>--Select--</option>
-                                        <?php if (!empty($accountlist)) {
+                                        <?php if ( ! empty($accountlist)) {
 											foreach ($accountlist as $key => $value) {
 												?>
                                                 <optgroup label="<?php echo $key ?>">
@@ -71,13 +71,13 @@  discard block
 block discarded – undo
                                 </div>
                                 <div class="col-md-4 no-padding">
                                     <label class="search_label col-md-12 no-padding">Code </label>
-                                    <input type="text" name="pattern[pattern]" value="<?php echo (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && !empty($session_info['pattern']['pattern'])) ? $session_info['pattern']['pattern'] : ''; ?>" size="20" maxlength="15" class="col-md-5 form-control text field "/>
+                                    <input type="text" name="pattern[pattern]" value="<?php echo (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && ! empty($session_info['pattern']['pattern'])) ? $session_info['pattern']['pattern'] : ''; ?>" size="20" maxlength="15" class="col-md-5 form-control text field "/>
                                     <select name="pattern[pattern-string]" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
                                         <?php
-										if (!empty($search_string_type)) {
+										if ( ! empty($search_string_type)) {
 											foreach ($search_string_type as $key => $value) {
 												$selected = null;
-												if (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && !empty($session_info['pattern']['pattern']) && $session_info['pattern']['pattern-string'] == $key) {
+												if (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && ! empty($session_info['pattern']['pattern']) && $session_info['pattern']['pattern-string'] == $key) {
 													$selected = "selected";
 												}
 												?>
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
                                 </div>
                                 <div class="col-md-4 no-padding">
                                     <label class="search_label col-md-12 no-padding">Destination </label>
-                                    <input type="text" name="notes[notes]" value="<?php echo (isset($session_info['notes']) && isset($session_info['notes']['notes']) && !empty($session_info['notes']['notes'])) ? $session_info['notes']['notes'] : ''; ?>" size="20" class="col-md-5 form-control text field "  />
+                                    <input type="text" name="notes[notes]" value="<?php echo (isset($session_info['notes']) && isset($session_info['notes']['notes']) && ! empty($session_info['notes']['notes'])) ? $session_info['notes']['notes'] : ''; ?>" size="20" class="col-md-5 form-control text field "  />
                                     <select name="notes[notes-string]" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
                                         <?php
-										if (!empty($search_string_type)) {
+										if ( ! empty($search_string_type)) {
 											foreach ($search_string_type as $key => $value) {
 												$selected = null;
-												if (isset($session_info['notes']) && isset($session_info['notes']['notes']) && !empty($session_info['notes']['notes']) && $session_info['notes']['notes-string'] == $key) {
+												if (isset($session_info['notes']) && isset($session_info['notes']['notes']) && ! empty($session_info['notes']['notes']) && $session_info['notes']['notes-string'] == $key) {
 													$selected = "selected";
 												}
 												?>
@@ -120,10 +120,10 @@  discard block
 block discarded – undo
                                     <label class="search_label col-md-12 no-padding">Group By #time</label>
                                     <select name="time" class='col-md-5 form-control' style='margin-left:5px; selectpicker' data-live-search='true'>
                                         <?php
-										if (!empty($groupby_time)) {
+										if ( ! empty($groupby_time)) {
 											foreach ($groupby_time as $key => $value) {
 												$selected = null;
-												if (isset($session_info['time']) && !empty($session_info['time']) && $session_info['time'] == $key) {
+												if (isset($session_info['time']) && ! empty($session_info['time']) && $session_info['time'] == $key) {
 													$selected = "selected";
 												}
 												?>
@@ -137,10 +137,10 @@  discard block
 block discarded – undo
                                     <label class="search_label col-md-12 no-padding">Group By #1</label>
                                     <select name="groupby_1" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
                                     <?php
-									if (!empty($groupby_field)) {
+									if ( ! empty($groupby_field)) {
 										foreach ($groupby_field as $key => $value) {
 											$selected = null;
-											if (isset($session_info['groupby_1']) && !empty($session_info['groupby_1']) && $session_info['groupby_1'] == $key) {
+											if (isset($session_info['groupby_1']) && ! empty($session_info['groupby_1']) && $session_info['groupby_1'] == $key) {
 												$selected = "selected";
 											}
 											?>
@@ -154,10 +154,10 @@  discard block
 block discarded – undo
                                     <label class="search_label col-md-12 no-padding">Group By #2</label>
                                     <select name="groupby_2" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
                                         <?php
-										if (!empty($groupby_field)) {
+										if ( ! empty($groupby_field)) {
 											foreach ($groupby_field as $key => $value) {
 												$selected = null;
-												if (isset($session_info['groupby_2']) && !empty($session_info['groupby_2']) && $session_info['groupby_2'] == $key) {
+												if (isset($session_info['groupby_2']) && ! empty($session_info['groupby_2']) && $session_info['groupby_2'] == $key) {
 													$selected = "selected";
 												}
 												?>
@@ -171,10 +171,10 @@  discard block
 block discarded – undo
                                     <label class="search_label col-md-12 no-padding">Group By #3</label>
                                     <select name="groupby_3" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
                                     <?php
-									if (!empty($groupby_field)) {
+									if ( ! empty($groupby_field)) {
 										foreach ($groupby_field as $key => $value) {
 											$selected = null;
-											if (isset($session_info['groupby_3']) && !empty($session_info['groupby_3']) && $session_info['groupby_3'] == $key) {
+											if (isset($session_info['groupby_3']) && ! empty($session_info['groupby_3']) && $session_info['groupby_3'] == $key) {
 												$selected = "selected";
 											}
 											?>
@@ -193,10 +193,10 @@  discard block
 block discarded – undo
                                     <label class="search_label col-md-6" style="font-size:17px;text-align:right;">Display records in </label>
                                     <select name="search_in" class='col-md-5 form-control selectpicker' style='background: #ddd; width: 23% !important;' data-live-search='true'>
 <?php
-if (!empty($search_report)) {
+if ( ! empty($search_report)) {
 	foreach ($search_report as $key => $value) {
 		$selected = null;
-		if (isset($session_info['search_in']) && isset($session_info['search_in']) && !empty($session_info['search_in']) && $session_info['search_in'] == $key) {
+		if (isset($session_info['search_in']) && isset($session_info['search_in']) && ! empty($session_info['search_in']) && $session_info['search_in'] == $key) {
 			//echo $key;exit;
 			$selected = "selected";
 		}

Please login to merge, or discard this patch.

		@@ -180,12 +180,12 @@ discard block
		block discarded – undo
180	180	/**
181	181	* Matrix index to get width from $capacity array.
182	182	*/
183		- define('QRCAP_WIDTH', 0);
	183	+ define('QRCAP_WIDTH', 0);
184	184
185	185	/**
186	186	* Matrix index to get number of words from $capacity array.
187	187	*/
188		- define('QRCAP_WORDS', 1);
	188	+ define('QRCAP_WORDS', 1);
189	189
190	190	/**
191	191	* Matrix index to get remainder from $capacity array.
		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	/**
196	196	* Matrix index to get error correction level from $capacity array.
197	197	*/
198		- define('QRCAP_EC', 3);
	198	+ define('QRCAP_EC', 3);
199	199
200	200	// -----------------------------------------------------
201	201
		@@ -204,7 +204,7 @@ discard block
		block discarded – undo
204	204	/**
205	205	* Number of header bits for structured mode
206	206	*/
207		- define('STRUCTURE_HEADER_BITS', 20);
	207	+ define('STRUCTURE_HEADER_BITS', 20);
208	208
209	209	/**
210	210	* Max number of symbols for structured mode
		@@ -218,12 +218,12 @@ discard block
		block discarded – undo
218	218	/**
219	219	* Down point base value for case 1 mask pattern (concatenation of same color in a line or a column)
220	220	*/
221		- define('N1', 3);
	221	+ define('N1', 3);
222	222
223	223	/**
224	224	* Down point base value for case 2 mask pattern (module block of same color)
225	225	*/
226		- define('N2', 3);
	226	+ define('N2', 3);
227	227
228	228	/**
229	229	* Down point base value for case 3 mask pattern (1:1:3:1:1(dark:bright:dark:bright:dark)pattern in a line or a column)
		@@ -260,18 +260,18 @@ discard block
		block discarded – undo
260	260
261	261	// #############################
262	262
263		-if (!class_exists('QRcode', false)) {
	263	+if ( ! class_exists('QRcode', false)) {
264	264
265	265	// for compaibility with PHP4
266		- if (!function_exists('str_split')) {
	266	+ if ( ! function_exists('str_split')) {
267	267	/**
268	268	* Convert a string to an array (needed for PHP4 compatibility)
269	269	* @param string $string The input string.
270	270	* @param int $split_length Maximum length of the chunk.
271	271	* @return string[] the optional split_length parameter is specified, the returned array will be broken down into chunks with each being split_length in length, otherwise each chunk will be one character in length. FALSE is returned if split_length is less than 1. If the split_length length exceeds the length of string , the entire string is returned as the first (and only) array element.
272	272	*/
273		- function str_split($string, $split_length=1) {
274		- if ((strlen($string) > $split_length) OR (!$split_length)) {
	273	+ function str_split($string, $split_length = 1) {
	274	+ if ((strlen($string) > $split_length) OR ( ! $split_length)) {
275	275	do {
276	276	$c = strlen($string);
277	277	$parts[] = substr($string, 0, $split_length);

		@@ -533,9 +533,9 @@
		block discarded – undo
533	533	* @param string $file
534	534	* @param string $s
535	535	*/
536		-function SaveToFile($file, $s, $mode='t') {
	536	+function SaveToFile($file, $s, $mode = 't') {
537	537	$f = fopen($file, 'w'.$mode);
538		- if(!$f) {
	538	+ if ( ! $f) {
539	539	die('Can\'t write to file '.$file);
540	540	}
541	541	fwrite($f, $s, strlen($s));

		@@ -484,7 +484,7 @@ discard block
		block discarded – undo
484	484	{
485	485	// prepare
486	486	$tagName = strtolower($tagName);
487		- $id = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id) $id = null;
	487	+ $id = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id) $id = null;
488	488	$name = isset($param['name']) ? strtolower(trim($param['name'])) : null; if ( ! $name) $name = null;
489	489
490	490	// read the class attribute
		@@ -554,7 +554,7 @@ discard block
		block discarded – undo
554	554	{
555	555	// prepare the informations
556	556	$tagName = strtolower($tagName);
557		- $id = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id) $id = null;
	557	+ $id = isset($param['id']) ? strtolower(trim($param['id'])) : null; if ( ! $id) $id = null;
558	558	$name = isset($param['name']) ? strtolower(trim($param['name'])) : null; if ( ! $name) $name = null;
559	559
560	560	// get the class names to use

		@@ -25,19 +25,19 @@
		block discarded – undo
25	25	function __construct()
26	26	{
27	27	parent::__construct();
28		- if(!defined( 'CRON' ) )
	28	+ if ( ! defined('CRON'))
29	29	exit();
30	30	$this->load->model("db_model");
31	31	$this->load->library("astpp/common");
32	32	}
33		- function low_creditlimit(){
34		- $where = array("posttoexternal"=>1,"deleted" => "0","status"=>"0");
	33	+ function low_creditlimit() {
	34	+ $where = array("posttoexternal"=>1, "deleted" => "0", "status"=>"0");
35	35	$query = $this->db_model->getSelect("*", "accounts", $where);
36		- if($query->num_rows >0){
	36	+ if ($query->num_rows > 0) {
37	37	$account_data = $query->result_array();
38		- foreach($account_data as $data_key =>$account_value){
39		- if(($account_value["balance"]) >= $account_value["credit_limit"]){
40		- $this->common->mail_to_users("email_low_balance",$account_value);
	38	+ foreach ($account_data as $data_key =>$account_value) {
	39	+ if (($account_value["balance"]) >= $account_value["credit_limit"]) {
	40	+ $this->common->mail_to_users("email_low_balance", $account_value);
41	41	}
42	42	}
43	43	}

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37	*/
38	38	static public function load($code)
39	39	{
40		- if (self::$_directory===null) {
	40	+ if (self::$_directory === null) {
41	41	self::$_directory = dirname(dirname(__FILE__)).'/locale/';
42	42	}
43	43
		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	$code = strtolower($code);
46	46
47	47	// must be [a-z-0-9]
48		- if (!preg_match('/^([a-z0-9]+)$/isU', $code)) {
	48	+ if ( ! preg_match('/^([a-z0-9]+)$/isU', $code)) {
49	49	throw new HTML2PDF_exception(0, 'invalid language code ['.self::$_code.']');
50	50	}
51	51
		@@ -56,16 +56,16 @@ discard block
		block discarded – undo
56	56	$file = self::$_directory.self::$_code.'.csv';
57	57
58	58	// the file must exist
59		- if (!is_file($file)) {
	59	+ if ( ! is_file($file)) {
60	60	throw new HTML2PDF_exception(0, 'language code ['.self::$_code.'] unknown. You can create the translation file ['.$file.'] and send it to the webmaster of html2pdf in order to integrate it into a future release');
61	61	}
62	62
63	63	// load the file
64	64	self::$_list = array();
65	65	$handle = fopen($file, 'r');
66		- while (!feof($handle)) {
	66	+ while ( ! feof($handle)) {
67	67	$line = fgetcsv($handle);
68		- if (count($line)!=2) continue;
	68	+ if (count($line) != 2) continue;
69	69	self::$_list[trim($line[0])] = trim($line[1]);
70	70	}
71	71	fclose($handle);
		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89	* @param string $key
90	90	* @return string
91	91	*/
92		- static public function get($key, $default='######')
	92	+ static public function get($key, $default = '######')
93	93	{
94	94	return (isset(self::$_list[$key]) ? self::$_list[$key] : $default);
95	95	}

		@@ -27,7 +27,7 @@ discard block
		block discarded – undo
27	27	final public function __construct($err = 0, $other = null, $html = '')
28	28	{
29	29	// read the error
30		- switch($err)
	30	+ switch ($err)
31	31	{
32	32	case 1: // Unsupported tag
33	33	$msg = (HTML2PDF_locale::get('err01'));
		@@ -89,19 +89,19 @@ discard block
		block discarded – undo
89	89
90	90	// create the HTML message
91	91	$this->_messageHtml = '<span style="color: #AA0000; font-weight: bold;">'.HTML2PDF_locale::get('txt01', 'error: ').$err.'</span><br>';
92		- $this->_messageHtml.= HTML2PDF_locale::get('txt02', 'file:').' '.$this->file.'<br>';
93		- $this->_messageHtml.= HTML2PDF_locale::get('txt03', 'line:').' '.$this->line.'<br>';
94		- $this->_messageHtml.= '<br>';
95		- $this->_messageHtml.= $msg;
	92	+ $this->_messageHtml .= HTML2PDF_locale::get('txt02', 'file:').' '.$this->file.'<br>';
	93	+ $this->_messageHtml .= HTML2PDF_locale::get('txt03', 'line:').' '.$this->line.'<br>';
	94	+ $this->_messageHtml .= '<br>';
	95	+ $this->_messageHtml .= $msg;
96	96
97	97	// create the text message
98	98	$msg = HTML2PDF_locale::get('txt01', 'error: ').$err.' : '.strip_tags($msg);
99	99
100	100	// add the optionnal html content
101	101	if ($html) {
102		- $this->_messageHtml.= "<br><br>HTML : ...".trim(htmlentities($html)).'...';
	102	+ $this->_messageHtml .= "<br><br>HTML : ...".trim(htmlentities($html)).'...';
103	103	$this->_html = $html;
104		- $msg.= ' HTML : ...'.trim($html).'...';
	104	+ $msg .= ' HTML : ...'.trim($html).'...';
105	105	}
106	106
107	107	// save the other informations

		@@ -32,23 +32,23 @@ discard block
		block discarded – undo
32	32
33	33	// If you define the constant K_TCPDF_EXTERNAL_CONFIG, the following settings will be ignored.
34	34
35		-if (!defined('K_TCPDF_EXTERNAL_CONFIG')) {
	35	+if ( ! defined('K_TCPDF_EXTERNAL_CONFIG')) {
36	36
37	37	define('K_TCPDF_EXTERNAL_CONFIG', true);
38	38
39	39	// DOCUMENT_ROOT fix for IIS Webserver
40		- if ((!isset($_SERVER['DOCUMENT_ROOT'])) OR (empty($_SERVER['DOCUMENT_ROOT']))) {
	40	+ if (( ! isset($_SERVER['DOCUMENT_ROOT'])) OR (empty($_SERVER['DOCUMENT_ROOT']))) {
41	41	if (isset($_SERVER['SCRIPT_FILENAME'])) {
42	42	$_SERVER['DOCUMENT_ROOT'] = str_replace(
43	43	'\\',
44	44	'/',
45		- substr($_SERVER['SCRIPT_FILENAME'], 0, 0-strlen($_SERVER['PHP_SELF']))
	45	+ substr($_SERVER['SCRIPT_FILENAME'], 0, 0 - strlen($_SERVER['PHP_SELF']))
46	46	);
47	47	} elseif (isset($_SERVER['PATH_TRANSLATED'])) {
48	48	$_SERVER['DOCUMENT_ROOT'] = str_replace(
49	49	'\\',
50	50	'/',
51		- substr(str_replace('\\\\', '\\', $_SERVER['PATH_TRANSLATED']), 0, 0-strlen($_SERVER['PHP_SELF']))
	51	+ substr(str_replace('\\\\', '\\', $_SERVER['PATH_TRANSLATED']), 0, 0 - strlen($_SERVER['PHP_SELF']))
52	52	);
53	53	} else {
54	54	// define here your DOCUMENT_ROOT path if the previous fails
		@@ -59,12 +59,12 @@ discard block
		block discarded – undo
59	59	// Automatic calculation for the following K_PATH_MAIN constant
60	60	$kPathMain = str_replace('\\', '/', dirname(__FILE__));
61	61	$kPathMain = dirname($kPathMain).'/'; // remove the current directory
62		- $kPathMain.= '_tcpdf_'.HTML2PDF_USED_TCPDF_VERSION.'/';
	62	+ $kPathMain .= '_tcpdf_'.HTML2PDF_USED_TCPDF_VERSION.'/';
63	63	define('K_PATH_MAIN', $kPathMain);
64	64
65	65	// Automatic calculation for the following K_PATH_URL constant
66		- if (isset($_SERVER['HTTP_HOST']) AND (!empty($_SERVER['HTTP_HOST']))) {
67		- if (isset($_SERVER['HTTPS']) AND (!empty($_SERVER['HTTPS'])) AND strtolower($_SERVER['HTTPS'])!='off') {
	66	+ if (isset($_SERVER['HTTP_HOST']) AND ( ! empty($_SERVER['HTTP_HOST']))) {
	67	+ if (isset($_SERVER['HTTPS']) AND ( ! empty($_SERVER['HTTPS'])) AND strtolower($_SERVER['HTTPS']) != 'off') {
68	68	$kPathUrl = 'https://';
69	69	} else {
70	70	$kPathUrl = 'http://';
		@@ -228,7 +228,7 @@ discard block
		block discarded – undo
228	228	/**
229	229	* reduction factor for small font
230	230	*/
231		- define('K_SMALL_RATIO', 2/3);
	231	+ define('K_SMALL_RATIO', 2 / 3);
232	232
233	233	/**
234	234	* set to true to enable the special procedure used to avoid the overlappind of symbols on Thai language

		@@ -3,7 +3,7 @@ discard block
		block discarded – undo
3	3	}
4	4
5	5	function create_csv_string($data) {
6		- if (!$fp = fopen('php://temp', 'w+')) {
	6	+ if ( ! $fp = fopen('php://temp', 'w+')) {
7	7	return FALSE;
8	8	}
9	9	foreach ($data as $line) {
		@@ -13,13 +13,13 @@ discard block
		block discarded – undo
13	13	return stream_get_contents($fp);
14	14	}
15	15
16		-function send_csv_mail ($csvData, $body, $to, $subject,$file_name) {
	16	+function send_csv_mail($csvData, $body, $to, $subject, $file_name) {
17	17	//print_r($csvData);
18	18	$where = array('group_title' =>'email');
19	19	$query = $this->CI->db_model->getSelect("*", "system", $where);
20	20	$query = $query->result_array();
21		- foreach($query as $key=>$val){
22		- $from=$val['value'];
	21	+ foreach ($query as $key=>$val) {
	22	+ $from = $val['value'];
23	23	}
24	24	$multipartSep = '-----'.md5(time()).'-----';
25	25	$headers = array(

		@@ -38,18 +38,18 @@ discard block
		block discarded – undo
38	38	<legend><b>Search</b></legend>
39	39	<div class="col-md-4 no-padding">
40	40	<label class="search_label col-md-12 no-padding">From Date</label>
41		- <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][0]) ? $session_info['callstart'][0] : date("Y-m-d") . " 00:00:00"; ?>" id="reseller_from_date" size="20" class="col-md-5 form-control text field " />
	41	+ <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][0]) ? $session_info['callstart'][0] : date("Y-m-d")." 00:00:00"; ?>" id="reseller_from_date" size="20" class="col-md-5 form-control text field " />
42	42	</div>
43	43	<div class="col-md-4 no-padding">
44	44	<label class="search_label col-md-12 no-padding">To Date</label>
45		- <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][1]) ? $session_info['callstart'][1] : date("Y-m-d") . " 23:59:59"; ?>" id="reseller_to_date" size="20" class="col-md-5 form-control text field " />
	45	+ <input type="text" name="callstart[]" value="<?php echo isset($session_info['callstart'][1]) ? $session_info['callstart'][1] : date("Y-m-d")." 23:59:59"; ?>" id="reseller_to_date" size="20" class="col-md-5 form-control text field " />
46	46	</div>
47	47	<div class="col-md-4 no-padding">
48	48	<label class="search_label col-md-12 no-padding">Account</label>
49	49
50	50	<select name="accountid" class='col-md-5 form-control selectpicker' data-live-search='true'>
51	51	<option value=''>--Select--</option>
52		- <?php if (!empty($accountlist)) {
	52	+ <?php if ( ! empty($accountlist)) {
53	53	foreach ($accountlist as $key => $value) {
54	54	?>
55	55	<optgroup label="<?php echo $key ?>">
		@@ -71,13 +71,13 @@ discard block
		block discarded – undo
71	71	</div>
72	72	<div class="col-md-4 no-padding">
73	73	<label class="search_label col-md-12 no-padding">Code </label>
74		- <input type="text" name="pattern[pattern]" value="<?php echo (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && !empty($session_info['pattern']['pattern'])) ? $session_info['pattern']['pattern'] : ''; ?>" size="20" maxlength="15" class="col-md-5 form-control text field "/>
	74	+ <input type="text" name="pattern[pattern]" value="<?php echo (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && ! empty($session_info['pattern']['pattern'])) ? $session_info['pattern']['pattern'] : ''; ?>" size="20" maxlength="15" class="col-md-5 form-control text field "/>
75	75	<select name="pattern[pattern-string]" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
76	76	<?php
77		- if (!empty($search_string_type)) {
	77	+ if ( ! empty($search_string_type)) {
78	78	foreach ($search_string_type as $key => $value) {
79	79	$selected = null;
80		- if (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && !empty($session_info['pattern']['pattern']) && $session_info['pattern']['pattern-string'] == $key) {
	80	+ if (isset($session_info['pattern']) && isset($session_info['pattern']['pattern']) && ! empty($session_info['pattern']['pattern']) && $session_info['pattern']['pattern-string'] == $key) {
81	81	$selected = "selected";
82	82	}
83	83	?>
		@@ -89,13 +89,13 @@ discard block
		block discarded – undo
89	89	</div>
90	90	<div class="col-md-4 no-padding">
91	91	<label class="search_label col-md-12 no-padding">Destination </label>
92		- <input type="text" name="notes[notes]" value="<?php echo (isset($session_info['notes']) && isset($session_info['notes']['notes']) && !empty($session_info['notes']['notes'])) ? $session_info['notes']['notes'] : ''; ?>" size="20" class="col-md-5 form-control text field " />
	92	+ <input type="text" name="notes[notes]" value="<?php echo (isset($session_info['notes']) && isset($session_info['notes']['notes']) && ! empty($session_info['notes']['notes'])) ? $session_info['notes']['notes'] : ''; ?>" size="20" class="col-md-5 form-control text field " />
93	93	<select name="notes[notes-string]" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
94	94	<?php
95		- if (!empty($search_string_type)) {
	95	+ if ( ! empty($search_string_type)) {
96	96	foreach ($search_string_type as $key => $value) {
97	97	$selected = null;
98		- if (isset($session_info['notes']) && isset($session_info['notes']['notes']) && !empty($session_info['notes']['notes']) && $session_info['notes']['notes-string'] == $key) {
	98	+ if (isset($session_info['notes']) && isset($session_info['notes']['notes']) && ! empty($session_info['notes']['notes']) && $session_info['notes']['notes-string'] == $key) {
99	99	$selected = "selected";
100	100	}
101	101	?>
		@@ -120,10 +120,10 @@ discard block
		block discarded – undo
120	120	<label class="search_label col-md-12 no-padding">Group By #time</label>
121	121	<select name="time" class='col-md-5 form-control' style='margin-left:5px; selectpicker' data-live-search='true'>
122	122	<?php
123		- if (!empty($groupby_time)) {
	123	+ if ( ! empty($groupby_time)) {
124	124	foreach ($groupby_time as $key => $value) {
125	125	$selected = null;
126		- if (isset($session_info['time']) && !empty($session_info['time']) && $session_info['time'] == $key) {
	126	+ if (isset($session_info['time']) && ! empty($session_info['time']) && $session_info['time'] == $key) {
127	127	$selected = "selected";
128	128	}
129	129	?>
		@@ -137,10 +137,10 @@ discard block
		block discarded – undo
137	137	<label class="search_label col-md-12 no-padding">Group By #1</label>
138	138	<select name="groupby_1" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
139	139	<?php
140		- if (!empty($groupby_field)) {
	140	+ if ( ! empty($groupby_field)) {
141	141	foreach ($groupby_field as $key => $value) {
142	142	$selected = null;
143		- if (isset($session_info['groupby_1']) && !empty($session_info['groupby_1']) && $session_info['groupby_1'] == $key) {
	143	+ if (isset($session_info['groupby_1']) && ! empty($session_info['groupby_1']) && $session_info['groupby_1'] == $key) {
144	144	$selected = "selected";
145	145	}
146	146	?>
		@@ -154,10 +154,10 @@ discard block
		block discarded – undo
154	154	<label class="search_label col-md-12 no-padding">Group By #2</label>
155	155	<select name="groupby_2" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
156	156	<?php
157		- if (!empty($groupby_field)) {
	157	+ if ( ! empty($groupby_field)) {
158	158	foreach ($groupby_field as $key => $value) {
159	159	$selected = null;
160		- if (isset($session_info['groupby_2']) && !empty($session_info['groupby_2']) && $session_info['groupby_2'] == $key) {
	160	+ if (isset($session_info['groupby_2']) && ! empty($session_info['groupby_2']) && $session_info['groupby_2'] == $key) {
161	161	$selected = "selected";
162	162	}
163	163	?>
		@@ -171,10 +171,10 @@ discard block
		block discarded – undo
171	171	<label class="search_label col-md-12 no-padding">Group By #3</label>
172	172	<select name="groupby_3" class='col-md-5 form-control selectpicker' style='margin-left:5px;' data-live-search='true'>
173	173	<?php
174		- if (!empty($groupby_field)) {
	174	+ if ( ! empty($groupby_field)) {
175	175	foreach ($groupby_field as $key => $value) {
176	176	$selected = null;
177		- if (isset($session_info['groupby_3']) && !empty($session_info['groupby_3']) && $session_info['groupby_3'] == $key) {
	177	+ if (isset($session_info['groupby_3']) && ! empty($session_info['groupby_3']) && $session_info['groupby_3'] == $key) {
178	178	$selected = "selected";
179	179	}
180	180	?>
		@@ -193,10 +193,10 @@ discard block
		block discarded – undo
193	193	<label class="search_label col-md-6" style="font-size:17px;text-align:right;">Display records in </label>
194	194	<select name="search_in" class='col-md-5 form-control selectpicker' style='background: #ddd; width: 23% !important;' data-live-search='true'>
195	195	<?php
196		-if (!empty($search_report)) {
	196	+if ( ! empty($search_report)) {
197	197	foreach ($search_report as $key => $value) {
198	198	$selected = null;
199		- if (isset($session_info['search_in']) && isset($session_info['search_in']) && !empty($session_info['search_in']) && $session_info['search_in'] == $key) {
	199	+ if (isset($session_info['search_in']) && isset($session_info['search_in']) && ! empty($session_info['search_in']) && $session_info['search_in'] == $key) {
200	200	//echo $key;exit;
201	201	$selected = "selected";
202	202	}

iNextrix / ASTPP

Branch — v3.5 (f0ef26)

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch