Inspection of "Merge pull request #290 from ketan-kothari/patch-1" - iNextrix/ASTPP - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — v3.5 (f0ef26)

by Samir

created 2017-12-26 10:30 UTC

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -6,17 +6,17 @@  discard block
 block discarded – undo
 <meta http-equiv="X-UA-Compatible" content="IE=edge">   
 <title>
 	<?php       
-        $this->db->where('domain',$_SERVER['HTTP_HOST']);
+        $this->db->where('domain', $_SERVER['HTTP_HOST']);
         $this->db->select('*');
         $this->db->order_by('accountid', 'desc');
         $this->db->limit(1);
         $invoiceconf = $this->db->get('invoice_conf');
         $invoiceconf = (array)$invoiceconf->first_row();
-	if(isset($invoiceconf['website_title']) && $invoiceconf['website_title']!='') {
+	if (isset($invoiceconf['website_title']) && $invoiceconf['website_title'] != '') {
 	?>
 	Forgot Password | <?php echo $invoiceconf['website_title']; ?>
 	<?php
-		}else{ 
+		} else { 
 	?>
 	Forgot Password | ASTPP - Open Source Voip Billing Solution
 	<?php
@@ -69,18 +69,18 @@  discard block
 block discarded – undo
              <div class="w-box dark sign-in-wr box_shadow margin-b-10">
 		    	<div class="col-md-12 no-padding">
 			  <?php
-					if(isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != ""){
+					if (isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != "") {
 						$logo = $this->session->userdata['user_logo'];
-					}else{
+					} else {
 						$logo = 'logo.png';
 					}
 
 					if ($this->session->userdata('userlevel_logintype') != '0') {?>
 						<a class="col-md-9" style="padding:0px 0px 10px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 					<? } else {?> 
 							<a class="col-md-9" style="padding:0px 0px 20px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 					<? }?>	
 			
 				</a>

Please login to merge, or discard this patch.

astpp/application/modules/signup/views/view_signup_inactive.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -6,17 +6,17 @@  discard block
 block discarded – undo
 <meta http-equiv="X-UA-Compatible" content="IE=edge">    
 <title>
 	<?php       
-        $this->db->where('domain',$_SERVER['HTTP_HOST']);
+        $this->db->where('domain', $_SERVER['HTTP_HOST']);
         $this->db->select('*');
         $this->db->order_by('accountid', 'desc');
         $this->db->limit(1);
         $invoiceconf = $this->db->get('invoice_conf');
         $invoiceconf = (array)$invoiceconf->first_row();
-	if(isset($invoiceconf['website_title']) && $invoiceconf['website_title']!='') {
+	if (isset($invoiceconf['website_title']) && $invoiceconf['website_title'] != '') {
 	?>
 	Signup | <?php echo $invoiceconf['website_title']; ?>
 	<?php
-		}else{ 
+		} else { 
 	?>
 	Signup | ASTPP - Open Source Voip Billing Solution
 	<?php
@@ -70,18 +70,18 @@  discard block
 block discarded – undo
              <div class="w-box dark sign-in-wr box_shadow margin-b-10">
 		    	<div class="col-md-12 no-padding">
 					  <?php
-						if(isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != ""){
+						if (isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != "") {
 						$logo = $this->session->userdata['user_logo'];
-						}else{
+						} else {
 						$logo = 'logo.png';
 						}
 
 						if ($this->session->userdata('userlevel_logintype') != '0') {?>
 						<a class="col-md-12" style="padding:0px 0px 10px 0px" href="<?php echo base_url(); ?>">
-						<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+						<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 						<? } else {?> 
 						<a class="col-md-12" style="padding:0px 0px 20px 0px" href="<?php echo base_url(); ?>">
-						<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+						<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 						<? }?>	
 						</a>
 

Please login to merge, or discard this patch.

web_interface/astpp/application/modules/signup/views/view_signup_active.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -6,17 +6,17 @@  discard block
 block discarded – undo
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <title>
 	<?php       
-        $this->db->where('domain',$_SERVER['HTTP_HOST']);
+        $this->db->where('domain', $_SERVER['HTTP_HOST']);
         $this->db->select('*');
         $this->db->order_by('accountid', 'desc');
         $this->db->limit(1);
         $invoiceconf = $this->db->get('invoice_conf');
         $invoiceconf = (array)$invoiceconf->first_row();
-	if(isset($invoiceconf['website_title']) && $invoiceconf['website_title']!='') {
+	if (isset($invoiceconf['website_title']) && $invoiceconf['website_title'] != '') {
 	?>
 	Signup | <?php echo $invoiceconf['website_title']; ?>
 	<?php
-		}else{ 
+		} else { 
 	?>
 	Signup | ASTPP - Open Source Voip Billing Solution
 	<?php
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
             <div class="row">
 
 			<div class="col-md-4 col-md-offset-4">&nbsp;<span class="login_error">
-                        <?php if (isset($astpp_notification)){ ?>
+                        <?php if (isset($astpp_notification)) { ?>
                         Login unsuccessful. Please make sure you entered the correct username and password, and that your account is active.
-                    <?php }else{
+                    <?php } else {
 						 echo "&nbsp;";
 					} 
 			$astpp_err_msg = $this->session->flashdata('astpp_signupmsg');
@@ -76,18 +76,18 @@  discard block
 block discarded – undo
                           <div class="">
                           <div class="col-md-9">
                            	<?php
-							if(isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != ""){
+							if (isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != "") {
 							$logo = $this->session->userdata['user_logo'];
-							}else{
+							} else {
 							$logo = 'logo.png';
 							}
 
 							if ($this->session->userdata('userlevel_logintype') != '0') {?>
 							<a class="col-md-12" style="padding:0px 0px 10px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 							<? } else {?> 
 							<a class="col-md-12" style="padding:0px 0px 20px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 							<? }?>	
                             	</a>
                            </div>

Please login to merge, or discard this patch.

astpp/application/modules/signup/views/view_signup_success.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -6,17 +6,17 @@  discard block
 block discarded – undo
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <title>
 	<?php       
-        $this->db->where('domain',$_SERVER['HTTP_HOST']);
+        $this->db->where('domain', $_SERVER['HTTP_HOST']);
         $this->db->select('*');
         $this->db->order_by('accountid', 'desc');
         $this->db->limit(1);
         $invoiceconf = $this->db->get('invoice_conf');
         $invoiceconf = (array)$invoiceconf->first_row();
-	if(isset($invoiceconf['website_title']) && $invoiceconf['website_title']!='') {
+	if (isset($invoiceconf['website_title']) && $invoiceconf['website_title'] != '') {
 	?>
 	Signup | <?php echo $invoiceconf['website_title']; ?>
 	<?php
-		}else{ 
+		} else { 
 	?>
 	Signup | ASTPP - Open Source Voip Billing Solution
 	<?php
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
             <div class="row">
 
 			<div class="col-md-4 col-md-offset-4">&nbsp;<span class="login_error">
-                        <?php if (isset($astpp_notification)){ ?>
+                        <?php if (isset($astpp_notification)) { ?>
                         Login unsuccessful. Please make sure you entered the correct username and password, and that your account is active.
-                    <?php }else{
+                    <?php } else {
 						 echo "&nbsp;";
 					} 
 			$astpp_err_msg = $this->session->flashdata('astpp_signupmsg');
@@ -75,18 +75,18 @@  discard block
 block discarded – undo
                           
                             	
                             	<?php
-							if(isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != ""){
+							if (isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != "") {
 							$logo = $this->session->userdata['user_logo'];
-							}else{
+							} else {
 							$logo = 'logo.png';
 							}
 
 							if ($this->session->userdata('userlevel_logintype') != '0') {?>
 							<a class="col-md-12" style="padding:0px 0px 10px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 							<? } else {?> 
 							<a class="col-md-12" style="padding:0px 0px 20px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 							<? }?>	
                             	</a>
                             	<div class="col-md-12 no-padding"></div>

Please login to merge, or discard this patch.

astpp/application/modules/signup/views/view_forgot_success.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -6,17 +6,17 @@  discard block
 block discarded – undo
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <title>
 	<?php       
-        $this->db->where('domain',$_SERVER['HTTP_HOST']);
+        $this->db->where('domain', $_SERVER['HTTP_HOST']);
         $this->db->select('*');
         $this->db->order_by('accountid', 'desc');
         $this->db->limit(1);
         $invoiceconf = $this->db->get('invoice_conf');
         $invoiceconf = (array)$invoiceconf->first_row();
-	if(isset($invoiceconf['website_title']) && $invoiceconf['website_title']!='') {
+	if (isset($invoiceconf['website_title']) && $invoiceconf['website_title'] != '') {
 	?>
 	Forgot Password | <?php echo $invoiceconf['website_title']; ?>
 	<?php
-		}else{ 
+		} else { 
 	?>
 	Forgot Password | ASTPP - Open Source Voip Billing Solution
 	<?php
@@ -55,9 +55,9 @@  discard block
 block discarded – undo
             <div class="row">
 
 			<div class="col-md-4 col-md-offset-4">&nbsp;<span class="login_error">
-                        <?php if (isset($astpp_notification)){ ?>
+                        <?php if (isset($astpp_notification)) { ?>
                         Login unsuccessful. Please make sure you entered the correct username and password, and that your account is active.
-                    <?php }else{
+                    <?php } else {
 						 echo "&nbsp;";
 					} 
 			$astpp_err_msg = $this->session->flashdata('astpp_signupmsg');
@@ -74,18 +74,18 @@  discard block
 block discarded – undo
                         	<h2 class="text-center">
                           
                             	<?php
-							if(isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != ""){
+							if (isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != "") {
 							$logo = $this->session->userdata['user_logo'];
-							}else{
+							} else {
 							$logo = 'logo.png';
 							}
 
 							if ($this->session->userdata('userlevel_logintype') != '0') {?>
 							<a class="col-md-12" style="padding:0px 0px 10px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 							<? } else {?> 
 							<a class="col-md-12" style="padding:0px 0px 20px 0px" href="<?php echo base_url(); ?>">
-							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
+							<img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
 							<? }?>	
                             	</a>
                             	<div class="col-md-12 no-padding"></div>

Please login to merge, or discard this patch.

web_interface/astpp/application/modules/email/views/view_email_brod.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -236,7 +236,7 @@
 block discarded – undo
  <div class="container">
  <form method="post" action="<?= base_url()?>email/email_client_get/" enctype="multipart/form-data" name="myform" id="myform" onsubmit="return(regvalidate())">
      <span  style="margin-left:10px; text-align: center;background-color: none;color:#DD191D;">
-                    <? if(isset($error) && !empty($error)) {
+                    <? if (isset($error) && ! empty($error)) {
 						echo $error;
 					}?>
                  </span>

Please login to merge, or discard this patch.

web_interface/astpp/application/modules/did/views/view_did_import.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -16,7 +16,7 @@
 block discarded – undo
               <div class="col-md-12">
             	<div class="w-box">
             	 <span  style="margin-left:10px; text-align: center;background-color: none;color:#1c8400;">
-                    <? if(isset($error) && !empty($error)) {
+                    <? if (isset($error) && ! empty($error)) {
 						echo $error;
 					}?>
                  </span>

Please login to merge, or discard this patch.

astpp/application/modules/user/views/view_user_invoices_config.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -206,13 +206,13 @@
 block discarded – undo
 				</div>
 		</div>	
 <?php
-	if($account_data['logo']  != ''){
-		 $logo=$account_data['file'];
-	}else{
-		 $logo=$account_data['logo'];
+	if ($account_data['logo'] != '') {
+		 $logo = $account_data['file'];
+	} else {
+		 $logo = $account_data['logo'];
 	}
-		  if($logo != ''){        
-			 $file_name= base_url()."upload/$logo";
+		  if ($logo != '') {        
+			 $file_name = base_url()."upload/$logo";
 ?>
 
 		<div class='col-md-12 no-padding'>

Please login to merge, or discard this patch.

web_interface/astpp/application/modules/invoices/views/view_invoiceconf.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@
 block discarded – undo
         <div class="w-section inverse no-padding">
             <?php echo $form; ?>
             <?php
-			if(isset($validation_errors) && $validation_errors != ''){ ?>
+			if (isset($validation_errors) && $validation_errors != '') { ?>
                 <script>
                 var ERR_STR = '<?php echo $validation_errors; ?>';
                 print_error(ERR_STR);

Please login to merge, or discard this patch.

		@@ -6,17 +6,17 @@ discard block
		block discarded – undo
6	6	<meta http-equiv="X-UA-Compatible" content="IE=edge">
7	7	<title>
8	8	<?php
9		- $this->db->where('domain',$_SERVER['HTTP_HOST']);
	9	+ $this->db->where('domain', $_SERVER['HTTP_HOST']);
10	10	$this->db->select('*');
11	11	$this->db->order_by('accountid', 'desc');
12	12	$this->db->limit(1);
13	13	$invoiceconf = $this->db->get('invoice_conf');
14	14	$invoiceconf = (array)$invoiceconf->first_row();
15		- if(isset($invoiceconf['website_title']) && $invoiceconf['website_title']!='') {
	15	+ if (isset($invoiceconf['website_title']) && $invoiceconf['website_title'] != '') {
16	16	?>
17	17	Forgot Password \| <?php echo $invoiceconf['website_title']; ?>
18	18	<?php
19		- }else{
	19	+ } else {
20	20	?>
21	21	Forgot Password \| ASTPP - Open Source Voip Billing Solution
22	22	<?php
		@@ -69,18 +69,18 @@ discard block
		block discarded – undo
69	69	<div class="w-box dark sign-in-wr box_shadow margin-b-10">
70	70	<div class="col-md-12 no-padding">
71	71	<?php
72		- if(isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != ""){
	72	+ if (isset($this->session->userdata['user_logo']) && $this->session->userdata['user_logo'] != "") {
73	73	$logo = $this->session->userdata['user_logo'];
74		- }else{
	74	+ } else {
75	75	$logo = 'logo.png';
76	76	}
77	77
78	78	if ($this->session->userdata('userlevel_logintype') != '0') {?>
79	79	<a class="col-md-9" style="padding:0px 0px 10px 0px" href="<?php echo base_url(); ?>">
80		- <img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
	80	+ <img style="height: 44px; width:216px;" id="logo" alt="dashboard" src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
81	81	<? } else {?>
82	82	<a class="col-md-9" style="padding:0px 0px 20px 0px" href="<?php echo base_url(); ?>">
83		- <img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo;?>">
	83	+ <img style="height: 44px; width:216px;" id="logo" title='ASTPP - Open Source Voip Billing Solution' alt='ASTPP - Open Source Voip Billing Solution' src="<?php echo base_url(); ?>upload/<?php echo$logo; ?>">
84	84	<? }?>
85	85
86	86	</a>

		@@ -236,7 +236,7 @@
		block discarded – undo
236	236	<div class="container">
237	237	<form method="post" action="<?= base_url()?>email/email_client_get/" enctype="multipart/form-data" name="myform" id="myform" onsubmit="return(regvalidate())">
238	238	<span style="margin-left:10px; text-align: center;background-color: none;color:#DD191D;">
239		- <? if(isset($error) && !empty($error)) {
	239	+ <? if (isset($error) && ! empty($error)) {
240	240	echo $error;
241	241	}?>
242	242	</span>

		@@ -16,7 +16,7 @@
		block discarded – undo
16	16	<div class="col-md-12">
17	17	<div class="w-box">
18	18	<span style="margin-left:10px; text-align: center;background-color: none;color:#1c8400;">
19		- <? if(isset($error) && !empty($error)) {
	19	+ <? if (isset($error) && ! empty($error)) {
20	20	echo $error;
21	21	}?>
22	22	</span>

		@@ -206,13 +206,13 @@
		block discarded – undo
206	206	</div>
207	207	</div>
208	208	<?php
209		- if($account_data['logo'] != ''){
210		- $logo=$account_data['file'];
211		- }else{
212		- $logo=$account_data['logo'];
	209	+ if ($account_data['logo'] != '') {
	210	+ $logo = $account_data['file'];
	211	+ } else {
	212	+ $logo = $account_data['logo'];
213	213	}
214		- if($logo != ''){
215		- $file_name= base_url()."upload/$logo";
	214	+ if ($logo != '') {
	215	+ $file_name = base_url()."upload/$logo";
216	216	?>
217	217
218	218	<div class='col-md-12 no-padding'>

		@@ -13,7 +13,7 @@
		block discarded – undo
13	13	<div class="w-section inverse no-padding">
14	14	<?php echo $form; ?>
15	15	<?php
16		- if(isset($validation_errors) && $validation_errors != ''){ ?>
	16	+ if (isset($validation_errors) && $validation_errors != '') { ?>
17	17	<script>
18	18	var ERR_STR = '<?php echo $validation_errors; ?>';
19	19	print_error(ERR_STR);

iNextrix / ASTPP

Branch — v3.5 (f0ef26)

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch