Conditions | 127 |
Paths | > 20000 |
Total Lines | 291 |
Code Lines | 204 |
Lines | 68 |
Ratio | 23.37 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
91 | function build_form($fields_array, $values) { |
||
92 | $form_contents = ''; |
||
93 | $form_contents .= '<div class="pop_md col-md-12 margin-t-10 padding-x-8">'; |
||
94 | if (isset($fields_array['breadcrumb'])) { |
||
95 | $form_contents .= form_breadcrumb($fields_array['breadcrumb']); |
||
96 | unset($fields_array['breadcrumb']); |
||
97 | } |
||
98 | $form_contents .= form_open($fields_array['forms'][0], $fields_array['forms'][1]); |
||
99 | unset($fields_array['forms']); |
||
100 | $button_array = array(); |
||
101 | if (isset($fields_array['button_save']) || isset($fields_array['button_cancel']) || isset($fields_array['additional_button'])) { |
||
102 | $save = $fields_array['button_save']; |
||
103 | unset($fields_array['button_save']); |
||
104 | if (isset($fields_array['button_cancel'])) { |
||
105 | $cancel = $fields_array['button_cancel']; |
||
106 | unset($fields_array['button_cancel']); |
||
107 | } |
||
108 | if (isset($fields_array['additional_button'])) { |
||
109 | $additiopnal_button = $fields_array['additional_button']; |
||
110 | unset($fields_array['additional_button']); |
||
111 | } |
||
112 | } |
||
113 | if (isset($additiopnal_button)) { |
||
114 | $form_contents .= form_button(gettext($additiopnal_button)); |
||
115 | } |
||
116 | $i = 0; |
||
117 | foreach ($fields_array as $fieldset_key => $form_fileds) { |
||
118 | if (count($fields_array) > 1) { |
||
119 | if ($i == 1 || $i == 3) { |
||
120 | $form_contents .= '<div class="col-md-6 no-padding pull-right">'; |
||
121 | $form_contents .= '<div class="col-md-12 padding-x-4">'; |
||
122 | } else { |
||
123 | $form_contents .= '<div class="col-md-6 no-padding">'; |
||
124 | $form_contents .= '<div class="col-md-12 padding-x-4">'; |
||
125 | } |
||
126 | } else { |
||
127 | $form_contents .= '<div class="col-md-12 no-padding">'; |
||
128 | $form_contents .= '<div class="col-md-12 no-padding">'; |
||
129 | } |
||
130 | $form_contents .= '<ul class="no-padding">'; |
||
131 | $form_contents .= '<div class="col-md-12 no-padding">'; |
||
132 | if ($i == 1 || $i == 3) { |
||
133 | $form_contents .= form_fieldset(gettext($fieldset_key)); |
||
134 | } else { |
||
135 | $form_contents .= form_fieldset(gettext($fieldset_key)); |
||
136 | } |
||
137 | foreach ($form_fileds as $fieldkey => $fieldvalue) { |
||
138 | $form_contents .= '<li class="col-md-12">'; |
||
139 | if ($fieldvalue[1] == 'HIDDEN') { |
||
140 | View Code Duplication | if (isset($this->CI->input->post)) |
|
141 | $fieldvalue[2]['value'] = ( ! $this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']); |
||
142 | else |
||
143 | $fieldvalue[2]['value'] = ($values) ? (isset($values[$fieldvalue[2]['name']]) ? $values[$fieldvalue[2]['name']] : '') : (isset($fieldvalue[2]['value']) ? $fieldvalue[2]['value'] : ''); |
||
144 | $form_contents .= form_hidden($fieldvalue[2]['name'], $fieldvalue[2]['value']); |
||
145 | } else { |
||
146 | $validation_arr = array(); |
||
147 | if ($fieldvalue[1] == 'INPUT') { |
||
148 | if ( ! empty($fieldvalue[3])) { |
||
149 | $validation_arr = explode("|", $fieldvalue[3]); |
||
150 | } |
||
151 | } |
||
152 | elseif ($fieldvalue[2] == 'SELECT') { |
||
153 | |||
154 | if (is_array($fieldvalue[4])) { |
||
155 | $validation_arr = explode("|", $fieldvalue[4]['rules']); |
||
156 | } else { |
||
157 | $validation_arr = explode("|", $fieldvalue[4]); |
||
158 | } |
||
159 | } |
||
160 | if ( ! empty($validation_arr)) { |
||
161 | $fieldvalue[0] = in_array('required', $validation_arr) ? $fieldvalue[0]."<span style='color:black;'> *</span>" : $fieldvalue[0]; |
||
162 | $fieldvalue[0] = in_array('dropdown', $validation_arr) ? $fieldvalue[0]."<span style='color:black;'> *</span>" : $fieldvalue[0]; |
||
163 | } |
||
164 | |||
165 | if (is_array($fieldvalue[1]) || (is_array($fieldvalue[2]) && isset($fieldvalue[2]['hidden']))) { |
||
166 | $form_contents .= form_label(gettext($fieldvalue[0]), $fieldvalue[0], array('class' => 'col-md-3 no-padding add_settings')); |
||
167 | } else { |
||
168 | $form_contents .= form_label(gettext($fieldvalue[0]), "", array("class" => "col-md-3 no-padding")); |
||
169 | } |
||
170 | } |
||
171 | if ($fieldvalue[2] == 'SELECT' && ! isset($fieldvalue[13])) { |
||
172 | |||
173 | /* |
||
174 | To make Drop down enabled disabled |
||
175 | */ |
||
176 | $extra = isset($fieldvalue[1]['extra']) ? $fieldvalue[1]['extra'] : ''; |
||
177 | /***************************/ |
||
178 | if ($fieldvalue[7] != '' && $fieldvalue[8] != '') { |
||
179 | $str = $fieldvalue[7].",".$fieldvalue[8]; |
||
180 | |||
181 | View Code Duplication | if (isset($this->CI->input->post)) { |
|
182 | $fieldvalue['value'] = ( ! $this->CI->input->post($fieldvalue[1])) ? @$fieldvalue[1] : $this->CI->input->post($fieldvalue[1]); |
||
183 | } else { |
||
184 | if (is_array($fieldvalue[1])) { |
||
185 | $fieldvalue['value'] = ($values) ? @$values[$fieldvalue[1]['name']] : @$fieldvalue[1]; |
||
186 | } else { |
||
187 | $fieldvalue['value'] = ($values) ? @$values[$fieldvalue[1]] : @$fieldvalue[1]; |
||
188 | } |
||
189 | } |
||
190 | $drp_array = call_user_func_array(array($this->CI->db_model, $fieldvalue[10]), array($str, $fieldvalue[9], $fieldvalue[11], $fieldvalue[12])); |
||
191 | |||
192 | if ($fieldset_key == gettext('System Configuration Information') || ($fieldset_key == 'Billing Information' && $fieldvalue[0] == 'Force Trunk') || ($fieldset_key == 'Card Information' && $fieldvalue[0] == 'Rate Group') || ($fieldset_key == 'Billing Information' && $fieldvalue[0] == 'Account') || $fieldset_key == 'Freeswitch Devices' && $fieldvalue[0] == 'Rate Group' || ($fieldset_key== 'Origination Rate Add/Edit' && $fieldvalue[0] == 'Trunks' )||$fieldset_key== 'Billing Information' && $fieldvalue[0] == 'Rate Group' || ($fieldset_key== 'Information' && $fieldvalue[0] == 'Failover GW Name #1') || ($fieldset_key== 'Information' && $fieldvalue[0] == 'Failover GW Name #2') || ($fieldset_key== 'Information' && $fieldvalue[0] == 'Rate Group') || ($fieldset_key== 'Sip Devices' && $fieldvalue[0] == 'Sip Profile') || ($fieldset_key== 'Sip Devices' && $fieldvalue[0] == 'Account')) { |
||
193 | $form_contents.=form_dropdown_all($fieldvalue[1], $drp_array, $fieldvalue['value'],$extra); |
||
194 | } else { |
||
195 | $form_contents.=form_dropdown($fieldvalue[1], $drp_array, $fieldvalue['value'], $extra); |
||
196 | } |
||
197 | if(isset($fieldvalue[4]) && $fieldvalue[4] != ''){ |
||
198 | if(is_array($fieldvalue[4])){ |
||
199 | |||
200 | View Code Duplication | if(isset($fieldvalue[1]['name'])){ |
|
201 | $fieldvalue_pass=$fieldvalue[1]['name']; |
||
202 | }else{ |
||
203 | $fieldvalue_pass=$fieldvalue[1]; |
||
204 | } |
||
205 | |||
206 | $this->CI->form_validation->set_rules($fieldvalue_pass, $fieldvalue[0], $fieldvalue[4]['rules']); |
||
207 | }else{ |
||
208 | |||
209 | View Code Duplication | if(isset($fieldvalue[1]['name'])){ |
|
210 | $fieldvalue_pass=$fieldvalue[1]['name']; |
||
211 | }else{ |
||
212 | $fieldvalue_pass=$fieldvalue[1]; |
||
213 | } |
||
214 | |||
215 | $this->CI->form_validation->set_rules($fieldvalue_pass, $fieldvalue[0], $fieldvalue[4]); |
||
216 | } |
||
217 | } |
||
218 | $form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.(is_array($fieldvalue[1])?$fieldvalue[1]['name']:$fieldvalue[1]).'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>'; |
||
219 | $form_contents.= '<span class="popup_error error no-padding" id="'.(gettext(is_array($fieldvalue[1])?$fieldvalue[1]['name']:$fieldvalue[1])).'_error"> |
||
220 | </span></div>'; |
||
221 | } else { |
||
222 | View Code Duplication | if (isset($this->CI->input->post)) { |
|
223 | $fieldvalue['value'] = (!$this->CI->input->post($fieldvalue[1])) ? @$fieldvalue[1] : $this->CI->input->post($fieldvalue[1]); |
||
224 | } else { |
||
225 | if (is_array($fieldvalue[1])) { |
||
226 | $fieldvalue['value'] = ($values) ? @$values[$fieldvalue[1]['name']] : @$fieldvalue[1]; |
||
227 | } else { |
||
228 | $fieldvalue['value'] = ($values) ? @$values[$fieldvalue[1]] : @$fieldvalue[1]; |
||
229 | } |
||
230 | } |
||
231 | |||
232 | $str = $fieldvalue[7] . "," . $fieldvalue[8]; |
||
233 | $drp_array = call_user_func_array(array($this->CI->common, $fieldvalue[10]), array($fieldvalue[9])); |
||
234 | $form_contents.=form_dropdown($fieldvalue[1], $drp_array, $fieldvalue['value'],$extra); |
||
235 | View Code Duplication | if(isset($fieldvalue[4]) && $fieldvalue[4] != ''){ |
|
236 | $this->CI->form_validation->set_rules($fieldvalue[1], $fieldvalue[0], $fieldvalue[4]); |
||
237 | } |
||
238 | $form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.(is_array($fieldvalue[1])?$fieldvalue[1]['name']:$fieldvalue[1]).'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>'; |
||
239 | $form_contents.= '<span class="popup_error error no-padding" id="'.(is_array($fieldvalue[1])?$fieldvalue[1]['name']:$fieldvalue[1]).'_error"> |
||
240 | </span></div>'; |
||
241 | } |
||
242 | } else if (isset($fieldvalue[13]) && $fieldvalue[13] != '') { |
||
243 | |||
244 | /* For multi select code */ |
||
245 | $str = $fieldvalue[7] . "," . $fieldvalue[8]; |
||
246 | |||
247 | if (isset($this->CI->input->post)) |
||
248 | $fieldvalue['value'] = (!$this->CI->input->post($fieldvalue[1])) ? @$fieldvalue[1] : $this->CI->input->post($fieldvalue[1]); |
||
249 | else |
||
250 | $fieldvalue['value'] = ($values) ? @$values[$fieldvalue[1]] : @$fieldvalue[1]; |
||
251 | |||
252 | $drp_array = call_user_func_array(array($this->CI->db_model, $fieldvalue[10]), array($str, $fieldvalue[9], $fieldvalue[11], $fieldvalue[12])); |
||
253 | if ($fieldset_key === 'System Configuration Information') { |
||
254 | $form_contents.=form_dropdown_multiselect($fieldvalue[1], $drp_array, ''); |
||
255 | } else { |
||
256 | $form_contents.=form_dropdown_multiselect($fieldvalue[1] . "[]", $drp_array, $fieldvalue['value']); |
||
257 | } |
||
258 | View Code Duplication | if(isset($fieldvalue[4]) && $fieldvalue[4] != ''){ |
|
259 | $this->CI->form_validation->set_rules($fieldvalue[1], $fieldvalue[0], $fieldvalue[4]); |
||
260 | } |
||
261 | $form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.$fieldvalue[1].'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>'; |
||
262 | $form_contents.= '<span class="popup_error error no-padding" id="'.$fieldvalue[1].'_error"></span></div>'; |
||
263 | /* End--------------------- For multi select code */ |
||
264 | } else if ($fieldvalue[1] == 'INPUT') { |
||
265 | |||
266 | |||
267 | View Code Duplication | if (isset($this->CI->input->post)) |
|
268 | $fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? $fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']); |
||
269 | else{ |
||
270 | $fieldvalue[2]['value'] = ($values) ? (isset($values[$fieldvalue[2]['name']]) ? $values[$fieldvalue[2]['name']] : ''):(isset($fieldvalue[2]['value']) ? $fieldvalue[2]['value'] :''); |
||
271 | } |
||
272 | $form_contents.= form_input($fieldvalue[2], 'readonly'); |
||
273 | if(isset($fieldvalue[6]) && !empty($fieldvalue[6])){ |
||
274 | $form_contents.=$fieldvalue[6]; |
||
275 | } |
||
276 | $this->CI->form_validation->set_rules($fieldvalue[2]['name'], $fieldvalue[0], $fieldvalue[3]); |
||
277 | $form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.$fieldvalue[2]['name'].'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>'; |
||
278 | $form_contents.= '<span class="popup_error error no-padding" id="'.$fieldvalue[2]['name'].'_error"> |
||
279 | </span></div>'; |
||
280 | } |
||
281 | /* |
||
282 | * Image upload from invoice configuration code. |
||
283 | */ |
||
284 | else if ($fieldvalue[1] == 'IMAGE') { |
||
285 | View Code Duplication | if (isset($this->CI->input->post)) |
|
286 | $fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']); |
||
287 | |||
288 | else |
||
289 | $fieldvalue[2]['value'] = ($values) ? @$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value']; |
||
290 | $fieldvalue[2]['style'] = isset($fieldvalue[2]['style']) ? $fieldvalue[2]['style'] : ""; |
||
291 | $form_contents.= form_image($fieldvalue[2], 'readonly',$fieldvalue[2]['style']); |
||
292 | $form_contents.=@$fieldvalue[6]; |
||
293 | $this->CI->form_validation->set_rules($fieldvalue[2]['name'], $fieldvalue[0], $fieldvalue[3]); |
||
294 | $form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.$fieldvalue[2]['name'].'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>'; |
||
295 | $form_contents.= '<span class="popup_error error no-padding" id="'.$fieldvalue[2]['name'].'_error"> |
||
296 | </span></div>'; |
||
297 | } |
||
298 | else if ($fieldvalue[1] == 'DEL_BUTTON') { |
||
299 | View Code Duplication | if (isset($this->CI->input->post)) |
|
300 | $fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']); |
||
301 | |||
302 | else |
||
303 | $fieldvalue[2]['value'] = ($values) ? @$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value']; |
||
304 | $fieldvalue[2]['style'] = isset($fieldvalue[2]['style']) ? $fieldvalue[2]['style'] : ""; |
||
305 | $form_contents.= form_img_delete($fieldvalue[2], 'readonly',$fieldvalue[2]['style']); |
||
306 | $form_contents.=@$fieldvalue[6]; |
||
307 | $this->CI->form_validation->set_rules($fieldvalue[2]['name'], $fieldvalue[0], $fieldvalue[3]); |
||
308 | $form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.$fieldvalue[2]['name'].'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>'; |
||
309 | $form_contents.= '<span class="popup_error error no-padding" id="'.$fieldvalue[2]['name'].'_error"> |
||
310 | </span></div>'; |
||
311 | } |
||
312 | /**********************************************************************************/ |
||
313 | else if ($fieldvalue[1] == 'PASSWORD') { |
||
314 | View Code Duplication | if (isset($this->CI->input->post)) |
|
315 | $fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']); |
||
316 | else |
||
317 | $fieldvalue[2]['value'] = ($values) ?@$values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value']; |
||
318 | $form_contents.= form_password($fieldvalue[2]); |
||
319 | $this->CI->form_validation->set_rules($fieldvalue[2]['name'], $fieldvalue[0], $fieldvalue[3]); |
||
320 | $form_contents.= '<div class="tooltips error_div pull-left no-padding" id="'.$fieldvalue[2]['name'].'_error_div" ><i style="color:#D95C5C; padding-left: 3px; padding-top: 10px;" class="fa fa-exclamation-triangle"></i>'; |
||
321 | $form_contents.= '<span class="popup_error error no-padding" id="'.$fieldvalue[2]['name'].'_error"> |
||
322 | </span></div>'; |
||
323 | } else if ($fieldvalue[2] == 'CHECKBOX') { |
||
324 | $OptionArray = array(); |
||
325 | |||
326 | if(isset($fieldvalue[7]) && $fieldvalue[7] != '') |
||
327 | $OptionArray = call_user_func_array(array($this->CI->common, $fieldvalue[7]), array($fieldvalue[6])); |
||
328 | View Code Duplication | if (isset($this->CI->input->post)){ |
|
329 | $fieldvalue[3]['value'] = (!$this->CI->input->post($fieldvalue[1])) ? @$fieldvalue[3]['value'] : $this->CI->input->post($fieldvalue[1]); |
||
330 | } |
||
331 | else |
||
332 | { |
||
333 | $fieldvalue[3]['value'] = ($values) ? (isset($values[$fieldvalue[1]]) && $values[$fieldvalue[1]] ? 1: 0) : @$fieldvalue[3]['value']; |
||
334 | } |
||
335 | if ($fieldvalue[3]['value'] == "1") { |
||
336 | $checked = true; |
||
337 | } else { |
||
338 | $checked = false; |
||
339 | }; |
||
340 | if(isset($fieldvalue[3]['table_name']) && $fieldvalue[3]['table_name'] != ""){ |
||
341 | |||
342 | $form_contents.= form_checkbox($fieldvalue[1], $fieldvalue[3]['value'],$checked , $OptionArray); |
||
343 | }else{ |
||
344 | $form_contents.= form_checkbox($fieldvalue[1], $fieldvalue[3]['value'],$checked ,$OptionArray); |
||
345 | } |
||
346 | } else if ($fieldvalue[1] == 'TEXTAREA') { |
||
347 | |||
348 | View Code Duplication | if (isset($this->CI->input->post)) |
|
349 | $fieldvalue[2]['value'] = (!$this->CI->input->post($fieldvalue[2]['name'])) ? @$fieldvalue[2]['value'] : $this->CI->input->post($fieldvalue[2]['name']); |
||
350 | else |
||
351 | $fieldvalue[2]['value'] = ($values) ? $values[$fieldvalue[2]['name']] : @$fieldvalue[2]['value']; |
||
352 | $form_contents.= form_textarea($fieldvalue[2]); |
||
353 | } |
||
354 | else if ($fieldvalue[2] == 'RADIO') { |
||
355 | |||
356 | $form_contents.= form_radio($fieldvalue[1], $fieldvalue[3]['value'], $fieldvalue[3]['checked']); |
||
357 | } |
||
358 | $form_contents.= '</li>'; |
||
359 | } |
||
360 | |||
361 | $form_contents.= '</ul>'; |
||
362 | $form_contents.= '</div>'; |
||
363 | $form_contents.= '</div>'; |
||
364 | $i++; |
||
365 | } |
||
366 | |||
367 | $form_contents.= '<center><div class="col-md-12 margin-t-20 margin-b-20">'; |
||
368 | |||
369 | $form_contents.= form_button($save); |
||
370 | |||
371 | if (isset($cancel)) { |
||
372 | $form_contents.= form_button($cancel); |
||
373 | } |
||
374 | $form_contents.= '</center></div>'; |
||
375 | $form_contents.= form_fieldset_close(); |
||
376 | $form_contents.= form_close(); |
||
377 | $form_contents.= '</div>'; |
||
378 | |||
379 | |||
380 | return $form_contents; |
||
381 | } |
||
382 | |||
752 |
An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.
If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.