Formatter::getField() - Code Metrics - Inspection of "Change return getFileds" - iMega/formatter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 74a34e...615178 )

by Dmitry

created 2016-11-10 06:16 UTC

Formatter::getField() A

↳ Parent: Formatter

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1
crap	2

<?php

namespace iMega\Formatter;

class Formatter
{
    protected $fields = [];

    public function __construct(array $meta)
    {
        foreach ($meta as $item) {
            if (empty($item) || !is_array($item)) {
                throw new FormatterException('Wrong type');
            }
            list($name, $default, $type, $error) = $item;
            if (0 !== $error) {
                throw new FormatterException('Wrong field name');
            }
            if (get_parent_class($type) == GenericType::class) {
                $this->fields[$name] = [$default, $type];
            } else {
                throw new FormatterException('Wrong instance');
            }
        }
    }

    public function getData($name, $value)
    {
        $type = $this->getType($name);
        try {
            return $type::getData($value);
        } catch (FormatterException $e) {
            return $type::getData($this->getDefaultValue($name));
        }
    }

    public function getValue($name, $value)
    {
        $type = $this->getType($name);
        try {
            return $type::getValue($value);
        } catch (FormatterException $e) {
            return $this->getDefaultValue($name);
        }
    }

    public function getDataCollection(array $values)
    {
        $ret = [];
        foreach ($this->getFileds() as $name) {
            if (array_key_exists($name, $values)) {
                $ret[$name] = $this->getData($name, $values[$name]);
            } else {
                $type = $this->getType($name);
                $ret[$name] = $type::getData($this->getDefaultValue($name));
            }
        }

        return $ret;
    }

    public function getValueCollection(array $values)
    {
        $ret = [];
        foreach ($this->getFileds() as $name) {
            if (array_key_exists($name, $values)) {
                $ret[$name] = $this->getValue($name, $values[$name]);
            } else {
                $ret[$name] = $this->getDefaultValue($name);
            }
        }

        return $ret;
    }

    /**
     * @return array
     */
    public function getFileds()
    {
        return array_keys($this->fields);
    }

    /**
     * @param string $name
     *
     * @return GenericType
     */
    protected function getField($name)
    {
        if (array_key_exists($name, $this->fields)) {
            return $this->fields[$name];
        } else {
            throw new FormatterException('Field not exists');
        }
    }

    protected function getDefaultValue($name)
    {
        list($default, $type) = $this->getField($name);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        return $default;
    }

    /**
     * @param $name
     *
     * @return \iMega\Formatter\Typer
     */
    protected function getType($name)
    {
        list($default, $type) = $this->getField($name);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

        return $type;
    }
}


1		<?php
2
3		namespace iMega\Formatter;
4
5		class Formatter
6		{
7		protected $fields = [];
8
9	34	public function __construct(array $meta)
10		{
11	34	foreach ($meta as $item) {
12	34	if (empty($item) \|\| !is_array($item)) {
13	4	throw new FormatterException('Wrong type');
14		}
15	30	list($name, $default, $type, $error) = $item;
16	30	if (0 !== $error) {
17	4	throw new FormatterException('Wrong field name');
18		}
19	26	if (get_parent_class($type) == GenericType::class) {
20	24	$this->fields[$name] = [$default, $type];
21	24	} else {
22	2	throw new FormatterException('Wrong instance');
23		}
24	24	}
25	24	}
26
27	12	public function getData($name, $value)
28		{
29	12	$type = $this->getType($name);
30		try {
31	10	return $type::getData($value);
32	2	} catch (FormatterException $e) {
33	2	return $type::getData($this->getDefaultValue($name));
34		}
35		}
36
37	10	public function getValue($name, $value)
38		{
39	10	$type = $this->getType($name);
40		try {
41	10	return $type::getValue($value);
42	2	} catch (FormatterException $e) {
43	2	return $this->getDefaultValue($name);
44		}
45		}
46
47	2	public function getDataCollection(array $values)
48		{
49	2	$ret = [];
50	2	foreach ($this->getFileds() as $name) {
51	2	if (array_key_exists($name, $values)) {
52	2	$ret[$name] = $this->getData($name, $values[$name]);
53	2	} else {
54	2	$type = $this->getType($name);
55	2	$ret[$name] = $type::getData($this->getDefaultValue($name));
56		}
57	2	}
58
59	2	return $ret;
60		}
61
62	2	public function getValueCollection(array $values)
63		{
64	2	$ret = [];
65	2	foreach ($this->getFileds() as $name) {
66	2	if (array_key_exists($name, $values)) {
67	2	$ret[$name] = $this->getValue($name, $values[$name]);
68	2	} else {
69	2	$ret[$name] = $this->getDefaultValue($name);
70		}
71	2	}
72
73	2	return $ret;
74		}
75
76		/**
77		* @return array
78		*/
79	4	public function getFileds()
80		{
81	4	return array_keys($this->fields);
82		}
83
84		/**
85		* @param string $name
86		*
87		* @return GenericType
88		*/
89	22	protected function getField($name)
90		{
91	22	if (array_key_exists($name, $this->fields)) {
92	20	return $this->fields[$name];
93		} else {
94	2	throw new FormatterException('Field not exists');
95		}
96		}
97
98	8	protected function getDefaultValue($name)
99		{
100	8	list($default, $type) = $this->getField($name);
		0 ignored issues – show Unused Code introduced 2016-11-07 19:01 UTC by Report Bug Copy Issue Report The assignment to `$type` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
101
102	8	return $default;
103		}
104
105		/**
106		* @param $name
107		*
108		* @return \iMega\Formatter\Typer
109		*/
110	22	protected function getType($name)
111		{
112	22	list($default, $type) = $this->getField($name);
		0 ignored issues – show Unused Code introduced 2016-11-07 19:01 UTC by Report Bug Copy Issue Report The assignment to `$default` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
113
114	20	return $type;
115		}
116		}
117

iMega / formatter

Push — master ( 74a34e...615178 )

Formatter::getField() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like