topic_preview_module::main() - Code Metrics - Inspection of "Fix no avatar concatenation" - iMattPro/topicpreview - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ec5717...657e76 )

by Matt

created 2016-06-11 17:14 UTC

topic_preview_module::main() A

↳ Parent: topic_preview_module

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes	7
Bugs	0	Features	2

Metric	Value
dl	0
loc	12
ccs	9
cts	9
cp	1
rs	9.4285
c	7
b	0
f	2
cc	1
eloc	8
nc	1
nop	2
crap	1

<?php
/**
*
* Topic Preview
*
* @copyright (c) 2013 Matt Friedman
* @license GNU General Public License, version 2 (GPL-2.0)
*
*/

namespace vse\topicpreview\acp;

/**
* @package acp
*/
class topic_preview_module
{
	/** @var string */
	public $u_action;

	/**
	 * Main ACP module
	 *
	 * @param int    $id
	 * @param string $mode
	 * @return null
	 */
	public function main($id, $mode)
	{
		global $phpbb_container;
function myFunction($a, $b) {
    // Do something
}

		$user = $phpbb_container->get('user');
		$this->tpl_name   = 'acp_topic_preview';
		$this->page_title = $user->lang('TOPIC_PREVIEW');

		$phpbb_container->get('vse.topicpreview.acp.controller')
			->set_u_action($this->u_action)
			->handle();
	}
}


Push — master ( ec5717...657e76 )

topic_preview_module::main() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2		/**
3		*
4		* Topic Preview
5		*
6		* @copyright (c) 2013 Matt Friedman
7		* @license GNU General Public License, version 2 (GPL-2.0)
8		*
9		*/
10
11		namespace vse\topicpreview\acp;
12
13		/**
14		* @package acp
15		*/
16		class topic_preview_module
17		{
18		/** @var string */
19		public $u_action;
20
21		/**
22		* Main ACP module
23		*
24		* @param int $id
25		* @param string $mode
26		* @return null
27		*/
28	1	public function main($id, $mode)
29		{
30	1	global $phpbb_container;
		1 ignored issue – show Compatibility Best Practice introduced 2016-06-11 17:22 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
31
32	1	$user = $phpbb_container->get('user');
33	1	$this->tpl_name = 'acp_topic_preview';
34	1	$this->page_title = $user->lang('TOPIC_PREVIEW');
35
36	1	$phpbb_container->get('vse.topicpreview.acp.controller')
37	1	->set_u_action($this->u_action)
38	1	->handle();
39	1	}
40		}
41

iMattPro / topicpreview

Push — master ( ec5717...657e76 )

topic_preview_module::main() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like