similar_topics_module::isset_or_default() - Code Metrics - Inspection of "PostgreSQL support" - iMattPro/similartopics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#25)

by Matt

created 2018-03-08 05:38 UTC

similar_topics_module::isset_or_default() A

↳ Parent: similar_topics_module

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	2
eloc	2
nc	2
nop	2

<?php
/**
 *
 * Precise Similar Topics
 *
 * @copyright (c) 2013 Matt Friedman
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace vse\similartopics\acp;

/**
 * @package acp
 */
class similar_topics_module
{
	/** @var \phpbb\cache\driver\driver_interface */
	protected $cache;

	/** @var \phpbb\config\config */
	protected $config;

	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var \vse\similartopics\driver\mysqli|\vse\similartopics\driver\postgres */
	protected $driver;

	/** @var \phpbb\log\log */
	protected $log;

	/** @var \phpbb\request\request */
	protected $request;

	/** @var \phpbb\template\template */
	protected $template;

	/** @var \phpbb\user */
	protected $user;

	/** @var string */
	protected $root_path;

	/** @var string */
	protected $php_ext;

	/** @var array */
	protected $times;

	/** @var string */
	public $page_title;

	/** @var string */
	public $tpl_name;

	/** @var string */
	public $u_action;

	/**
	 * ACP module constructor
	 *
	 * @access public
	 */
	public function __construct()
	{
		global $phpbb_container;

		$this->cache     = $phpbb_container->get('cache');
		$this->config    = $phpbb_container->get('config');
		$this->db        = $phpbb_container->get('dbal.conn');
		$this->driver    = $phpbb_container->get('vse.similartopics.driver.manager')->get_driver($this->db->get_sql_layer());
		$this->log       = $phpbb_container->get('log');
		$this->request   = $phpbb_container->get('request');
		$this->template  = $phpbb_container->get('template');
		$this->user      = $phpbb_container->get('user');
		$this->root_path = $phpbb_container->getParameter('core.root_path');
		$this->php_ext   = $phpbb_container->getParameter('core.php_ext');
		$this->times     = array(
			'd' => 86400, // one day
			'w' => 604800, // one week
			'm' => 2626560, // one month
			'y' => 31536000, // one year
		);
	}

	/**
	 * Main ACP module
	 *
	 * @access public
	 */
	public function main()
	{
		$this->user->add_lang_ext('vse/similartopics', 'acp_similar_topics');

		$this->tpl_name = 'acp_similar_topics';
		$this->page_title = $this->user->lang('PST_TITLE_ACP');

		$form_key = 'acp_similar_topics';
		add_form_key($form_key);

		$action = $this->request->variable('action', '');

		switch ($action)
		{
			case 'advanced':
				$forum_id = $this->request->variable('f', 0);

				if ($this->request->is_set_post('submit'))
				{
					$this->check_form_key($form_key);

					$similar_topic_forums = $this->request->variable('similar_forums_id', array(0));
					$similar_topic_forums = !empty($similar_topic_forums) ? json_encode($similar_topic_forums) : '';

					$sql = 'UPDATE ' . FORUMS_TABLE . "
						SET similar_topic_forums = '" . $this->db->sql_escape($similar_topic_forums) . "'
						WHERE forum_id = $forum_id";
					$this->db->sql_query($sql);

					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_MSG');

					$this->end('PST_SAVED');
				}

				$forum_name = '';
				$selected = array();
				if ($forum_id > 0)
				{
					$sql = 'SELECT forum_name, similar_topic_forums
						FROM ' . FORUMS_TABLE . "
						WHERE forum_id = $forum_id";
					$result = $this->db->sql_query($sql);
					while ($fid = $this->db->sql_fetchrow($result))
					{
						$selected = json_decode($fid['similar_topic_forums'], true);
						$forum_name = $fid['forum_name'];
					}
					$this->db->sql_freeresult($result);
				}

				$this->template->assign_vars(array(
					'S_ADVANCED_SETTINGS'		=> true,
					'SIMILAR_FORUMS_OPTIONS'	=> make_forum_select($selected, false, false, true),
					'PST_FORUM_NAME'			=> $forum_name,
					'PST_ADVANCED_EXP'			=> $this->user->lang('PST_ADVANCED_EXP', $forum_name),
					'U_ACTION'					=> $this->u_action . '&amp;action=advanced&amp;f=' . $forum_id,
					'U_BACK'					=> $this->u_action,
				));
			break;

			default:
				if ($this->request->is_set_post('submit'))
				{
					$this->check_form_key($form_key);

					// Set basic config settings
					$this->config->set('similar_topics', $this->request->variable('pst_enable', 0));
					$this->config->set('similar_topics_limit', abs($this->request->variable('pst_limit', 0))); // use abs for positive values only
					$this->config->set('similar_topics_cache', abs($this->request->variable('pst_cache', 0))); // use abs for positive values only
					$this->config->set('similar_topics_words', $this->request->variable('pst_words', '', true));

					// Set sensitivity
					$pst_sense = min(abs($this->request->variable('pst_sense', 5)), 10); // use abs for positive values only
					$this->config->set('similar_topics_sense', $pst_sense);

					// Set date/time config settings
					$pst_time = abs($this->request->variable('pst_time', 0)); // use abs for positive values only
					$pst_time_type = $this->request->variable('pst_time_type', '');
					$this->config->set('similar_topics_type', $pst_time_type);
					$this->config->set('similar_topics_time', $this->set_pst_time($pst_time, $pst_time_type));

					// Set checkbox array form data
					$this->update_forum('similar_topics_hide', $this->request->variable('mark_noshow_forum', array(0), true));
					$this->update_forum('similar_topics_ignore', $this->request->variable('mark_ignore_forum', array(0), true));

					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_MSG');

					$this->cache->destroy('sql', TOPICS_TABLE);

					$this->end('PST_SAVED');
				}

				// Allow option to update the mysql database to enable FULLTEXT support
				if ($this->request->is_set_post('fulltext'))
				{
					if (confirm_box(true))
					{
						// If FULLTEXT is not supported, lets make it so
						if ($this->driver->get_type() === 'mysql' && !$this->fulltext_support_enabled())
						{
							// Alter the database to support FULLTEXT
							$this->enable_mysql_fulltext_support();

							// Store the original database storage engine in a config var for recovery on uninstall
							$this->config->set('similar_topics_fulltext', (string) $this->driver->get_engine());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

							$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_FULLTEXT', time(), array(TOPICS_TABLE));

							$this->end('PST_SAVE_FULLTEXT');
						}
						$this->end('PST_ERR_FULLTEXT', E_USER_WARNING);
					}
					confirm_box(false, $this->user->lang('CONFIRM_OPERATION'), build_hidden_fields(array(
						'fulltext' => 1,
					)));
				}

				// Build the time options select menu
				$time_options = array(
					'd' => $this->user->lang('PST_DAYS'),
					'w' => $this->user->lang('PST_WEEKS'),
					'm' => $this->user->lang('PST_MONTHS'),
					'y' => $this->user->lang('PST_YEARS')
				);
				foreach ($time_options as $value => $label)
				{
					$this->template->assign_block_vars('similar_time_options', array(
						'VALUE'			=> $value,
						'LABEL'			=> $label,
						'S_SELECTED'	=> $value == $this->config['similar_topics_type'],
					));
				}

				$this->template->assign_vars(array(
					'S_PST_ENABLE'		=> $this->isset_or_default($this->config['similar_topics'], false),
					'PST_LIMIT'			=> $this->isset_or_default($this->config['similar_topics_limit'], ''),
					'PST_CACHE'			=> $this->isset_or_default($this->config['similar_topics_cache'], ''),
					'PST_SENSE'			=> $this->isset_or_default($this->config['similar_topics_sense'], ''),
					'PST_WORDS'			=> $this->isset_or_default($this->config['similar_topics_words'], ''),
					'PST_TIME'			=> $this->get_pst_time($this->config['similar_topics_time'], $this->config['similar_topics_type']),
					'S_PST_NO_SUPPORT'	=> $this->driver === null || !$this->fulltext_support_enabled(),
					'S_PST_NO_COMPAT'	=> $this->driver === null,
					'U_ACTION'			=> $this->u_action,
				));

				$forum_list = $this->get_forum_list();
				foreach ($forum_list as $row)
				{
					$this->template->assign_block_vars('forums', array(
						'FORUM_NAME'			=> $row['forum_name'],
						'FORUM_ID'				=> $row['forum_id'],
						'CHECKED_IGNORE_FORUM'	=> $row['similar_topics_ignore'] ? 'checked="checked"' : '',
						'CHECKED_NOSHOW_FORUM'	=> $row['similar_topics_hide'] ? 'checked="checked"' : '',
						'S_IS_ADVANCED'			=> (bool) $row['similar_topic_forums'],
						'U_ADVANCED'			=> "{$this->u_action}&amp;action=advanced&amp;f=" . $row['forum_id'],
						'U_FORUM'				=> append_sid("{$this->root_path}viewforum.{$this->php_ext}", 'f=' . $row['forum_id']),
					));
				}
			break;
		}
	}

	/**
	 * Check form key, trigger error if invalid
	 *
	 * @access protected
	 * @param string $form_key The form key value
	 */
	protected function check_form_key($form_key)
	{
		if (!check_form_key($form_key))
		{
			$this->end('FORM_INVALID', E_USER_WARNING);
		}
	}

	/**
	 * Get forums list
	 *
	 * @access protected
	 * @return array forum data rows
	 */
	protected function get_forum_list()
	{
		$sql = 'SELECT forum_id, forum_name, similar_topic_forums, similar_topics_hide, similar_topics_ignore
			FROM ' . FORUMS_TABLE . '
			WHERE forum_type = ' . FORUM_POST . '
			ORDER BY left_id ASC';
		$result = $this->db->sql_query($sql);
		$forum_list = $this->db->sql_fetchrowset($result);
		$this->db->sql_freeresult($result);

		return $forum_list;
	}

	/**
	 * Update the similar topics columns in the forums table
	 *
	 * @param string $column    The name of the column to update
	 * @param array  $forum_ids An array of forum_ids
	 */
	protected function update_forum($column, $forum_ids)
	{
		$this->db->sql_transaction('begin');

		// Set marked forums (in set) to 1
		$sql = 'UPDATE ' . FORUMS_TABLE . "
			SET $column = 1
			WHERE " . $this->db->sql_in_set('forum_id', $forum_ids, false, true);
		$this->db->sql_query($sql);

		// Set unmarked forums (not in set) to 0
		$sql = 'UPDATE ' . FORUMS_TABLE . "
			SET $column = 0
			WHERE " . $this->db->sql_in_set('forum_id', $forum_ids, true, true);
		$this->db->sql_query($sql);

		$this->db->sql_transaction('commit');
	}

	/**
	 * Calculate the time in seconds based on requested time period length
	 *
	 * @access protected
	 * @param int    $length user entered value
	 * @param string $type   years, months, weeks, days (y|m|w|d)
	 * @return int time in seconds
	 */
	protected function set_pst_time($length, $type = 'y')
	{
		$type = isset($this->times[$type]) ? $type : 'y';

		return (int) ($length * $this->times[$type]);
	}

	/**
	 * Get the correct time period length value for the form
	 *
	 * @access protected
	 * @param int    $time as a timestamp
	 * @param string $type years, months, weeks, days (y|m|w|d)
	 * @return int time converted to the given $type
	 */
	protected function get_pst_time($time, $type = '')
	{
		return isset($this->times[$type]) ? (int) round($time / $this->times[$type]) : 0;
	}

	/**
	 * Check for FULLTEXT index support
	 *
	 * @access protected
	 * @return bool True if FULLTEXT is fully supported, false otherwise
	 */
	protected function fulltext_support_enabled()
	{
		if ($this->driver->is_supported())
		{
			return $this->driver->is_index('topic_title');
		}

		return false;
	}

	/**
	 * Enable FULLTEXT support for the topic_title
	 *
	 * @access protected
	 */
	protected function enable_mysql_fulltext_support()
	{
		// Alter the storage engine
		$this->driver->alter_engine();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		// Create the FULLTEXT index
		$this->driver->create_fulltext_index('topic_title');
	}

	/**
	 * Return a variable if it is set, otherwise default
	 *
	 * @access protected
	 * @param mixed $var     The variable to test
	 * @param mixed $default The default value to use
	 * @return mixed The value of the variable if set, otherwise default value
	 */
	protected function isset_or_default($var, $default)
	{
		return null !== $var ? $var : $default;
	}

	/**
	 * End script execution with a trigger_error message
	 *
	 * @access protected
	 * @param string $message Language key string
	 * @param int    $code    E_USER_NOTICE|E_USER_WARNING
	 * @return void
	 */
	protected function end($message, $code = E_USER_NOTICE)
	{
		trigger_error($this->user->lang($message) . adm_back_link($this->u_action), $code);
	}
}


Pull Request — master (#25)

similar_topics_module::isset_or_default() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			/**
3			*
4			* Precise Similar Topics
5			*
6			* @copyright (c) 2013 Matt Friedman
7			* @license GNU General Public License, version 2 (GPL-2.0)
8			*
9			*/
10
11			namespace vse\similartopics\acp;
12
13			/**
14			* @package acp
15			*/
16			class similar_topics_module
17			{
18			/** @var \phpbb\cache\driver\driver_interface */
19			protected $cache;
20
21			/** @var \phpbb\config\config */
22			protected $config;
23
24			/** @var \phpbb\db\driver\driver_interface */
25			protected $db;
26
27			/** @var \vse\similartopics\driver\mysqli\|\vse\similartopics\driver\postgres */
28			protected $driver;
29
30			/** @var \phpbb\log\log */
31			protected $log;
32
33			/** @var \phpbb\request\request */
34			protected $request;
35
36			/** @var \phpbb\template\template */
37			protected $template;
38
39			/** @var \phpbb\user */
40			protected $user;
41
42			/** @var string */
43			protected $root_path;
44
45			/** @var string */
46			protected $php_ext;
47
48			/** @var array */
49			protected $times;
50
51			/** @var string */
52			public $page_title;
53
54			/** @var string */
55			public $tpl_name;
56
57			/** @var string */
58			public $u_action;
59
60			/**
61			* ACP module constructor
62			*
63			* @access public
64			*/
65			public function __construct()
66			{
67			global $phpbb_container;
68
69			$this->cache = $phpbb_container->get('cache');
70			$this->config = $phpbb_container->get('config');
71			$this->db = $phpbb_container->get('dbal.conn');
72			$this->driver = $phpbb_container->get('vse.similartopics.driver.manager')->get_driver($this->db->get_sql_layer());
73			$this->log = $phpbb_container->get('log');
74			$this->request = $phpbb_container->get('request');
75			$this->template = $phpbb_container->get('template');
76			$this->user = $phpbb_container->get('user');
77			$this->root_path = $phpbb_container->getParameter('core.root_path');
78			$this->php_ext = $phpbb_container->getParameter('core.php_ext');
79			$this->times = array(
80			'd' => 86400, // one day
81			'w' => 604800, // one week
82			'm' => 2626560, // one month
83			'y' => 31536000, // one year
84			);
85			}
86
87			/**
88			* Main ACP module
89			*
90			* @access public
91			*/
92			public function main()
93			{
94			$this->user->add_lang_ext('vse/similartopics', 'acp_similar_topics');
95
96			$this->tpl_name = 'acp_similar_topics';
97			$this->page_title = $this->user->lang('PST_TITLE_ACP');
98
99			$form_key = 'acp_similar_topics';
100			add_form_key($form_key);
101
102			$action = $this->request->variable('action', '');
103
104			switch ($action)
105			{
106			case 'advanced':
107			$forum_id = $this->request->variable('f', 0);
108
109			if ($this->request->is_set_post('submit'))
110			{
111			$this->check_form_key($form_key);
112
113			$similar_topic_forums = $this->request->variable('similar_forums_id', array(0));
114			$similar_topic_forums = !empty($similar_topic_forums) ? json_encode($similar_topic_forums) : '';
115
116			$sql = 'UPDATE ' . FORUMS_TABLE . "
117			SET similar_topic_forums = '" . $this->db->sql_escape($similar_topic_forums) . "'
118			WHERE forum_id = $forum_id";
119			$this->db->sql_query($sql);
120
121			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_MSG');
122
123			$this->end('PST_SAVED');
124			}
125
126			$forum_name = '';
127			$selected = array();
128			if ($forum_id > 0)
129			{
130			$sql = 'SELECT forum_name, similar_topic_forums
131			FROM ' . FORUMS_TABLE . "
132			WHERE forum_id = $forum_id";
133			$result = $this->db->sql_query($sql);
134			while ($fid = $this->db->sql_fetchrow($result))
135			{
136			$selected = json_decode($fid['similar_topic_forums'], true);
137			$forum_name = $fid['forum_name'];
138			}
139			$this->db->sql_freeresult($result);
140			}
141
142			$this->template->assign_vars(array(
143			'S_ADVANCED_SETTINGS' => true,
144			'SIMILAR_FORUMS_OPTIONS' => make_forum_select($selected, false, false, true),
145			'PST_FORUM_NAME' => $forum_name,
146			'PST_ADVANCED_EXP' => $this->user->lang('PST_ADVANCED_EXP', $forum_name),
147			'U_ACTION' => $this->u_action . '&action=advanced&f=' . $forum_id,
148			'U_BACK' => $this->u_action,
149			));
150			break;
151
152			default:
153			if ($this->request->is_set_post('submit'))
154			{
155			$this->check_form_key($form_key);
156
157			// Set basic config settings
158			$this->config->set('similar_topics', $this->request->variable('pst_enable', 0));
159			$this->config->set('similar_topics_limit', abs($this->request->variable('pst_limit', 0))); // use abs for positive values only
160			$this->config->set('similar_topics_cache', abs($this->request->variable('pst_cache', 0))); // use abs for positive values only
161			$this->config->set('similar_topics_words', $this->request->variable('pst_words', '', true));
162
163			// Set sensitivity
164			$pst_sense = min(abs($this->request->variable('pst_sense', 5)), 10); // use abs for positive values only
165			$this->config->set('similar_topics_sense', $pst_sense);
166
167			// Set date/time config settings
168			$pst_time = abs($this->request->variable('pst_time', 0)); // use abs for positive values only
169			$pst_time_type = $this->request->variable('pst_time_type', '');
170			$this->config->set('similar_topics_type', $pst_time_type);
171			$this->config->set('similar_topics_time', $this->set_pst_time($pst_time, $pst_time_type));
172
173			// Set checkbox array form data
174			$this->update_forum('similar_topics_hide', $this->request->variable('mark_noshow_forum', array(0), true));
175			$this->update_forum('similar_topics_ignore', $this->request->variable('mark_ignore_forum', array(0), true));
176
177			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_MSG');
178
179			$this->cache->destroy('sql', TOPICS_TABLE);
180
181			$this->end('PST_SAVED');
182			}
183
184			// Allow option to update the mysql database to enable FULLTEXT support
185			if ($this->request->is_set_post('fulltext'))
186			{
187			if (confirm_box(true))
188			{
189			// If FULLTEXT is not supported, lets make it so
190			if ($this->driver->get_type() === 'mysql' && !$this->fulltext_support_enabled())
191			{
192			// Alter the database to support FULLTEXT
193			$this->enable_mysql_fulltext_support();
194
195			// Store the original database storage engine in a config var for recovery on uninstall
196			$this->config->set('similar_topics_fulltext', (string) $this->driver->get_engine());
			0 ignored issues – show Bug introduced 2018-03-08 05:40 UTC by Report Bug Copy Issue Report The method `get_engine` does only exist in `vse\similartopics\driver\mysqli`, but not in `vse\similartopics\driver\postgres`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
197
198			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_FULLTEXT', time(), array(TOPICS_TABLE));
199
200			$this->end('PST_SAVE_FULLTEXT');
201			}
202			$this->end('PST_ERR_FULLTEXT', E_USER_WARNING);
203			}
204			confirm_box(false, $this->user->lang('CONFIRM_OPERATION'), build_hidden_fields(array(
205			'fulltext' => 1,
206			)));
207			}
208
209			// Build the time options select menu
210			$time_options = array(
211			'd' => $this->user->lang('PST_DAYS'),
212			'w' => $this->user->lang('PST_WEEKS'),
213			'm' => $this->user->lang('PST_MONTHS'),
214			'y' => $this->user->lang('PST_YEARS')
215			);
216			foreach ($time_options as $value => $label)
217			{
218			$this->template->assign_block_vars('similar_time_options', array(
219			'VALUE' => $value,
220			'LABEL' => $label,
221			'S_SELECTED' => $value == $this->config['similar_topics_type'],
222			));
223			}
224
225			$this->template->assign_vars(array(
226			'S_PST_ENABLE' => $this->isset_or_default($this->config['similar_topics'], false),
227			'PST_LIMIT' => $this->isset_or_default($this->config['similar_topics_limit'], ''),
228			'PST_CACHE' => $this->isset_or_default($this->config['similar_topics_cache'], ''),
229			'PST_SENSE' => $this->isset_or_default($this->config['similar_topics_sense'], ''),
230			'PST_WORDS' => $this->isset_or_default($this->config['similar_topics_words'], ''),
231			'PST_TIME' => $this->get_pst_time($this->config['similar_topics_time'], $this->config['similar_topics_type']),
232			'S_PST_NO_SUPPORT' => $this->driver === null \|\| !$this->fulltext_support_enabled(),
233			'S_PST_NO_COMPAT' => $this->driver === null,
234			'U_ACTION' => $this->u_action,
235			));
236
237			$forum_list = $this->get_forum_list();
238			foreach ($forum_list as $row)
239			{
240			$this->template->assign_block_vars('forums', array(
241			'FORUM_NAME' => $row['forum_name'],
242			'FORUM_ID' => $row['forum_id'],
243			'CHECKED_IGNORE_FORUM' => $row['similar_topics_ignore'] ? 'checked="checked"' : '',
244			'CHECKED_NOSHOW_FORUM' => $row['similar_topics_hide'] ? 'checked="checked"' : '',
245			'S_IS_ADVANCED' => (bool) $row['similar_topic_forums'],
246			'U_ADVANCED' => "{$this->u_action}&action=advanced&f=" . $row['forum_id'],
247			'U_FORUM' => append_sid("{$this->root_path}viewforum.{$this->php_ext}", 'f=' . $row['forum_id']),
248			));
249			}
250			break;
251			}
252			}
253
254			/**
255			* Check form key, trigger error if invalid
256			*
257			* @access protected
258			* @param string $form_key The form key value
259			*/
260			protected function check_form_key($form_key)
261			{
262			if (!check_form_key($form_key))
263			{
264			$this->end('FORM_INVALID', E_USER_WARNING);
265			}
266			}
267
268			/**
269			* Get forums list
270			*
271			* @access protected
272			* @return array forum data rows
273			*/
274			protected function get_forum_list()
275			{
276			$sql = 'SELECT forum_id, forum_name, similar_topic_forums, similar_topics_hide, similar_topics_ignore
277			FROM ' . FORUMS_TABLE . '
278			WHERE forum_type = ' . FORUM_POST . '
279			ORDER BY left_id ASC';
280			$result = $this->db->sql_query($sql);
281			$forum_list = $this->db->sql_fetchrowset($result);
282			$this->db->sql_freeresult($result);
283
284			return $forum_list;
285			}
286
287			/**
288			* Update the similar topics columns in the forums table
289			*
290			* @param string $column The name of the column to update
291			* @param array $forum_ids An array of forum_ids
292			*/
293			protected function update_forum($column, $forum_ids)
294			{
295			$this->db->sql_transaction('begin');
296
297			// Set marked forums (in set) to 1
298			$sql = 'UPDATE ' . FORUMS_TABLE . "
299			SET $column = 1
300			WHERE " . $this->db->sql_in_set('forum_id', $forum_ids, false, true);
301			$this->db->sql_query($sql);
302
303			// Set unmarked forums (not in set) to 0
304			$sql = 'UPDATE ' . FORUMS_TABLE . "
305			SET $column = 0
306			WHERE " . $this->db->sql_in_set('forum_id', $forum_ids, true, true);
307			$this->db->sql_query($sql);
308
309			$this->db->sql_transaction('commit');
310			}
311
312			/**
313			* Calculate the time in seconds based on requested time period length
314			*
315			* @access protected
316			* @param int $length user entered value
317			* @param string $type years, months, weeks, days (y\|m\|w\|d)
318			* @return int time in seconds
319			*/
320			protected function set_pst_time($length, $type = 'y')
321			{
322			$type = isset($this->times[$type]) ? $type : 'y';
323
324			return (int) ($length * $this->times[$type]);
325			}
326
327			/**
328			* Get the correct time period length value for the form
329			*
330			* @access protected
331			* @param int $time as a timestamp
332			* @param string $type years, months, weeks, days (y\|m\|w\|d)
333			* @return int time converted to the given $type
334			*/
335			protected function get_pst_time($time, $type = '')
336			{
337			return isset($this->times[$type]) ? (int) round($time / $this->times[$type]) : 0;
338			}
339
340			/**
341			* Check for FULLTEXT index support
342			*
343			* @access protected
344			* @return bool True if FULLTEXT is fully supported, false otherwise
345			*/
346			protected function fulltext_support_enabled()
347			{
348			if ($this->driver->is_supported())
349			{
350			return $this->driver->is_index('topic_title');
351			}
352
353			return false;
354			}
355
356			/**
357			* Enable FULLTEXT support for the topic_title
358			*
359			* @access protected
360			*/
361			protected function enable_mysql_fulltext_support()
362			{
363			// Alter the storage engine
364			$this->driver->alter_engine();
			0 ignored issues – show Bug introduced 2018-03-08 05:40 UTC by Report Bug Copy Issue Report The method `alter_engine` does only exist in `vse\similartopics\driver\mysqli`, but not in `vse\similartopics\driver\postgres`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
365
366			// Create the FULLTEXT index
367			$this->driver->create_fulltext_index('topic_title');
368			}
369
370			/**
371			* Return a variable if it is set, otherwise default
372			*
373			* @access protected
374			* @param mixed $var The variable to test
375			* @param mixed $default The default value to use
376			* @return mixed The value of the variable if set, otherwise default value
377			*/
378			protected function isset_or_default($var, $default)
379			{
380			return null !== $var ? $var : $default;
381			}
382
383			/**
384			* End script execution with a trigger_error message
385			*
386			* @access protected
387			* @param string $message Language key string
388			* @param int $code E_USER_NOTICE\|E_USER_WARNING
389			* @return void
390			*/
391			protected function end($message, $code = E_USER_NOTICE)
392			{
393			trigger_error($this->user->lang($message) . adm_back_link($this->u_action), $code);
394			}
395			}
396

iMattPro / similartopics

Pull Request — master (#25)

similar_topics_module::isset_or_default() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like