| Conditions | 18 |
| Paths | 30 |
| Total Lines | 156 |
| Code Lines | 97 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 92 | public function main() |
||
| 93 | { |
||
| 94 | $this->user->add_lang_ext('vse/similartopics', 'acp_similar_topics'); |
||
| 95 | |||
| 96 | $this->tpl_name = 'acp_similar_topics'; |
||
| 97 | $this->page_title = $this->user->lang('PST_TITLE_ACP'); |
||
| 98 | |||
| 99 | $form_key = 'acp_similar_topics'; |
||
| 100 | add_form_key($form_key); |
||
| 101 | |||
| 102 | $action = $this->request->variable('action', ''); |
||
| 103 | |||
| 104 | switch ($action) |
||
| 105 | { |
||
| 106 | case 'advanced': |
||
| 107 | $forum_id = $this->request->variable('f', 0); |
||
| 108 | |||
| 109 | if ($this->request->is_set_post('submit')) |
||
| 110 | { |
||
| 111 | $this->check_form_key($form_key); |
||
| 112 | |||
| 113 | $similar_topic_forums = $this->request->variable('similar_forums_id', array(0)); |
||
| 114 | $similar_topic_forums = !empty($similar_topic_forums) ? json_encode($similar_topic_forums) : ''; |
||
| 115 | |||
| 116 | $sql = 'UPDATE ' . FORUMS_TABLE . " |
||
| 117 | SET similar_topic_forums = '" . $this->db->sql_escape($similar_topic_forums) . "' |
||
| 118 | WHERE forum_id = $forum_id"; |
||
| 119 | $this->db->sql_query($sql); |
||
| 120 | |||
| 121 | $this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_MSG'); |
||
| 122 | |||
| 123 | $this->end('PST_SAVED'); |
||
| 124 | } |
||
| 125 | |||
| 126 | $forum_name = ''; |
||
| 127 | $selected = array(); |
||
| 128 | if ($forum_id > 0) |
||
| 129 | { |
||
| 130 | $sql = 'SELECT forum_name, similar_topic_forums |
||
| 131 | FROM ' . FORUMS_TABLE . " |
||
| 132 | WHERE forum_id = $forum_id"; |
||
| 133 | $result = $this->db->sql_query($sql); |
||
| 134 | while ($fid = $this->db->sql_fetchrow($result)) |
||
| 135 | { |
||
| 136 | $selected = json_decode($fid['similar_topic_forums'], true); |
||
| 137 | $forum_name = $fid['forum_name']; |
||
| 138 | } |
||
| 139 | $this->db->sql_freeresult($result); |
||
| 140 | } |
||
| 141 | |||
| 142 | $this->template->assign_vars(array( |
||
| 143 | 'S_ADVANCED_SETTINGS' => true, |
||
| 144 | 'SIMILAR_FORUMS_OPTIONS' => make_forum_select($selected, false, false, true), |
||
| 145 | 'PST_FORUM_NAME' => $forum_name, |
||
| 146 | 'PST_ADVANCED_EXP' => $this->user->lang('PST_ADVANCED_EXP', $forum_name), |
||
| 147 | 'U_ACTION' => $this->u_action . '&action=advanced&f=' . $forum_id, |
||
| 148 | 'U_BACK' => $this->u_action, |
||
| 149 | )); |
||
| 150 | break; |
||
| 151 | |||
| 152 | default: |
||
| 153 | if ($this->request->is_set_post('submit')) |
||
| 154 | { |
||
| 155 | $this->check_form_key($form_key); |
||
| 156 | |||
| 157 | // Set basic config settings |
||
| 158 | $this->config->set('similar_topics', $this->request->variable('pst_enable', 0)); |
||
| 159 | $this->config->set('similar_topics_limit', abs($this->request->variable('pst_limit', 0))); // use abs for positive values only |
||
| 160 | $this->config->set('similar_topics_cache', abs($this->request->variable('pst_cache', 0))); // use abs for positive values only |
||
| 161 | $this->config->set('similar_topics_words', $this->request->variable('pst_words', '', true)); |
||
| 162 | |||
| 163 | // Set sensitivity |
||
| 164 | $pst_sense = min(abs($this->request->variable('pst_sense', 5)), 10); // use abs for positive values only |
||
| 165 | $this->config->set('similar_topics_sense', $pst_sense); |
||
| 166 | |||
| 167 | // Set date/time config settings |
||
| 168 | $pst_time = abs($this->request->variable('pst_time', 0)); // use abs for positive values only |
||
| 169 | $pst_time_type = $this->request->variable('pst_time_type', ''); |
||
| 170 | $this->config->set('similar_topics_type', $pst_time_type); |
||
| 171 | $this->config->set('similar_topics_time', $this->set_pst_time($pst_time, $pst_time_type)); |
||
| 172 | |||
| 173 | // Set checkbox array form data |
||
| 174 | $this->update_forum('similar_topics_hide', $this->request->variable('mark_noshow_forum', array(0), true)); |
||
| 175 | $this->update_forum('similar_topics_ignore', $this->request->variable('mark_ignore_forum', array(0), true)); |
||
| 176 | |||
| 177 | // Set PostgreSQL TS Name |
||
| 178 | if ($this->similartopics && $this->similartopics->get_type() === 'postgres') |
||
| 179 | { |
||
| 180 | $ts_name = $this->request->variable('pst_postgres_ts_name', ($this->config['pst_postgres_ts_name'] ?: 'simple')); |
||
| 181 | $this->config->set('pst_postgres_ts_name', $ts_name); |
||
| 182 | $this->similartopics->create_fulltext_index('topic_title'); |
||
| 183 | } |
||
| 184 | |||
| 185 | $this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'PST_LOG_MSG'); |
||
| 186 | |||
| 187 | $this->cache->destroy('sql', TOPICS_TABLE); |
||
| 188 | |||
| 189 | $this->end('PST_SAVED'); |
||
| 190 | } |
||
| 191 | |||
| 192 | // Build the time options select menu |
||
| 193 | $time_options = array( |
||
| 194 | 'd' => $this->user->lang('PST_DAYS'), |
||
| 195 | 'w' => $this->user->lang('PST_WEEKS'), |
||
| 196 | 'm' => $this->user->lang('PST_MONTHS'), |
||
| 197 | 'y' => $this->user->lang('PST_YEARS') |
||
| 198 | ); |
||
| 199 | foreach ($time_options as $value => $label) |
||
| 200 | { |
||
| 201 | $this->template->assign_block_vars('similar_time_options', array( |
||
| 202 | 'VALUE' => $value, |
||
| 203 | 'LABEL' => $label, |
||
| 204 | 'S_SELECTED' => $value === $this->config['similar_topics_type'], |
||
| 205 | )); |
||
| 206 | } |
||
| 207 | |||
| 208 | $this->template->assign_vars(array( |
||
| 209 | 'S_PST_ENABLE' => $this->isset_or_default($this->config['similar_topics'], false), |
||
| 210 | 'PST_LIMIT' => $this->isset_or_default($this->config['similar_topics_limit'], ''), |
||
| 211 | 'PST_CACHE' => $this->isset_or_default($this->config['similar_topics_cache'], ''), |
||
| 212 | 'PST_SENSE' => $this->isset_or_default($this->config['similar_topics_sense'], ''), |
||
| 213 | 'PST_WORDS' => $this->isset_or_default($this->config['similar_topics_words'], ''), |
||
| 214 | 'PST_TIME' => $this->get_pst_time($this->config['similar_topics_time'], $this->config['similar_topics_type']), |
||
| 215 | 'S_PST_NO_COMPAT' => $this->similartopics === null || !$this->similartopics->is_fulltext('topic_title'), |
||
| 216 | 'U_ACTION' => $this->u_action, |
||
| 217 | )); |
||
| 218 | |||
| 219 | // If postgresql, we need to make an options list of text search names |
||
| 220 | if ($this->similartopics && $this->similartopics->get_type() === 'postgres') |
||
| 221 | { |
||
| 222 | $this->user->add_lang('acp/search'); |
||
| 223 | foreach ($this->get_cfgname_list() as $row) |
||
| 224 | { |
||
| 225 | $this->template->assign_block_vars('postgres_ts_names', array( |
||
| 226 | 'NAME' => $row['ts_name'], |
||
| 227 | 'S_SELECTED' => $row['ts_name'] === $this->config['pst_postgres_ts_name'], |
||
| 228 | )); |
||
| 229 | } |
||
| 230 | } |
||
| 231 | |||
| 232 | $forum_list = $this->get_forum_list(); |
||
| 233 | foreach ($forum_list as $row) |
||
| 234 | { |
||
| 235 | $this->template->assign_block_vars('forums', array( |
||
| 236 | 'FORUM_NAME' => $row['forum_name'], |
||
| 237 | 'FORUM_ID' => $row['forum_id'], |
||
| 238 | 'CHECKED_IGNORE_FORUM' => $row['similar_topics_ignore'] ? 'checked="checked"' : '', |
||
| 239 | 'CHECKED_NOSHOW_FORUM' => $row['similar_topics_hide'] ? 'checked="checked"' : '', |
||
| 240 | 'S_IS_ADVANCED' => (bool) $row['similar_topic_forums'], |
||
| 241 | 'U_ADVANCED' => "{$this->u_action}&action=advanced&f=" . $row['forum_id'], |
||
| 242 | 'U_FORUM' => append_sid("{$this->root_path}viewforum.{$this->php_ext}", 'f=' . $row['forum_id']), |
||
| 243 | )); |
||
| 244 | } |
||
| 245 | break; |
||
| 246 | } |
||
| 247 | } |
||
| 248 | |||
| 376 |