Issues in ext.php - Fixed Issues - Inspection of "Refactor custom error messages during installation" - iMattPro/TopicImagePreview - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 32a24c...7e88dd )

by Matt

created 2017-04-23 17:27 UTC

ext.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 * Topic Image Preview. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017, Matt Friedman
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace vse\TopicImagePreview;

class ext extends \phpbb\extension\base
{
	/**
	 * {@inheritdoc}
	 */
	public function is_enableable()
	{
		// Requires phpBB 3.2.0 or newer.
		$is_enableable = phpbb_version_compare(PHPBB_VERSION, '3.2.0', '>=');

		// Display a custom warning message if requirement fails.
		if (!$is_enableable)
		{
			$lang = $this->container->get('language');
			$lang->add_lang('tip_acp', 'vse/TopicImagePreview');

			// Suppress the error in case of CLI usage
			@trigger_error($lang->lang('ACP_TIP_INSTALL_ERROR'), E_USER_WARNING);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}

		return $is_enableable;
	}
}


1			<?php
2			/**
3			*
4			* Topic Image Preview. An extension for the phpBB Forum Software package.
5			*
6			* @copyright (c) 2017, Matt Friedman
7			* @license GNU General Public License, version 2 (GPL-2.0)
8			*
9			*/
10
11			namespace vse\TopicImagePreview;
12
13			class ext extends \phpbb\extension\base
14			{
15			/**
16			* {@inheritdoc}
17			*/
18			public function is_enableable()
19			{
20			// Requires phpBB 3.2.0 or newer.
21			$is_enableable = phpbb_version_compare(PHPBB_VERSION, '3.2.0', '>=');
22
23			// Display a custom warning message if requirement fails.
24			if (!$is_enableable)
25			{
26			$lang = $this->container->get('language');
27			$lang->add_lang('tip_acp', 'vse/TopicImagePreview');
28
29			// Suppress the error in case of CLI usage
30			@trigger_error($lang->lang('ACP_TIP_INSTALL_ERROR'), E_USER_WARNING);
			0 ignored issues – show Security Best Practice introduced 2017-03-14 17:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
31			}
32
33			return $is_enableable;
34			}
35			}
36

iMattPro / TopicImagePreview

Push — master ( 32a24c...7e88dd )

ext.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like