ext::is_enableable() - Code Metrics - Inspection of "Update to beta 1" - iMattPro/TopicImagePreview - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61be05...2cc598 )

by Matt

created 2017-04-21 18:22 UTC

ext::is_enableable() A

↳ Parent: ext

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
rs	9.4285
cc	2
eloc	7
nc	2
nop	0

<?php
/**
 *
 * Topic Image Preview. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2017, Matt Friedman
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace vse\TopicImagePreview;

class ext extends \phpbb\extension\base
{
	/**
	 * {@inheritdoc}
	 */
	public function is_enableable()
	{
		// Requires phpBB 3.2.0 or newer.
		$is_enableable = phpbb_version_compare(PHPBB_VERSION, '3.2.0', '>=');

		// Display a custom warning message if requirement fails.
		if (!$is_enableable)
		{
			$lang = $this->container->get('language');
			$lang->add_lang('tip_acp', 'vse/TopicImagePreview');

			// Suppress the error in case of CLI usage
			@trigger_error($lang->lang('ACP_TIP_INSTALL_ERROR'), E_USER_WARNING);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}

		return $is_enableable;
	}
}


1			<?php
2			/**
3			*
4			* Topic Image Preview. An extension for the phpBB Forum Software package.
5			*
6			* @copyright (c) 2017, Matt Friedman
7			* @license GNU General Public License, version 2 (GPL-2.0)
8			*
9			*/
10
11			namespace vse\TopicImagePreview;
12
13			class ext extends \phpbb\extension\base
14			{
15			/**
16			* {@inheritdoc}
17			*/
18			public function is_enableable()
19			{
20			// Requires phpBB 3.2.0 or newer.
21			$is_enableable = phpbb_version_compare(PHPBB_VERSION, '3.2.0', '>=');
22
23			// Display a custom warning message if requirement fails.
24			if (!$is_enableable)
25			{
26			$lang = $this->container->get('language');
27			$lang->add_lang('tip_acp', 'vse/TopicImagePreview');
28
29			// Suppress the error in case of CLI usage
30			@trigger_error($lang->lang('ACP_TIP_INSTALL_ERROR'), E_USER_WARNING);
			0 ignored issues – show Security Best Practice introduced 2017-03-14 17:20 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
31			}
32
33			return $is_enableable;
34			}
35			}
36

iMattPro / TopicImagePreview

Push — master ( 61be05...2cc598 )

ext::is_enableable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like