iFaxity / dbwebb-ramverk1-module

src/Fetch/Fetch.php

<?php

namespace Faxity\Fetch;

/**
 * Send HTTP requests via cURL
 */
class Fetch
{
    /**
     * Initializes a curl request
     * @param string $url URL to send request to
     * @param mixed $params Optional query parameters as an array or object
     *
     * @return resource|bool
     */
    private function initRequest(string $url, $params)
    {
        if ($params) {
            $query = "";

The assignment to $query is dead and can be removed.

            if (is_object($params) || is_array($params)) {
                $query = http_build_query($params);
                $url .= $query ? "?$query" : "";
            }
        }

        $curl = curl_init($url);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        return $curl;
    }


    /**
     * Sends a GET request to URL
     * @param string $url URL to send request to
     * @param mixed $params Optional query parameters as an array or object
     *
     * @return object
     */
    public function get(string $url, $params = null) : ?object
    {
        $curl = self::initRequest($url, $params);

The method Faxity\Fetch\Fetch::initRequest() is not static, but was called statically.

        $body = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        // Parse response as json
        return json_decode($body);
    }


    /**
     * Sends multiple GET requests in parallell
     * @param array $requests An array of assoc-arrays with url and params as keys, like:
     * [
     *   "url" => "",
     *   "params" => [ "param" => "" ]
     * ]
     */
    public function getMulti(array $requests)
    {
        $multi = curl_multi_init();

        // Create handles for cURL request
        $handles = array_map(function ($item) use ($multi) {
            $handle = self::initRequest($item["url"], $item["params"] ?? null);

The method Faxity\Fetch\Fetch::initRequest() is not static, but was called statically.

            curl_multi_add_handle($multi, $handle);

It seems like $handle can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

            return $handle;
        }, $requests);

        // Execute requests in parallell and wait for all to complete
        do {
            $status = curl_multi_exec($multi, $active);
            $active && curl_multi_select($multi); // Prevents CPU overusage
        } while ($active && $status == CURLM_OK);


        // Cleanup and get content
        $content = array_map(function ($handle) use ($multi) {
            curl_multi_remove_handle($multi, $handle);

            $body = curl_multi_getcontent($handle);
            return json_decode($body);
        }, $handles);

        curl_multi_close($multi);

        return $content;
    }
}