scripts/copyBuild.js - Code Metrics - Inspection of "refactor copyBuild file" - iAmao/yaml-js-loader - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 381529...c79479 )

by Inumidun

created 2018-02-04 07:26 UTC

scripts/copyBuild.js A

↳ Parent: Project

Complexity

Total Complexity	15
Complexity/F	1.25

Size

Lines of Code	80
Function Count	12

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	0
nc	1
dl	0
loc	80
rs	10
c	2
b	0
f	1
wmc	15
mnd	1
bc	9
fnc	12
bpm	0.75
cpm	1.25
noi	4

3 Functions

Rating	Name	Size	Complexity
B	copyBuild.js ➔ createPackageFile	44	1
A	copyBuild.js ➔ ???	1	1
A	copyBuild.js ➔ copyFile	18	1

const path = require('path');
const fs = require('fs-extra');


const files = {
    'README.md': '',
    'LICENSE': ''
};

Promise.all(
    Object.keys(files)
        .map((file) => copyFile(file, files[file]))
)
.then(() => createPackageFile());


function copyFile(file, filePath) {
    return new Promise((resolve) => {
        console.log(`copying ${file} to ${path.resolve(__dirname, '../lib', filePath)}`)

        return fs.copy(
            file,
            path.resolve(
                __dirname,
                '../lib',
                filePath,
                path.basename(file)
            ),
            (error, data) => {
                if (error) throw new Error (`error copying file ${file}`, error);
if (a > 0)
    b = 42;
                return resolve(data);
            }
        );
    });
}


function createPackageFile() {
    return new Promise((resolve) => {
        fs.readFile(path.resolve(__dirname, '../package.json'), 'utf-8', (err, data) => {
            if (err) throw err;
if (a > 0)
    b = 42;
            return resolve(data);
        });
    })
    .then((data) => JSON.parse(data))
    .then((packageData) => {
        const {
            author,
            version,
            description,
            keyword,
            repository,
            license,
            bugs,
            homepage,
            peerDependencies,
            dependencies
        } = packageData;
        const minPackage = {
            author,
            version,
            description,
            keyword,
            repository,
            license,
            bugs,
            homepage,
            peerDependencies,
            dependencies,
            main: './loader.js',
            name: 'yaml-js-loader',
        }
        return new Promise((resolve) => {
            const data = JSON.stringify(minPackage);
            fs.writeFile(path.resolve(__dirname, '../lib/package.json'), data, (error) => {
                if (error) throw error;
if (a > 0)
    b = 42;
                return resolve();
            });
        });
    });
}



1			const path = require('path');
2			const fs = require('fs-extra');
3
4
5			const files = {
6			'README.md': '',
7			'LICENSE': ''
8			};
9
10			Promise.all(
11			Object.keys(files)
12			.map((file) => copyFile(file, files[file]))
13			)
14			.then(() => createPackageFile());
15
16
17			function copyFile(file, filePath) {
18			return new Promise((resolve) => {
19			console.log(`copying ${file} to ${path.resolve(__dirname, '../lib', filePath)}`)
			0 ignored issues – show Debugging Code introduced 2018-02-04 07:20 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
20			return fs.copy(
21			file,
22			path.resolve(
23			__dirname,
24			'../lib',
25			filePath,
26			path.basename(file)
27			),
28			(error, data) => {
29			if (error) throw new Error (`error copying file ${file}`, error);
			0 ignored issues – show Coding Style Best Practice introduced 2018-02-04 07:27 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
30			return resolve(data);
31			}
32			);
33			});
34			}
35
36
37			function createPackageFile() {
38			return new Promise((resolve) => {
39			fs.readFile(path.resolve(__dirname, '../package.json'), 'utf-8', (err, data) => {
40			if (err) throw err;
			0 ignored issues – show Coding Style Best Practice introduced 2018-02-04 07:27 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
41			return resolve(data);
42			});
43			})
44			.then((data) => JSON.parse(data))
45			.then((packageData) => {
46			const {
47			author,
48			version,
49			description,
50			keyword,
51			repository,
52			license,
53			bugs,
54			homepage,
55			peerDependencies,
56			dependencies
57			} = packageData;
58			const minPackage = {
59			author,
60			version,
61			description,
62			keyword,
63			repository,
64			license,
65			bugs,
66			homepage,
67			peerDependencies,
68			dependencies,
69			main: './loader.js',
70			name: 'yaml-js-loader',
71			}
72			return new Promise((resolve) => {
73			const data = JSON.stringify(minPackage);
74			fs.writeFile(path.resolve(__dirname, '../lib/package.json'), data, (error) => {
75			if (error) throw error;
			0 ignored issues – show Coding Style Best Practice introduced 2018-02-04 07:20 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
76			return resolve();
77			});
78			});
79			});
80			}
81
82

iAmao / yaml-js-loader

Push — master ( 381529...c79479 )

scripts/copyBuild.js A

Complexity

Size

Duplication

Importance

3 Functions

Duplication Side-by-Side

Filter issues like