i-lateral / silverstripe-reviews

src/Extensions/CommentExtension.php

<?php

namespace ilateral\SilverStripe\Reviews\Extensions;

use SilverStripe\ORM\DataExtension;
use ilateral\SilverStripe\Reviews\Helpers\ReviewHelper;
use SilverStripe\Forms\FieldList;

class CommentExtension extends DataExtension
{
    private static $db = [

The private property $db is not used, and could be removed.

        'Rating' => 'Int'
    ];

    private static $casting = [

The private property $casting is not used, and could be removed.

        'MaxRating' => 'Int',
        'RatingStars' => 'HTMLText',
        'ExcessStars' => 'HTMLText'
    ];

    private static $summary_fields = [

The private property $summary_fields is not used, and could be removed.

        'Rating'
    ];

    public function getMaxRating()
    {
        return $this->getOwner()->Parent()->getCommentsOption('max_rating');
    }

    /**
     * Get the rating as HTML Star characters
     * (one star per increment of rating).
     * 
     * @return string
     */
    public function getRatingStars()
    {
        return ReviewHelper::getStarsFromValues(
            $this->getOwner()->Parent()->getCommentsOption('min_rating'),
            round($this->getOwner()->Rating)

round($this->getOwner()->Rating) of type double is incompatible with the type integer expected by parameter $max of ilateral\SilverStripe\Reviews\Helpers\ReviewHelper::getStarsFromValues().

        );
    }

    /**
     * Get the excess rating as HTML Star characters
     * (one star per increment of rating).
     * 
     * @return string
     */
    public function getExcessStars()
    {
        $max = $this->getOwner()->Parent()->getCommentsOption("max_rating");
        $rating = $this->getOwner()->Rating;
        $excess = $max - round($rating);

        return ReviewHelper::getStarsFromValues(
            $this->getOwner()->Parent()->getCommentsOption("min_rating"),
            $excess,

$excess of type double is incompatible with the type integer expected by parameter $max of ilateral\SilverStripe\Reviews\Helpers\ReviewHelper::getStarsFromValues().

            $html = "☆"
        );
    }

    public function updateCMSFields(FieldList $fields)
    {
        /** @var \SilverStripe\Comments\Model\Comment */
        $owner = $this->getOwner();

        $fields->insertBefore(
            'Name',
            $owner->dbObject('Rating')->scaffoldFormField($owner->fieldLabel('Rating'))
        );
    }
}