GalleryPage_Controller

Complexity

Total Complexity

14

Size/Duplication

Total Lines	104
Duplicated Lines	9.62 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	3	1
A	PaginatedImages()	10	10	1
C	ScaledImage()	0	37	7

<?php

class GalleryPage_Controller extends Page_Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function init() {
        parent::init();
    }

    public function PaginatedImages()

This method seems to be duplicated in your project.

    {
        $list = $this->SortedImages();
        $limit = $this->ThumbnailsPerPage;

        $pages = PaginatedList::create($list, $this->getRequest());
        $pages->setpageLength($limit);

        return $pages;
    }

    /**
     * Generate an image based on the provided type
     * (either )
     *
     * @param Image $image
     * @param string $thumbnail generate a smaller image (based on thumbnail settings)

Should the type for parameter $thumbnail not be false|string?

     * @return void

Should the return type not be Image|null|false?

     */
    protected function ScaledImage(Image $image, $thumbnail = false)
    {
        $img = false;
        $background = $this->PaddedImageBackground;
        
        if ($thumbnail) {

The expression $thumbnail of type false|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

            $resize_type = $this->ThumbnailResizeType;
            $width = $this->ThumbnailWidth;
            $height = $this->ThumbnailHeight;
        } else {
            $resize_type = $this->ImageResizeType;
            $width = $this->ImageWidth;
            $height = $this->ImageHeight;
        }

        switch ($resize_type) {
            case 'crop':
                $img = $image->CroppedImage($width,$height);

The method Image::CroppedImage() has been deprecated with message: 4.0 Use Fill instead

                break;
            case 'pad':
                $img = $image->PaddedImage($width,$height,$background);

The method Image::PaddedImage() has been deprecated with message: 4.0 Use Pad instead

                break;
            case 'ratio':
                $img = $image->SetRatioSize($width,$height);

The method Image::SetRatioSize() has been deprecated with message: 4.0 Use Fit instead

                break;
            case 'width':
                $img = $image->ScaleWidth($width);
                break;
            case 'height':
                $img = $image->ScaleHeight($height);
                break;
        }

        $this->extend("augmentImageResize", $image, $thumbnail, $img);

        return $img;
    }

    protected function GalleryImage(Image $image)
    {
        return $this->ScaledImage($image);
    }

    protected function GalleryThumbnail(Image $image)
    {
        return $this->ScaledImage($image, true);
    }

    /**
     * Generate an image gallery from the Gallery template, if no images are
     * available, then return an empty string.
     *
     * @return string
     */
    public function Gallery()
    {
        if ($this->Images()->exists()) {

            // Create a list of images with generated gallery image and thumbnail
            $images = ArrayList::create();
            foreach ($this->PaginatedImages() as $image) {
                $image_data = $image->toMap();
                $image_data["GalleryImage"] = $this->GalleryImage($image);
                $image_data["GalleryThumbnail"] = $this->GalleryThumbnail($image);
                $images->add(ArrayData::create($image_data));
            }
            
            $vars = array(
                'Images' => $images,
                'Width' => $this->ImageWidth,
                'Height' => $this->ImageHeight
            );

            return $this->renderWith('Gallery',$vars);
        } else {
            return "";
        }
    }
}