GalleryPage

Complexity

Total Complexity

7

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	0	27	2

<?php

/**
 * A single page that can display many images as thumbnails.
 * 
 * @package gallery
 */
class GalleryPage extends GalleryHub

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var string
     */
    private static $description = 'Display a "gallery" of images';

Consider using a different property name as you override a private property of the parent class.

The property $description is not used and could be removed.

    private static $icon = "gallery/images/gallery.png";

Consider using a different property name as you override a private property of the parent class.

The property $icon is not used and could be removed.

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        "ImageWidth" => "Int",
        "ImageHeight" => "Int",
        "ImageResizeType" => "Enum(array('crop','pad','ratio','width','height'), 'ratio')"
    );

    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

        "ImageWidth" => 950,
        "ImageHeight" => 500,
        "ShowSideBar" => 1
    );

    private static $many_many = array(

The property $many_many is not used and could be removed.

        'Images' => 'Image'
    );

    private static $many_many_extraFields = array(

The property $many_many_extraFields is not used and could be removed.

        'Images' => array('SortOrder' => 'Int')
    );

    /**
     * Return sorted images
     *
     * @return ArrayList
     */
    public function SortedImages()
    {
        return $this->Images()->Sort('SortOrder');
    }

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $self =& $this;
        
        $this->beforeUpdateCMSFields(function ($fields) use ($self) {
            if (!$self->canEdit()) {
                return;
            }
            
            $fields->removeByName('HideDescription');
            
            $upload_folder = Controller::join_links(
                "gallery",
                $self->ID
            );
            
            $fields->addFieldToTab(
                "Root.Gallery",
                SortableUploadField::create(
                    'Images',
                    $this->fieldLabel('Images')
                )->setFolderName($upload_folder)
            );
        });
            
        return parent::getCMSFields();
    }

    public function getSettingsFields() {

The return type could not be reliably inferred; please add a @return annotation.

        $fields = parent::getSettingsFields();

        $fields->addFieldsToTab(
            'Root.Settings',
            array(
                NumericField::create("ImageWidth"),
                NumericField::create("ImageHeight"),
                DropdownField::create("ImageResizeType")
                    ->setSource($this->dbObject("ImageResizeType")->enumValues())
            )
        );

        return $fields;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        // default settings (if not set)
        $defaults = $this->config()->defaults;
        $this->ImageWidth = ($this->ImageWidth) ? $this->ImageWidth : $defaults["ImageWidth"];
        $this->ImageHeight = ($this->ImageHeight) ? $this->ImageHeight : $defaults["ImageHeight"];
    }

}