SilverStripe\GridFieldAddOns\GridFieldDetailFormExtension

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	updateItemRequestClass()	0	16	4

<?php

namespace SilverStripe\GridFieldAddOns;

use SilverStripe\Core\Extension;
use SilverStripe\Forms\GridField\GridFieldDetailForm_ItemRequest;

/**
 * Allow DataObjects to specify a custom GridFieldDetailForm_ItemRequest class
 * via SilverStripe config.
 * 
 * This class will then be used to build the GridFieldDetailForm automatically
 */
class GridFieldDetailFormExtension extends Extension
{

    /**
     * @param string $class
     * @param GridField $gridField
     * @param DataObject $record
     * @param RequestHandler $requestHandler
     * @param string $assignedClass Name of class explicitly assigned to this component

Should the type for parameter $assignedClass not be string|null?

     */
    public function updateItemRequestClass(&$class, $gridField, $record, $requestHandler, $assignedClass = null)

The parameter $gridField is not used and could be removed.

The parameter $requestHandler is not used and could be removed.

    {
        // Avoid overriding explicitly assigned class name if set using setItemRequestClass()
        if ($assignedClass) {

The expression $assignedClass of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return;
        }

        $custom = $record->config()->get('gridfield_request_class');

        // if custom is a valid class, switch item request class
        if (isset($custom)
            && is_subclass_of($custom, GridFieldDetailForm_ItemRequest::class)
        ) {
            $class = $custom;
        }
    }
}